From 81529f59455b00b2aa0e7b36f8dee872567143a3 Mon Sep 17 00:00:00 2001 From: dyh Date: Fri, 7 Aug 2020 18:01:17 +0800 Subject: Don't modify the config file with sed in the docker entrypoint script Change-Id: Iac13019024cb5d6c05a32ae358e1892e025f95dc Issue-ID: VFC-1623 Signed-off-by: dyh --- zte/vmanager/docker/docker-entrypoint.sh | 25 ++----------------------- zte/vmanager/docker/instance_config.sh | 27 --------------------------- zte/vmanager/driver/pub/config/config.py | 9 ++++----- 3 files changed, 6 insertions(+), 55 deletions(-) delete mode 100755 zte/vmanager/docker/instance_config.sh diff --git a/zte/vmanager/docker/docker-entrypoint.sh b/zte/vmanager/docker/docker-entrypoint.sh index 38ea9778..20bc97f9 100755 --- a/zte/vmanager/docker/docker-entrypoint.sh +++ b/zte/vmanager/docker/docker-entrypoint.sh @@ -1,29 +1,8 @@ #!/bin/bash -if [ -z "$SERVICE_IP" ]; then - export SERVICE_IP=`hostname -i` -fi -echo "SERVICE_IP=$SERVICE_IP" - -if [ -z "$MSB_ADDR" ]; then - echo "Missing required variable MSB_ADDR: Microservices Service Bus address :" - exit 1 -fi -echo "MSB_ADDR=$MSB_ADDR" - -# Wait for MSB initialization -echo "Wait for MSB initialization" -for i in {1..5}; do - curl -sS -m 1 $MSB_PROTO://$MSB_ADDR/msb -k > /dev/null - res=$? - if [ $res -ne 0 ]; then - break - fi - sleep $i -done - # Configure service based on docker environment variables -vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/docker/instance_config.sh +python vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py +cat vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py # microservice-specific one-time initialization vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/docker/instance_init.sh diff --git a/zte/vmanager/docker/instance_config.sh b/zte/vmanager/docker/instance_config.sh deleted file mode 100755 index 3abc85c1..00000000 --- a/zte/vmanager/docker/instance_config.sh +++ /dev/null @@ -1,27 +0,0 @@ -#!/bin/bash - -MSB_PROTO=`echo $MSB_PROTO` -MSB_IP=`echo $MSB_ADDR | cut -d: -f 1` -MSB_PORT=`echo $MSB_ADDR | cut -d: -f 2` - -if [ $REG_TO_MSB_WHEN_START ]; then - sed -i "s|REG_TO_MSB_WHEN_START = .*|REG_TO_MSB_WHEN_START = '$REG_TO_MSB_WHEN_START'|" vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py -fi - -if [ $MSB_PROTO ]; then - sed -i "s|MSB_SERVICE_PROTOCOL = .*|MSB_SERVICE_PROTOCOL = '$MSB_PROTO'|" vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py -fi - -if [ $MSB_IP ]; then - sed -i "s|MSB_SERVICE_IP = .*|MSB_SERVICE_IP = '$MSB_IP'|" vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py -fi - -if [ $MSB_PORT ]; then - sed -i "s|MSB_SERVICE_PORT = .*|MSB_SERVICE_PORT = '$MSB_PORT'|" vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py -fi - -if [ $SERVICE_IP ]; then - sed -i "s|\"ip\": \".*\"|\"ip\": \"$SERVICE_IP\"|" vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py -fi - -cat vfc/nfvo/driver/vnfm/svnfm/zte/vmanager/driver/pub/config/config.py diff --git a/zte/vmanager/driver/pub/config/config.py b/zte/vmanager/driver/pub/config/config.py index 2eeff668..c9321687 100644 --- a/zte/vmanager/driver/pub/config/config.py +++ b/zte/vmanager/driver/pub/config/config.py @@ -11,15 +11,14 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. +import os # [VNFFTP] VNF_FTP = "ftp://VMVNFM:Vnfm_1g3T@127.0.0.1:21/" # [MSB] -MSB_SERVICE_PROTOCOL = 'http' -MSB_SERVICE_IP = '127.0.0.1' -MSB_SERVICE_PORT = '443' -MSB_BASE_URL = "%s://%s:%s" % (MSB_SERVICE_PROTOCOL, MSB_SERVICE_IP, MSB_SERVICE_PORT) +MSB_BASE_URL = os.getenv("MSB_HOST", "http://127.0.0.1:80") +MSB_ENABLED = os.getenv("MSB_ENABLED", True) # [MDC] SERVICE_NAME = "ztevnfmdriver" @@ -27,7 +26,7 @@ FORWARDED_FOR_FIELDS = ["HTTP_X_FORWARDED_FOR", "HTTP_X_FORWARDED_HOST", "HTTP_X_FORWARDED_SERVER"] # [register] -REG_TO_MSB_WHEN_START = True +REG_TO_MSB_WHEN_START = os.getenv("REG_TO_MSB_WHEN_START", "false") REG_TO_MSB_REG_URL = "/api/microservices/v1/services" REG_TO_MSB_REG_PARAM = { "serviceName": "ztevnfmdriver", -- cgit 1.2.3-korg