From f07c74c83343da4a8751d7f45fb1edcd111e3647 Mon Sep 17 00:00:00 2001 From: Alexis de Talhouët Date: Tue, 26 Feb 2019 11:26:03 -0500 Subject: Add CDS client MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I3f77a2c9e8341239b97675f5897cecf28c7dfb6f Issue-ID: SO-1483 Signed-off-by: Alexis de Talhouët --- common/pom.xml | 379 ++++++++++++--------- .../onap/so/client/cds/CDSProcessingClient.java | 112 ++++++ .../onap/so/client/cds/CDSProcessingHandler.java | 82 +++++ .../onap/so/client/cds/CDSProcessingListener.java | 25 ++ .../java/org/onap/so/client/cds/CDSProperties.java | 25 ++ .../so/client/cds/CDSProcessingClientTest.java | 162 +++++++++ .../so/client/cds/TestCDSProcessingListener.java | 37 ++ .../onap/so/client/cds/TestCDSPropertiesImpl.java | 61 ++++ .../services/org.onap.so.client.RestProperties | 1 + 9 files changed, 721 insertions(+), 163 deletions(-) create mode 100644 common/src/main/java/org/onap/so/client/cds/CDSProcessingClient.java create mode 100644 common/src/main/java/org/onap/so/client/cds/CDSProcessingHandler.java create mode 100644 common/src/main/java/org/onap/so/client/cds/CDSProcessingListener.java create mode 100644 common/src/main/java/org/onap/so/client/cds/CDSProperties.java create mode 100644 common/src/test/java/org/onap/so/client/cds/CDSProcessingClientTest.java create mode 100644 common/src/test/java/org/onap/so/client/cds/TestCDSProcessingListener.java create mode 100644 common/src/test/java/org/onap/so/client/cds/TestCDSPropertiesImpl.java create mode 100644 common/src/test/resources/META-INF/services/org.onap.so.client.RestProperties (limited to 'common') diff --git a/common/pom.xml b/common/pom.xml index 6bd142ddb2..7772453e60 100644 --- a/common/pom.xml +++ b/common/pom.xml @@ -1,179 +1,232 @@ - - 4.0.0 - + + 4.0.0 + org.onap.so so 1.4.0-SNAPSHOT - - common - MSO Common classes - MSO Common classes:- Logger - - - org.apache.httpcomponents - httpclient - - - javax.servlet - javax.servlet-api - - - org.springframework - spring-aspects - - + + common + MSO Common classes + MSO Common classes:- Logger + + + 1.17.1 + 3.6.1 + 4.1.30.Final + 0.4.1-SNAPSHOT + + + + + org.apache.httpcomponents + httpclient + + + javax.servlet + javax.servlet-api + + + org.springframework + spring-aspects + + org.springframework.boot spring-boot-starter-security - + org.springframework.boot spring-boot-starter-actuator - - com.jayway.jsonpath - json-path - - - org.hibernate - hibernate-core - - - org.springframework - spring-web - - - org.springframework - spring-webmvc - - - org.onap.aai.schema-service - aai-schema - 1.0.0-SNAPSHOT - - - org.modelmapper - modelmapper - 1.1.0 - - - com.google.guava - guava - - - org.apache.commons - commons-lang3 - - - org.apache.cxf - cxf-rt-rs-client - ${cxf.version} - test - - - com.shazam - shazamcrest - 0.11 - test - - - com.google.guava - guava - - - org.apache.commons - commons-lang3 - - - - - org.slf4j - slf4j-ext - - - org.slf4j - slf4j-api - - - org.springframework.boot - spring-boot-configuration-processor - true - - - net.jodah - failsafe - 1.1.0 - + + com.jayway.jsonpath + json-path + + + org.hibernate + hibernate-core + + + org.springframework + spring-web + + + org.springframework + spring-webmvc + + + org.onap.aai.schema-service + aai-schema + 1.0.0-SNAPSHOT + + + org.modelmapper + modelmapper + 1.1.0 + + + com.google.guava + guava + + + org.apache.commons + commons-lang3 + + + org.apache.cxf + cxf-rt-rs-client + ${cxf.version} + test + + + com.shazam + shazamcrest + 0.11 + test + + + com.google.guava + guava + + + org.apache.commons + commons-lang3 + + + + + org.slf4j + slf4j-ext + + + org.slf4j + slf4j-api + + + org.springframework.boot + spring-boot-configuration-processor + true + + + net.jodah + failsafe + 1.1.0 + org.springframework.security spring-security-web - - org.onap.logging-analytics - logging-slf4j - 1.2.2 - - - org.mockito - mockito-core - - - org.json - json - - - org.springframework.boot - spring-boot-starter-test - test - - - org.reflections - reflections - 0.9.11 - + + org.onap.logging-analytics + logging-slf4j + 1.2.2 + + + org.mockito + mockito-core + + + org.json + json + + + org.springframework.boot + spring-boot-starter-test + test + + + org.reflections + reflections + 0.9.11 + + + + + org.onap.ccsdk.apps.components + proto-definition + ${ccsdk.version} + + + + + com.google.protobuf + protobuf-java + ${protobuf.version} + + + + + io.grpc + grpc-protobuf + ${grpc.version} + + + com.google.code.findbugs + jsr305 + + + + + io.grpc + grpc-stub + ${grpc.version} + + + io.grpc + grpc-netty + ${grpc.version} + + + io.grpc + grpc-testing + ${grpc.version} + test + + - - - - src/main/resources - true - - - src/main/java - - **/*.java - - - - - - org.apache.maven.plugins - maven-surefire-plugin - - - default-test - - test - - - - **/NonSpringSuite.java - - - - - spring-tests - - test - - - - **/SpringSuite.java - - - - - - - + + + + src/main/resources + true + + + src/main/java + + **/*.java + + + + + + org.apache.maven.plugins + maven-surefire-plugin + + + default-test + + test + + + + **/NonSpringSuite.java + + + + + spring-tests + + test + + + + **/SpringSuite.java + + + + + + + diff --git a/common/src/main/java/org/onap/so/client/cds/CDSProcessingClient.java b/common/src/main/java/org/onap/so/client/cds/CDSProcessingClient.java new file mode 100644 index 0000000000..0901cf589b --- /dev/null +++ b/common/src/main/java/org/onap/so/client/cds/CDSProcessingClient.java @@ -0,0 +1,112 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + +import io.grpc.ManagedChannel; +import io.grpc.internal.DnsNameResolverProvider; +import io.grpc.internal.PickFirstLoadBalancerProvider; +import io.grpc.netty.NettyChannelBuilder; +import java.util.concurrent.CountDownLatch; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceInput; +import org.onap.so.client.PreconditionFailedException; +import org.onap.so.client.RestPropertiesLoader; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + *

+ * The CDS processing client is using gRPC for communication between SO and CDS. + * That communication is configured to use a streaming approach, meaning that + * client can send an event to which server can reply will multiple sub-responses, + * until full completion of the processing. + *

+ *

+ * In order for the caller to manage the callback, it is the responsibility of the + * caller to implement and provide a {@link CDSProcessingListener} so received messages + * can be handled appropriately. + *

+ * + * Here is an example of implementation of such listener: + * 
+ * new CDSProcessingListener {
+ *
+ *     @Override
+ *     public void onMessage(ExecutionServiceOutput message) {
+ *         log.info("Received notification from CDS: {}", message);
+ *     }
+ *
+ *     @Override
+ *     public void onError(Throwable t) {
+ *         Status status = Status.fromThrowable(t);
+ *         log.error("Failed processing blueprint {}", status, t);
+ *     }
+ * }
+ *
+ */ +public class CDSProcessingClient implements AutoCloseable { + + private static final Logger log = LoggerFactory.getLogger(CDSProcessingClient.class); + + private ManagedChannel channel; + private CDSProcessingHandler handler; + + public CDSProcessingClient(final CDSProcessingListener listener) { + CDSProperties props = RestPropertiesLoader.getInstance().getNewImpl(CDSProperties.class); + if (props == null) { + throw new PreconditionFailedException( + "No RestProperty.CDSProperties implementation found on classpath, can't create client."); + } + this.channel = NettyChannelBuilder + .forAddress(props.getHost(), props.getPort()) + .nameResolverFactory(new DnsNameResolverProvider()) + .loadBalancerFactory(new PickFirstLoadBalancerProvider()) + .usePlaintext() + .build(); + this.handler = new CDSProcessingHandler(listener); + log.info("CDSProcessingClient started"); + } + + CDSProcessingClient(final ManagedChannel channel, final CDSProcessingHandler handler) { + this.channel = channel; + this.handler = handler; + } + + /** + * Sends a request to the CDS backend micro-service. + * + * The caller will be returned a CountDownLatch that can be used + * to define how long the processing can wait. The CountDownLatch is + * initiated with just 1 count. When the client receives an #onCompleted callback, + * the counter will decrement. + * + * It is the user responsibility to close the client. + * + * @param input request to send + * @return CountDownLatch instance that can be use to #await for + * completeness of processing + */ + public CountDownLatch sendRequest(ExecutionServiceInput input) { + return handler.process(input, channel); + } + + @Override + public void close() { + if (channel != null) { + channel.shutdown(); + } + log.info("CDSProcessingClient stopped"); + } +} \ No newline at end of file diff --git a/common/src/main/java/org/onap/so/client/cds/CDSProcessingHandler.java b/common/src/main/java/org/onap/so/client/cds/CDSProcessingHandler.java new file mode 100644 index 0000000000..244b89a6f5 --- /dev/null +++ b/common/src/main/java/org/onap/so/client/cds/CDSProcessingHandler.java @@ -0,0 +1,82 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + +import io.grpc.ManagedChannel; +import io.grpc.stub.StreamObserver; +import java.util.concurrent.CountDownLatch; +import org.onap.ccsdk.apps.controllerblueprints.common.api.ActionIdentifiers; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.BluePrintProcessingServiceGrpc; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.BluePrintProcessingServiceGrpc.BluePrintProcessingServiceStub; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceInput; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceOutput; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +class CDSProcessingHandler { + + private static final Logger log = LoggerFactory.getLogger(CDSProcessingHandler.class); + + private CDSProcessingListener listener; + + CDSProcessingHandler(final CDSProcessingListener listener) { + this.listener = listener; + } + + CountDownLatch process(ExecutionServiceInput request, ManagedChannel channel) { + + ActionIdentifiers header = request.getActionIdentifiers(); + + log.info("Processing blueprint({}:{}) for action({})", header.getBlueprintVersion(), header.getBlueprintName(), + header.getBlueprintVersion()); + + final CountDownLatch finishLatch = new CountDownLatch(1); + + final BluePrintProcessingServiceStub asyncStub = BluePrintProcessingServiceGrpc.newStub(channel); + + final StreamObserver responseObserver = new StreamObserver() { + @Override + public void onNext(ExecutionServiceOutput output) { + listener.onMessage(output); + } + + @Override + public void onError(Throwable t) { + listener.onError(t); + finishLatch.countDown(); + } + + @Override + public void onCompleted() { + log.info("Completed blueprint({}:{}) for action({})", header.getBlueprintVersion(), + header.getBlueprintName(), header.getBlueprintVersion()); + finishLatch.countDown(); + } + }; + + final StreamObserver requestObserver = asyncStub.process(responseObserver); + + try { + // Send our message to CDS backend for processing + requestObserver.onNext(request); + // Mark the end of requests + requestObserver.onCompleted(); + } catch (RuntimeException e) { + requestObserver.onError(e); + } + return finishLatch; + } +} \ No newline at end of file diff --git a/common/src/main/java/org/onap/so/client/cds/CDSProcessingListener.java b/common/src/main/java/org/onap/so/client/cds/CDSProcessingListener.java new file mode 100644 index 0000000000..2eae4ef5a7 --- /dev/null +++ b/common/src/main/java/org/onap/so/client/cds/CDSProcessingListener.java @@ -0,0 +1,25 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceOutput; + +public interface CDSProcessingListener { + + void onMessage(ExecutionServiceOutput message); + + void onError(Throwable t); +} diff --git a/common/src/main/java/org/onap/so/client/cds/CDSProperties.java b/common/src/main/java/org/onap/so/client/cds/CDSProperties.java new file mode 100644 index 0000000000..bb2a54ec98 --- /dev/null +++ b/common/src/main/java/org/onap/so/client/cds/CDSProperties.java @@ -0,0 +1,25 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + +import org.onap.so.client.RestProperties; + + +public interface CDSProperties extends RestProperties { + + String getHost(); + int getPort(); +} diff --git a/common/src/test/java/org/onap/so/client/cds/CDSProcessingClientTest.java b/common/src/test/java/org/onap/so/client/cds/CDSProcessingClientTest.java new file mode 100644 index 0000000000..2bfa754f0e --- /dev/null +++ b/common/src/test/java/org/onap/so/client/cds/CDSProcessingClientTest.java @@ -0,0 +1,162 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + + +import static org.junit.Assert.*; +import static org.mockito.Mockito.*; + +import io.grpc.inprocess.InProcessChannelBuilder; +import io.grpc.inprocess.InProcessServerBuilder; +import io.grpc.stub.StreamObserver; +import io.grpc.testing.GrpcCleanupRule; +import io.grpc.util.MutableHandlerRegistry; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicReference; +import org.junit.After; +import org.junit.Before; +import org.junit.Rule; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.JUnit4; +import org.mockito.Mock; +import org.onap.ccsdk.apps.controllerblueprints.common.api.ActionIdentifiers; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.BluePrintProcessingServiceGrpc.BluePrintProcessingServiceImplBase; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceInput; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceOutput; + +@RunWith(JUnit4.class) +public class CDSProcessingClientTest { + + @Rule + public final GrpcCleanupRule grpcCleanup = new GrpcCleanupRule(); + + @Mock + private CDSProcessingListener listener = spy(new TestCDSProcessingListener()); + + private CDSProcessingHandler handler; + private CDSProcessingClient client; + + + private final MutableHandlerRegistry serviceRegistry = new MutableHandlerRegistry(); + private final List messagesDelivered = new ArrayList<>(); + private final CountDownLatch allRequestsDelivered = new CountDownLatch(1); + private final AtomicReference> responseObserverRef = new AtomicReference<>(); + + @Before + public void setUp() throws Exception { + String serverName = InProcessServerBuilder.generateName(); + grpcCleanup.register(InProcessServerBuilder.forName(serverName) + .fallbackHandlerRegistry(serviceRegistry).directExecutor().build().start()); + + handler = new CDSProcessingHandler(listener); + + client = + new CDSProcessingClient(InProcessChannelBuilder.forName(serverName).directExecutor().build(), handler); + + final BluePrintProcessingServiceImplBase routeChatImpl = + new BluePrintProcessingServiceImplBase() { + @Override + public StreamObserver process( + StreamObserver responseObserver) { + + responseObserverRef.set(responseObserver); + + StreamObserver requestObserver = new StreamObserver() { + @Override + public void onNext(ExecutionServiceInput message) { + messagesDelivered.add(message.getActionIdentifiers().getActionName()); + } + + @Override + public void onError(Throwable t) { + + } + + @Override + public void onCompleted() { + allRequestsDelivered.countDown(); + } + }; + + return requestObserver; + } + }; + + serviceRegistry.addService(routeChatImpl); + } + + @After + public void tearDown() { + client.close(); + } + + @Test + public void testClientCst() { + new CDSProcessingClient(listener); + } + + + @Test + public void testSendMessageFail() throws Exception { + + ExecutionServiceInput fakeRequest1 = ExecutionServiceInput.newBuilder().setActionIdentifiers( + ActionIdentifiers.newBuilder().setActionName("request1").build()).build(); + + CountDownLatch finishLatch = client.sendRequest(fakeRequest1); + + responseObserverRef.get().onError(new Throwable("fail test")); + verify(listener).onError(any(Throwable.class)); + + assertTrue(finishLatch.await(1, TimeUnit.SECONDS)); + } + + @Test + public void testSendMessage() throws Exception { + + ExecutionServiceInput fakeRequest1 = ExecutionServiceInput.newBuilder().setActionIdentifiers( + ActionIdentifiers.newBuilder().setActionName("request1").build()).build(); + + ExecutionServiceOutput fakeResponse1 = ExecutionServiceOutput.newBuilder().setActionIdentifiers( + ActionIdentifiers.newBuilder().setActionName("response1").build()).build(); + + ExecutionServiceOutput fakeResponse2 = ExecutionServiceOutput.newBuilder().setActionIdentifiers( + ActionIdentifiers.newBuilder().setActionName("response2").build()).build(); + + CountDownLatch finishLatch = client.sendRequest(fakeRequest1); + + // request message sent and delivered for one time + assertTrue(allRequestsDelivered.await(1, TimeUnit.SECONDS)); + assertEquals(Collections.singletonList("request1"), messagesDelivered); + + // Let the server send out two simple response messages + // and verify that the client receives them. + responseObserverRef.get().onNext(fakeResponse1); + verify(listener).onMessage(fakeResponse1); + responseObserverRef.get().onNext(fakeResponse2); + verify(listener).onMessage(fakeResponse2); + + // let server complete. + responseObserverRef.get().onCompleted(); + + assertTrue(finishLatch.await(1, TimeUnit.SECONDS)); + } + +} \ No newline at end of file diff --git a/common/src/test/java/org/onap/so/client/cds/TestCDSProcessingListener.java b/common/src/test/java/org/onap/so/client/cds/TestCDSProcessingListener.java new file mode 100644 index 0000000000..df302f6e35 --- /dev/null +++ b/common/src/test/java/org/onap/so/client/cds/TestCDSProcessingListener.java @@ -0,0 +1,37 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + +import io.grpc.Status; +import org.onap.ccsdk.apps.controllerblueprints.processing.api.ExecutionServiceOutput; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class TestCDSProcessingListener implements CDSProcessingListener { + + private static final Logger log = LoggerFactory.getLogger(TestCDSProcessingListener.class); + + @Override + public void onMessage(ExecutionServiceOutput message) { + log.info("Received notification from CDS: {}", message); + } + + @Override + public void onError(Throwable t) { + Status status = Status.fromThrowable(t); + log.error("Failed processing blueprint {}", status, t); + } +} diff --git a/common/src/test/java/org/onap/so/client/cds/TestCDSPropertiesImpl.java b/common/src/test/java/org/onap/so/client/cds/TestCDSPropertiesImpl.java new file mode 100644 index 0000000000..efb9b07871 --- /dev/null +++ b/common/src/test/java/org/onap/so/client/cds/TestCDSPropertiesImpl.java @@ -0,0 +1,61 @@ +/* + * Copyright (C) 2019 Bell Canada. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.onap.so.client.cds; + +import java.net.MalformedURLException; +import java.net.URL; + +public class TestCDSPropertiesImpl implements CDSProperties { + + public TestCDSPropertiesImpl() { + // Needed for service loader + } + + @Override + public String getHost() { + return "endpoint"; + } + + @Override + public int getPort() { + return 9999; + } + + @Override + public URL getEndpoint() { + return null; + } + + @Override + public String getSystemName() { + return "MSO"; + } + + @Override + public Integer getRetries() { + return null; + } + + @Override + public Long getDelayBetweenRetries() { + return null; + } + + @Override + public boolean mapNotFoundToEmpty() { + return false; + } +} diff --git a/common/src/test/resources/META-INF/services/org.onap.so.client.RestProperties b/common/src/test/resources/META-INF/services/org.onap.so.client.RestProperties new file mode 100644 index 0000000000..6a5105d6b4 --- /dev/null +++ b/common/src/test/resources/META-INF/services/org.onap.so.client.RestProperties @@ -0,0 +1 @@ +org.onap.so.client.cds.TestCDSPropertiesImpl \ No newline at end of file -- cgit 1.2.3-korg