From 7fcc895e05176b786cd6dcfaf8aba8190c53e1e7 Mon Sep 17 00:00:00 2001 From: Michal Korman Date: Thu, 24 May 2018 12:47:40 +0200 Subject: Replace printStackTrace with usage of logger Change-Id: I648e5a25337beca1f8c483ba6e5359d245e237d3 Issue-ID: SO-642 Signed-off-by: mkorman --- .../openecomp/mso/bpmn/common/recipe/ResourceInput.java | 3 +-- .../mso/bpmn/common/recipe/ResourceRecipeRequest.java | 3 +-- .../mso/bpmn/common/resource/ResourceRequestBuilder.java | 6 ++---- .../camunda/bpmn/plugin/urnmap/resources/URNResource.java | 14 +++++--------- 4 files changed, 9 insertions(+), 17 deletions(-) (limited to 'bpmn') diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceInput.java b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceInput.java index 13b1666991..42547faa1e 100644 --- a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceInput.java +++ b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceInput.java @@ -288,8 +288,7 @@ public class ResourceInput { try { jsonStr = mapper.writeValueAsString(this); } catch(JsonProcessingException e) { - msoLogger.debug("JsonProcessingException", e); - e.printStackTrace(); + msoLogger.error("JsonProcessingException", e); } return jsonStr; } diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceRecipeRequest.java b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceRecipeRequest.java index ec60619dc6..3ec43e10ae 100644 --- a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceRecipeRequest.java +++ b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/recipe/ResourceRecipeRequest.java @@ -151,8 +151,7 @@ public class ResourceRecipeRequest { try { jsonStr = mapper.writeValueAsString(this); } catch(JsonProcessingException e) { - msoLogger.debug("JsonProcessingException", e); - e.printStackTrace(); + msoLogger.error("JsonProcessingException", e); } return jsonStr; } diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java index e6b1b2143f..d1ec60a1cd 100644 --- a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java +++ b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/resource/ResourceRequestBuilder.java @@ -113,8 +113,7 @@ public class ResourceRequestBuilder { Map resourceInputsFromServiceDeclaredLevel = buildResouceRequest(serviceUuid, resourceCustomizationUuid, serviceInput); resourceInputsFromUuiMap.putAll(resourceInputsFromServiceDeclaredLevel); } catch(SdcToscaParserException e) { - LOGGER.debug("SdcToscaParserException", e); - e.printStackTrace(); + LOGGER.error("SdcToscaParserException", e); } String resourceInputsStr = getJsonString(resourceInputsFromUuiMap); String result = "{\n" @@ -221,8 +220,7 @@ public class ResourceRequestBuilder { try { jsonStr = mapper.writeValueAsString(srcObj); } catch(JsonProcessingException e) { - LOGGER.debug("SdcToscaParserException", e); - e.printStackTrace(); + LOGGER.error("SdcToscaParserException", e); } return jsonStr; } diff --git a/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/URNResource.java b/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/URNResource.java index 85f9753634..5fc80ab5c4 100644 --- a/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/URNResource.java +++ b/bpmn/MSOURN-plugin/src/main/java/org/openecomp/camunda/bpmn/plugin/urnmap/resources/URNResource.java @@ -82,8 +82,7 @@ public class URNResource extends AbstractCockpitPluginResource{ } catch (Exception e) { - - e.printStackTrace(); + msoLogger.error("Exception while executing query", e); } finally { try { r.close(); } catch (Exception e) { /* ignored */ } try { psData.close(); } catch (Exception e) { /* ignored */ } @@ -131,9 +130,8 @@ public class URNResource extends AbstractCockpitPluginResource{ } } catch (Exception e) - { - - e.printStackTrace(); + { + msoLogger.error("Exception while performing JNDI lookup", e); } return conn; @@ -175,8 +173,7 @@ public class URNResource extends AbstractCockpitPluginResource{ } catch (Exception e) { - - e.printStackTrace(); + msoLogger.error("Exception while executing query", e); } finally { try { psData.close(); } catch (Exception e) { /* ignored */ } try { conn.close(); } catch (Exception e) { /* ignored */ } @@ -199,8 +196,7 @@ public class URNResource extends AbstractCockpitPluginResource{ } catch (Exception e) { - - e.printStackTrace(); + msoLogger.error("Exception while executing query", e); } finally { try { psData.close(); } catch (Exception e) { /* ignored */ } try { conn.close(); } catch (Exception e) { /* ignored */ } -- cgit 1.2.3-korg