From aeb6d78ff8534d0ded9730523e6822995df2bfa5 Mon Sep 17 00:00:00 2001
From: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Date: Fri, 13 Mar 2020 12:25:20 +0100
Subject: remove duplicated code

Issue-ID: SO-2634
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Change-Id: I75bd8d1557f78e396e1d57a03e12eefc3a771798
---
 .../infrastructure/aai/tasks/AAIUpdateTasks.java   | 60 +++++++---------------
 1 file changed, 18 insertions(+), 42 deletions(-)

(limited to 'bpmn')

diff --git a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/aai/tasks/AAIUpdateTasks.java b/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/aai/tasks/AAIUpdateTasks.java
index 33b60a9ed3..a162088cb2 100644
--- a/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/aai/tasks/AAIUpdateTasks.java
+++ b/bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/aai/tasks/AAIUpdateTasks.java
@@ -128,62 +128,23 @@ public class AAIUpdateTasks {
 
     /**
      * BPMN access method to update status of VolumeGroup to Assigned in AAI
-     *
-     * @param execution
      */
     public void updateOrchestrationStatusAssignedVolumeGroup(BuildingBlockExecution execution) {
-        try {
-            GeneralBuildingBlock gBBInput = execution.getGeneralBuildingBlock();
-
-            VolumeGroup volumeGroup = extractPojosForBB.extractByKey(execution, ResourceKey.VOLUME_GROUP_ID);
-            CloudRegion cloudRegion = gBBInput.getCloudRegion();
-            volumeGroup.setHeatStackId("");
-            aaiVolumeGroupResources.updateOrchestrationStatusVolumeGroup(volumeGroup, cloudRegion,
-                    OrchestrationStatus.ASSIGNED);
-        } catch (Exception ex) {
-            logger.error("Exception occurred in AAIUpdateTasks updateOrchestrationStatusAssignedVolumeGroup", ex);
-            exceptionUtil.buildAndThrowWorkflowException(execution, 7000, ex);
-        }
+        updateOrchestrationStatusForVolumeGroup(execution, OrchestrationStatus.ASSIGNED);
     }
 
     /**
      * BPMN access method to update status of VolumeGroup to Active in AAI
-     *
-     * @param execution
      */
     public void updateOrchestrationStatusActiveVolumeGroup(BuildingBlockExecution execution) {
-        try {
-            GeneralBuildingBlock gBBInput = execution.getGeneralBuildingBlock();
-
-            VolumeGroup volumeGroup = extractPojosForBB.extractByKey(execution, ResourceKey.VOLUME_GROUP_ID);
-            CloudRegion cloudRegion = gBBInput.getCloudRegion();
-
-            aaiVolumeGroupResources.updateOrchestrationStatusVolumeGroup(volumeGroup, cloudRegion,
-                    OrchestrationStatus.ACTIVE);
-        } catch (Exception ex) {
-            logger.error("Exception occurred in AAIUpdateTasks updateOrchestrationStatusActiveVolumeGroup", ex);
-            exceptionUtil.buildAndThrowWorkflowException(execution, 7000, ex);
-        }
+        updateOrchestrationStatusForVolumeGroup(execution, OrchestrationStatus.ACTIVE);
     }
 
     /**
      * BPMN access method to update status of VolumeGroup to Created in AAI
-     *
-     * @param execution
      */
     public void updateOrchestrationStatusCreatedVolumeGroup(BuildingBlockExecution execution) {
-        try {
-            GeneralBuildingBlock gBBInput = execution.getGeneralBuildingBlock();
-
-            VolumeGroup volumeGroup = extractPojosForBB.extractByKey(execution, ResourceKey.VOLUME_GROUP_ID);
-            CloudRegion cloudRegion = gBBInput.getCloudRegion();
-
-            aaiVolumeGroupResources.updateOrchestrationStatusVolumeGroup(volumeGroup, cloudRegion,
-                    OrchestrationStatus.CREATED);
-        } catch (Exception ex) {
-            logger.error("Exception occurred in AAIUpdateTasks updateOrchestrationStatusCreatedVolumeGroup", ex);
-            exceptionUtil.buildAndThrowWorkflowException(execution, 7000, ex);
-        }
+        updateOrchestrationStatusForVolumeGroup(execution, OrchestrationStatus.CREATED);
     }
 
     /**
@@ -824,4 +785,19 @@ public class AAIUpdateTasks {
         }
     }
 
+    private void updateOrchestrationStatusForVolumeGroup(BuildingBlockExecution execution, OrchestrationStatus status) {
+        try {
+            VolumeGroup volumeGroup = extractPojosForBB.extractByKey(execution, ResourceKey.VOLUME_GROUP_ID);
+            if (status.equals(OrchestrationStatus.ASSIGNED)) {
+                volumeGroup.setHeatStackId("");
+            }
+            aaiVolumeGroupResources.updateOrchestrationStatusVolumeGroup(volumeGroup,
+                    execution.getGeneralBuildingBlock().getCloudRegion(), status);
+        } catch (Exception ex) {
+            logger.error("Exception occurred in AAIUpdateTasks during update orchestration status to {} for "
+                    + "volume group", status, ex);
+            exceptionUtil.buildAndThrowWorkflowException(execution, 7000, ex);
+        }
+    }
+
 }
-- 
cgit 1.2.3-korg