From 7476b99cbff0989b1187364dff65ef37bb57510e Mon Sep 17 00:00:00 2001 From: "Benjamin, Max (mb388a)" Date: Tue, 9 Apr 2019 14:17:51 -0400 Subject: Re-commit some changes which were lost remove unused code Issue-ID: SO-1767 Change-Id: I12b8295ae4a5bc9e9154c8ccd1bb53f70886f929 Signed-off-by: Benjamin, Max (mb388a) --- .../so/bpmn/core/domain/ServiceDecomposition.java | 9 -- .../subprocess/BuildingBlock/AssignVnfBB.bpmn | 95 +++++++++++----------- .../bpmn/subprocess/AssignVnfBBTest.java | 5 +- .../sdnc/tasks/SDNCUnassignTasksTest.java | 6 -- 4 files changed, 49 insertions(+), 66 deletions(-) (limited to 'bpmn') diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/onap/so/bpmn/core/domain/ServiceDecomposition.java b/bpmn/MSOCoreBPMN/src/main/java/org/onap/so/bpmn/core/domain/ServiceDecomposition.java index 0e03989e64..419f545cdf 100644 --- a/bpmn/MSOCoreBPMN/src/main/java/org/onap/so/bpmn/core/domain/ServiceDecomposition.java +++ b/bpmn/MSOCoreBPMN/src/main/java/org/onap/so/bpmn/core/domain/ServiceDecomposition.java @@ -54,7 +54,6 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable { private String serviceRole; private ServiceInstance serviceInstance; private Request request; - private Customer customer; private String callbackURN; private String sdncVersion; @JsonProperty("project") @@ -217,14 +216,6 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable { this.request = request; } - public Customer getCustomer() { - return customer; - } - - public void setCustomer(Customer customer) { - this.customer = customer; - } - public String getCallbackURN() { return callbackURN; } diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/AssignVnfBB.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/AssignVnfBB.bpmn index ce4d2e1dab..ea762c8719 100644 --- a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/AssignVnfBB.bpmn +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/AssignVnfBB.bpmn @@ -1,13 +1,9 @@ - + SequenceFlow_0zaz9o2 - - SequenceFlow_1samncw - SequenceFlow_1qkhm79 - SequenceFlow_0csh9dc @@ -18,7 +14,7 @@ - SequenceFlow_1vw20wu + SequenceFlow_0yzidhu SequenceFlow_0csh9dc @@ -62,6 +58,7 @@ + SequenceFlow_1nle8kc SequenceFlow_11jum90 @@ -70,7 +67,7 @@ SequenceFlow_11jum90 SequenceFlow_0v8d14a - SequenceFlow_1samncw + SequenceFlow_14mpqit SequenceFlow_0qj7zcn @@ -83,19 +80,22 @@ - + + SequenceFlow_14mpqit + SequenceFlow_1991eue + + - SequenceFlow_1qkhm79 - SequenceFlow_1vw20wu + SequenceFlow_1991eue + SequenceFlow_0yzidhu - - - + + @@ -106,13 +106,10 @@ - - - - + - + @@ -126,14 +123,14 @@ - - + + - + - + @@ -194,25 +191,32 @@ - + - + - + - + - + - - + + + + + + + + + - + @@ -254,31 +258,26 @@ - - + + - - - - - - - - - - + + + + + + - + - - - + + + - + - diff --git a/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/AssignVnfBBTest.java b/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/AssignVnfBBTest.java index 078b0ae4e2..9943e39ef6 100644 --- a/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/AssignVnfBBTest.java +++ b/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/AssignVnfBBTest.java @@ -39,9 +39,8 @@ public class AssignVnfBBTest extends BaseBPMNTest { assertThat(pi).isNotNull(); assertThat(pi).isStarted().hasPassedInOrder("Start_AssignVnfBB", "Task_CreateVnf", "ServiceTask_ConnectVnfToCloudRegion", "ServiceTask_ConnectVnfToTenant", "Task_createPlatform", - "Task_createLineOfBusiness", "Task_createInstanceGroups", "Task_callHoming", - "Task_SDNCAdapterVnfTopologyAssign", "CallActivity_sdncAssign", - "Task_UpdateVnfOrchestrationStatusAssigned", "End_AssignVnfBB"); + "Task_createLineOfBusiness", "Task_createInstanceGroups", "Task_callHoming", "Task_SDNCCreateRequest", + "CallActivity_SDNCAssignVnf", "Task_UpdateVnfOrchestrationStatusAssigned", "End_AssignVnfBB"); assertThat(pi).isEnded(); } diff --git a/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/sdnc/tasks/SDNCUnassignTasksTest.java b/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/sdnc/tasks/SDNCUnassignTasksTest.java index c6ed1cca7a..968723c628 100644 --- a/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/sdnc/tasks/SDNCUnassignTasksTest.java +++ b/bpmn/so-bpmn-tasks/src/test/java/org/onap/so/bpmn/infrastructure/sdnc/tasks/SDNCUnassignTasksTest.java @@ -22,7 +22,6 @@ package org.onap.so.bpmn.infrastructure.sdnc.tasks; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotEquals; -import static org.junit.Assert.assertNull; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.doReturn; @@ -95,8 +94,6 @@ public class SDNCUnassignTasksTest extends BaseTaskTest { assertEquals(SDNCTopology.SERVICE, sdncRequest.getTopology()); } - - @Test public void unassignServiceInstanceExceptionTest() throws Exception { expectedException.expect(BpmnError.class); @@ -115,8 +112,6 @@ public class SDNCUnassignTasksTest extends BaseTaskTest { assertEquals(SDNCTopology.VFMODULE, sdncRequest.getTopology()); } - - @Test public void unassignVfModuleExceptionTest() throws Exception { expectedException.expect(BpmnError.class); @@ -136,7 +131,6 @@ public class SDNCUnassignTasksTest extends BaseTaskTest { assertEquals(SDNCTopology.VNF, sdncRequest.getTopology()); } - @Test public void unassignVnfExceptionTest() throws Exception { expectedException.expect(BpmnError.class); -- cgit 1.2.3-korg