From 510eb0a7acd4ecc59820761177d8d1834aa1980a Mon Sep 17 00:00:00 2001 From: Lukasz Muszkieta Date: Wed, 10 Oct 2018 16:08:53 +0200 Subject: remove unused code UUID parameter in AAIRestClientI interface is redundant - part 1 Issue-ID: SO-729 Change-Id: I7db331098911e6e183d921175f3109f62b7aedbd Signed-off-by: Lukasz Muszkieta --- .../org/onap/so/bpmn/infrastructure/pnf/aai/AaiConnectionImpl.java | 6 ++---- .../bpmn/infrastructure/pnf/delegate/CancelDmaapSubscription.java | 2 +- .../onap/so/bpmn/infrastructure/pnf/delegate/PnfCheckInputs.java | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) (limited to 'bpmn') diff --git a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/aai/AaiConnectionImpl.java b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/aai/AaiConnectionImpl.java index fa40e860c5..a92fad2e5f 100644 --- a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/aai/AaiConnectionImpl.java +++ b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/aai/AaiConnectionImpl.java @@ -20,10 +20,8 @@ package org.onap.so.bpmn.infrastructure.pnf.aai; -import java.io.IOException; import java.util.Optional; import java.util.UUID; - import org.onap.aai.domain.yang.Pnf; import org.onap.so.bpmn.infrastructure.pnf.implementation.AaiConnection; import org.onap.so.client.aai.AAIRestClientImpl; @@ -31,13 +29,13 @@ import org.onap.so.client.aai.AAIRestClientImpl; public class AaiConnectionImpl implements AaiConnection { @Override - public Optional getEntryFor(String correlationId) throws IOException { + public Optional getEntryFor(String correlationId) { AAIRestClientImpl restClient = new AAIRestClientImpl(); return restClient.getPnfByName(correlationId, UUID.randomUUID().toString()); } @Override - public void createEntry(String correlationId, Pnf entry) throws IOException { + public void createEntry(String correlationId, Pnf entry) { AAIRestClientImpl restClient = new AAIRestClientImpl(); restClient.createPnf(correlationId, UUID.randomUUID().toString(), entry); } diff --git a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/CancelDmaapSubscription.java b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/CancelDmaapSubscription.java index 85cbe2b024..a10267e666 100644 --- a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/CancelDmaapSubscription.java +++ b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/CancelDmaapSubscription.java @@ -30,7 +30,7 @@ public class CancelDmaapSubscription implements JavaDelegate { private DmaapClient dmaapClient; @Override - public void execute(DelegateExecution execution) throws Exception { + public void execute(DelegateExecution execution) { String correlationId = (String) execution.getVariable(ExecutionVariableNames.CORRELATION_ID); dmaapClient.unregister(correlationId); } diff --git a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/PnfCheckInputs.java b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/PnfCheckInputs.java index e4866f5334..d210e5e64f 100644 --- a/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/PnfCheckInputs.java +++ b/bpmn/so-bpmn-infrastructure-common/src/main/java/org/onap/so/bpmn/infrastructure/pnf/delegate/PnfCheckInputs.java @@ -35,7 +35,7 @@ public class PnfCheckInputs implements JavaDelegate { private String defaultTimeout; @Override - public void execute(DelegateExecution execution) throws Exception { + public void execute(DelegateExecution execution) { String correlationId = (String) execution.getVariable(CORRELATION_ID); if (correlationId == null) { new ExceptionUtil().buildAndThrowWorkflowException(execution, 9999, "correlationId variable not defined"); -- cgit 1.2.3-korg