From 40bb7adfbbe26be4e459e269bfd277436deb21cf Mon Sep 17 00:00:00 2001
From: Munir Ahmad <munir.ahmad@bell.ca>
Date: Sat, 24 Feb 2018 13:12:56 -0500
Subject: Make use of append instead of string concatenation

Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
---
 .../java/org/openecomp/mso/bpmn/common/adapter/vnf/MsoRequest.java    | 4 ++--
 .../src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java | 3 ++-
 .../src/main/java/org/openecomp/mso/bpmn/core/xml/XmlTool.java        | 4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)

(limited to 'bpmn')

diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/adapter/vnf/MsoRequest.java b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/adapter/vnf/MsoRequest.java
index c3912b48bc..8a9cb955b0 100644
--- a/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/adapter/vnf/MsoRequest.java
+++ b/bpmn/MSOCommonBPMN/src/main/java/org/openecomp/mso/bpmn/common/adapter/vnf/MsoRequest.java
@@ -106,9 +106,9 @@ public class MsoRequest {
     @Override
     public String toString() {
         StringBuilder request = new StringBuilder();
-        request.append("<requestId>"+requestId+"</requestId>");
+        request.append("<requestId>").append(requestId).append("</requestId>");
         request.append('\n');
-        request.append("<serviceInstanceId>"+serviceInstanceId+"</serviceInstanceId>");
+        request.append("<serviceInstanceId>").append(serviceInstanceId).append("</serviceInstanceId>");
         return request.toString();
     }
 
diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java
index 584ccda1ac..9c79df85ff 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/HealthCheckHandler.java
@@ -240,7 +240,8 @@ public class HealthCheckHandler  {
         //now create a soap request message as follows:
         final StringBuilder payload = new StringBuilder();
         payload.append("\n");
-        payload.append("<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:req=\"" + adapterNamespace + "/requestsdb\">\n");
+        payload.append("<soapenv:Envelope xmlns:soapenv=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:req=\"")
+            .append(adapterNamespace).append("/requestsdb\">\n");
         payload.append("<soapenv:Header/>\n");
         payload.append("<soapenv:Body>\n");
         payload.append("<req:getSiteStatus>\n");
diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/xml/XmlTool.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/xml/XmlTool.java
index fbfe226a30..f5b9f8dc56 100644
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/xml/XmlTool.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/xml/XmlTool.java
@@ -155,7 +155,7 @@ public final class XmlTool {
 				out.append("&amp;");
 				modified = true;
 			} else if (c < 32 || c > 126) {
-				out.append("&#" + (int)c + ";");
+				out.append("&#").append((int) c).append(";");
 				modified = true;
 			} else {
 				out.append(c);
@@ -199,7 +199,7 @@ public final class XmlTool {
 				out.append("&amp;");
 				modified = true;
 			} else if (c < 32 || c > 126) {
-				out.append("&#" + (int)c + ";");
+				out.append("&#").append((int) c).append(";");
 				modified = true;
 			} else {
 				out.append(c);
-- 
cgit 1.2.3-korg