From fa9a707c87654330dfb5788a6029b8199c6cdf17 Mon Sep 17 00:00:00 2001 From: "Boslet, Cory" Date: Thu, 16 Apr 2020 10:43:38 -0400 Subject: move network adapter to an external client task Began impelenting new network external task. Made the vnfAdapterTask subflow an openstack subflow, refactored infra flows and BB to call it for network functions. Fixed bugs discovered through a robot dry run, added unit test, added support for rollback network request Updated junit test files for comparison due to not polling for response Removed the no longer used network adapter rest task from bpmn tasks Removed the unused network adapter async and its beans Removed network async client package from open pojo scan Issue-ID: SO-2813 Signed-off-by: Benjamin, Max (mb388a) Change-Id: I4c25892012cc86659ab122448ed1aca5cab91671 --- .../subprocess/BuildingBlock/CreateNetworkBB.bpmn | 102 ++++++++++----------- .../subprocess/BuildingBlock/CreateVfModuleBB.bpmn | 94 +++++++++---------- .../subprocess/BuildingBlock/DeleteNetworkBB.bpmn | 22 ++--- .../subprocess/BuildingBlock/NetworkAdapter.bpmn | 69 ++++++++++++++ .../subprocess/BuildingBlock/UpdateNetworkBB.bpmn | 59 ++++++------ .../subprocess/BuildingBlock/VnfAdapter.bpmn | 36 ++++---- .../bpmn/subprocess/VnfAdapterTest.java | 6 +- 7 files changed, 229 insertions(+), 159 deletions(-) create mode 100644 bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/NetworkAdapter.bpmn (limited to 'bpmn/so-bpmn-building-blocks') diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateNetworkBB.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateNetworkBB.bpmn index 1ea311549c..12b038e738 100644 --- a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateNetworkBB.bpmn +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateNetworkBB.bpmn @@ -1,5 +1,5 @@ - + SequenceFlow_1maepy7 @@ -11,7 +11,7 @@ SequenceFlow_1oc7wcr SequenceFlow_0n42zi5 - + SequenceFlow_1eqfh23 SequenceFlow_1fm99t6 @@ -31,19 +31,19 @@ - + SequenceFlow_03ebe6c - + SequenceFlow_1oc7wcr - + SequenceFlow_1eqfh23 - + SequenceFlow_0y0w60u @@ -55,12 +55,12 @@ SequenceFlow_03ebe6c - + - + SequenceFlow_1fm99t6 SequenceFlow_0qpu80i @@ -83,148 +83,148 @@ - + - + - + - + - + - + - + - - + + - - + + - - + + - - + + - + - + - + - + - + - + - + - + - - + + - - + + - - + + - + - - + + - + - + - - + + - - + + - - + + - + - - + + diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateVfModuleBB.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateVfModuleBB.bpmn index 97fad57e7d..d77e141364 100644 --- a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateVfModuleBB.bpmn +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/CreateVfModuleBB.bpmn @@ -1,5 +1,5 @@ - + SequenceFlow_1xr6chl @@ -12,7 +12,7 @@ SequenceFlow_1vbwdaw - + SequenceFlow_15hn8si SequenceFlow_16g4dz0 @@ -83,148 +83,148 @@ - + - + - - + + - + - + - - + + - - + + - + - - + + - - - - - - + + + + + + - + - + - + - + - + - + - - + + - - + + - - - - + + + + - + - - + + - + - - + + - + - - + + - + - - + + diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/DeleteNetworkBB.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/DeleteNetworkBB.bpmn index 7a05163b0f..37459cdc7e 100644 --- a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/DeleteNetworkBB.bpmn +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/DeleteNetworkBB.bpmn @@ -1,5 +1,5 @@ - + SequenceFlow_1mc3d3f @@ -17,12 +17,12 @@ SequenceFlow_0nhd7b7 - + - + SequenceFlow_16ti327 SequenceFlow_0gnafn2 @@ -52,8 +52,8 @@ - - + + @@ -68,8 +68,8 @@ - - + + @@ -78,15 +78,15 @@ - - + + - - + + diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/NetworkAdapter.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/NetworkAdapter.bpmn new file mode 100644 index 0000000000..fe071a25ba --- /dev/null +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/NetworkAdapter.bpmn @@ -0,0 +1,69 @@ + + + + + Flow_1te2q0o + + + + + + Flow_0dcm3bq + + + + Flow_1te2q0o + Flow_16y1hyp + + + Flow_03mucze + Flow_0dcm3bq + + + + + + + + + + Flow_16y1hyp + Flow_03mucze + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/UpdateNetworkBB.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/UpdateNetworkBB.bpmn index 1235469b42..f4ffa18267 100644 --- a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/UpdateNetworkBB.bpmn +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/UpdateNetworkBB.bpmn @@ -1,5 +1,5 @@ - + SequenceFlow_074w2et @@ -48,11 +48,12 @@ SequenceFlow_06ei0em - + + SequenceFlow_07hq1eg SequenceFlow_183ph5i @@ -61,7 +62,7 @@ SequenceFlow_183ph5i SequenceFlow_001ursg - + SequenceFlow_0qrtpcy SequenceFlow_07hq1eg @@ -98,8 +99,8 @@ - - + + @@ -117,8 +118,8 @@ - - + + @@ -130,15 +131,15 @@ - - + + - - + + @@ -153,8 +154,8 @@ - - + + @@ -184,38 +185,38 @@ - - - - + + + + - - + + - - + + - - + + - - + + @@ -224,15 +225,15 @@ - - + + - - + + diff --git a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/VnfAdapter.bpmn b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/VnfAdapter.bpmn index e139e94660..3448e8d577 100644 --- a/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/VnfAdapter.bpmn +++ b/bpmn/so-bpmn-building-blocks/src/main/resources/subprocess/BuildingBlock/VnfAdapter.bpmn @@ -1,5 +1,5 @@ - + SequenceFlow_1xr6chl @@ -27,10 +27,10 @@ SequenceFlow_1ivhukd - + - + @@ -38,8 +38,8 @@ SequenceFlow_0qaaf5k SequenceFlow_0j1zvis - - + + @@ -53,8 +53,8 @@ - - + + @@ -72,10 +72,10 @@ - - - - + + + + @@ -93,25 +93,25 @@ - - + + - + - - + + - - + + diff --git a/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/VnfAdapterTest.java b/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/VnfAdapterTest.java index 4dbf4d46ff..51384c6a87 100644 --- a/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/VnfAdapterTest.java +++ b/bpmn/so-bpmn-building-blocks/src/test/java/org/onap/so/bpmn/infrastructure/bpmn/subprocess/VnfAdapterTest.java @@ -32,12 +32,12 @@ import org.onap.so.bpmn.common.BuildingBlockExecution; public class VnfAdapterTest extends BaseBPMNTest { @Test public void vnfAdapterCreatedTest() { - mockSubprocess("vnfAdapterTask", "Mocked vnfAdapterTask", "GenericStub"); + mockSubprocess("openstackAdapterTask", "Mocked openstackAdapterTask", "GenericStub"); ProcessInstance pi = runtimeService.startProcessInstanceByKey("VnfAdapter", variables); assertThat(pi).isNotNull(); - assertThat(pi).isStarted().hasPassedInOrder("VnfAdapter_Start", "PreProcessRequest", "Call_vnfAdapterTask", - "PostProcessResponse", "VnfAdapter_End"); + assertThat(pi).isStarted().hasPassedInOrder("VnfAdapter_Start", "PreProcessRequest", + "Call_openstackAdapterTask", "PostProcessResponse", "VnfAdapter_End"); assertThat(pi).isEnded(); } -- cgit 1.2.3-korg