From c4c9f922fa9ae3549f307677d307948bda22602f Mon Sep 17 00:00:00 2001
From: Mateusz Gołuchowski <mateusz.goluchowski@nokia.com>
Date: Tue, 16 Jun 2020 14:02:28 +0200
Subject: [WIP] WorkflowAction refactoring

Extracted superclass for ExecuteBuildingBlock and ConfigBuildingBlocksDataObject
Changed setters to return void instead of 'this'.
Adjusted all code which was using setters chaining

Issue-ID: SO-2634
Change-Id: I375db2004687f1f634adac31d4d1af3635f5981c
Signed-off-by: Mateusz Goluchowski <mateusz.goluchowski@nokia.com>
---
 .../entities/BuildingBlockBase.java                | 89 ++++++++++++++++++++
 .../entities/ExecuteBuildingBlock.java             | 97 ++--------------------
 2 files changed, 96 insertions(+), 90 deletions(-)
 create mode 100644 bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/BuildingBlockBase.java

(limited to 'bpmn/MSOCommonBPMN/src/main/java')

diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/BuildingBlockBase.java b/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/BuildingBlockBase.java
new file mode 100644
index 0000000000..9e320700bd
--- /dev/null
+++ b/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/BuildingBlockBase.java
@@ -0,0 +1,89 @@
+package org.onap.so.bpmn.servicedecomposition.entities;
+
+import org.onap.so.serviceinstancebeans.RequestDetails;
+
+public class BuildingBlockBase {
+
+    private Boolean aLaCarte;
+    private String apiVersion;
+    private Boolean isResume;
+    private String resourceId;
+    private String requestId;
+    private String requestAction;
+    private RequestDetails requestDetails;
+    private WorkflowResourceIds workflowResourceIds;
+    private String vnfType;
+
+    public void setaLaCarte(Boolean aLaCarte) {
+        this.aLaCarte = aLaCarte;
+    }
+
+    public void setApiVersion(String apiVersion) {
+        this.apiVersion = apiVersion;
+    }
+
+    public void setResume(Boolean resume) {
+        isResume = resume;
+    }
+
+    public void setResourceId(String resourceId) {
+        this.resourceId = resourceId;
+    }
+
+    public void setRequestId(String requestId) {
+        this.requestId = requestId;
+    }
+
+    public void setRequestAction(String requestAction) {
+        this.requestAction = requestAction;
+    }
+
+    public void setRequestDetails(RequestDetails requestDetails) {
+        this.requestDetails = requestDetails;
+    }
+
+    public void setWorkflowResourceIds(WorkflowResourceIds workflowResourceIds) {
+        this.workflowResourceIds = workflowResourceIds;
+    }
+
+    public void setVnfType(String vnfType) {
+        this.vnfType = vnfType;
+    }
+
+    public Boolean isResume() {
+        return isResume;
+    }
+
+    public String getRequestId() {
+        return requestId;
+    }
+
+    public String getApiVersion() {
+        return apiVersion;
+    }
+
+    public String getResourceId() {
+        return resourceId;
+    }
+
+    public String getRequestAction() {
+        return requestAction;
+    }
+
+    public Boolean isaLaCarte() {
+        return aLaCarte;
+    }
+
+    public String getVnfType() {
+        return vnfType;
+    }
+
+    public WorkflowResourceIds getWorkflowResourceIds() {
+        return workflowResourceIds;
+    }
+
+    public RequestDetails getRequestDetails() {
+        return requestDetails;
+    }
+
+}
diff --git a/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/ExecuteBuildingBlock.java b/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/ExecuteBuildingBlock.java
index abd301fa4d..9274e0659e 100644
--- a/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/ExecuteBuildingBlock.java
+++ b/bpmn/MSOCommonBPMN/src/main/java/org/onap/so/bpmn/servicedecomposition/entities/ExecuteBuildingBlock.java
@@ -21,119 +21,36 @@
 package org.onap.so.bpmn.servicedecomposition.entities;
 
 import java.io.Serializable;
-import org.onap.so.serviceinstancebeans.RequestDetails;
 
-public class ExecuteBuildingBlock implements Serializable {
+public class ExecuteBuildingBlock extends BuildingBlockBase implements Serializable {
 
-    private static final long serialVersionUID = 2L;
     private BuildingBlock buildingBlock;
-    private String requestId;
-    private String apiVersion;
-    private String resourceId;
-    private String requestAction;
-    private String vnfType;
-    private Boolean aLaCarte;
-    private Boolean homing = false;
-    private WorkflowResourceIds workflowResourceIds;
-    private RequestDetails requestDetails;
     private ConfigurationResourceKeys configurationResourceKeys;
+    private Boolean homing = false;
+    private static final long serialVersionUID = 3L;
 
     public BuildingBlock getBuildingBlock() {
         return buildingBlock;
     }
 
-    public ExecuteBuildingBlock setBuildingBlock(BuildingBlock buildingBlock) {
+    public void setBuildingBlock(BuildingBlock buildingBlock) {
         this.buildingBlock = buildingBlock;
-        return this;
-    }
-
-    public String getRequestId() {
-        return requestId;
-    }
-
-    public ExecuteBuildingBlock setRequestId(String requestId) {
-        this.requestId = requestId;
-        return this;
-    }
-
-    public String getApiVersion() {
-        return apiVersion;
-    }
-
-    public ExecuteBuildingBlock setApiVersion(String apiVersion) {
-        this.apiVersion = apiVersion;
-        return this;
-    }
-
-    public String getResourceId() {
-        return resourceId;
-    }
-
-    public ExecuteBuildingBlock setResourceId(String resourceId) {
-        this.resourceId = resourceId;
-        return this;
-    }
-
-    public String getRequestAction() {
-        return requestAction;
-    }
-
-    public ExecuteBuildingBlock setRequestAction(String requestAction) {
-        this.requestAction = requestAction;
-        return this;
-    }
-
-    public Boolean isaLaCarte() {
-        return aLaCarte;
-    }
-
-    public ExecuteBuildingBlock setaLaCarte(Boolean aLaCarte) {
-        this.aLaCarte = aLaCarte;
-        return this;
-    }
-
-    public String getVnfType() {
-        return vnfType;
-    }
-
-    public ExecuteBuildingBlock setVnfType(String vnfType) {
-        this.vnfType = vnfType;
-        return this;
     }
 
     public Boolean isHoming() {
         return homing;
     }
 
-    public ExecuteBuildingBlock setHoming(Boolean homing) {
+    public void setHoming(Boolean homing) {
         this.homing = homing;
-        return this;
-    }
-
-    public WorkflowResourceIds getWorkflowResourceIds() {
-        return workflowResourceIds;
-    }
-
-    public ExecuteBuildingBlock setWorkflowResourceIds(WorkflowResourceIds workflowResourceIds) {
-        this.workflowResourceIds = workflowResourceIds;
-        return this;
-    }
-
-    public RequestDetails getRequestDetails() {
-        return requestDetails;
-    }
-
-    public ExecuteBuildingBlock setRequestDetails(RequestDetails requestDetails) {
-        this.requestDetails = requestDetails;
-        return this;
     }
 
     public ConfigurationResourceKeys getConfigurationResourceKeys() {
         return configurationResourceKeys;
     }
 
-    public ExecuteBuildingBlock setConfigurationResourceKeys(ConfigurationResourceKeys configurationResourceKeys) {
+    public void setConfigurationResourceKeys(ConfigurationResourceKeys configurationResourceKeys) {
         this.configurationResourceKeys = configurationResourceKeys;
-        return this;
     }
+
 }
-- 
cgit 1.2.3-korg