From d41863f54c30a20a47e0c5c7d7436d4be72dfd7f Mon Sep 17 00:00:00 2001 From: Lukasz Muszkieta Date: Thu, 2 Aug 2018 16:54:44 +0200 Subject: Add junit for MSOCommonBPMN Change-Id: I665f35bd6385ceec2d5aeff9a1d8af359bccd97a Issue-ID: SO-784 Signed-off-by: Lukasz Muszkieta --- .../groovy/org/onap/so/bpmn/common/scripts/AppCClient.groovy | 12 +----------- .../onap/so/bpmn/common/scripts/CompleteMsoProcess.groovy | 5 ----- 2 files changed, 1 insertion(+), 16 deletions(-) (limited to 'bpmn/MSOCommonBPMN/src/main/groovy/org') diff --git a/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/AppCClient.groovy b/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/AppCClient.groovy index bb1de36eac..5cbbe0ab46 100644 --- a/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/AppCClient.groovy +++ b/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/AppCClient.groovy @@ -20,21 +20,11 @@ package org.onap.so.bpmn.common.scripts -import org.onap.so.bpmn.core.UrnPropertiesReader - -import java.util.HashMap; import org.camunda.bpm.engine.delegate.BpmnError import org.camunda.bpm.engine.delegate.DelegateExecution -import org.hibernate.event.internal.AbstractLockUpgradeEventListener import org.onap.so.bpmn.core.json.JsonUtils -import org.onap.so.client.appc.ApplicationControllerOrchestrator -import org.onap.so.client.appc.ApplicationControllerOrchestratorException import org.onap.appc.client.lcm.model.Action -import org.onap.appc.client.lcm.model.Status -import org.onap.so.bpmn.appc.payload.PayloadClient import org.onap.so.client.appc.ApplicationControllerAction; -import groovy.transform.TypeChecked; -import java.util.UUID; import org.onap.so.logger.MessageEnum import org.onap.so.logger.MsoLogger @@ -113,7 +103,7 @@ public class AppCClient extends AbstractServiceTaskProcessor{ payload = Optional.of(pay) } if(action.equals(Action.HealthCheck)){ - String healthCheckIndex = execution.getVariable('healthCheckIndex') + Integer healthCheckIndex = (Integer) execution.getVariable('healthCheckIndex') execution.setVariable('workStep', action.toString() + healthCheckIndex) execution.setVariable('healthCheckIndex', healthCheckIndex + 1) } diff --git a/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/CompleteMsoProcess.groovy b/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/CompleteMsoProcess.groovy index 9c4c73fb7d..ff5dabf99a 100644 --- a/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/CompleteMsoProcess.groovy +++ b/bpmn/MSOCommonBPMN/src/main/groovy/org/onap/so/bpmn/common/scripts/CompleteMsoProcess.groovy @@ -20,7 +20,6 @@ package org.onap.so.bpmn.common.scripts -import org.apache.commons.lang3.* import org.camunda.bpm.engine.delegate.BpmnError import org.camunda.bpm.engine.delegate.DelegateExecution import org.onap.so.logger.MessageEnum @@ -170,8 +169,6 @@ public class CompleteMsoProcess extends AbstractServiceTaskProcessor { msoLogger.debug("Exception Occured During PreProcessRequest: " + e); exceptionUtil.buildAndThrowWorkflowException(execution, 2000, "Internal Error - Occured in " + method) } - -// msoLogger.trace("Completed CompleteMsoProcess preProcessRequest Method "); } public void setUpdateDBstatustoSuccessPayload (DelegateExecution execution){ @@ -303,8 +300,6 @@ public class CompleteMsoProcess extends AbstractServiceTaskProcessor { msoLogger.error(MessageEnum.BPMN_GENERAL_EXCEPTION_ARG, 'Caught exception in ' + method, "BPMN", MsoLogger.getServiceName(), MsoLogger.ErrorCode.UnknownError, "Exception is:\n" + e); exceptionUtil.buildAndThrowWorkflowException(execution, 2000, "Internal Error - Occured in" + method) } - // msoLogger.trace("Completed CompleteMsoProcess PostProcessRequest Method "); - } -- cgit 1.2.3-korg