From d86cea30986d466da086656ec1fd3e9d56b91a9f Mon Sep 17 00:00:00 2001 From: "r.bogacki" Date: Mon, 24 Jun 2019 14:56:31 +0200 Subject: Sonar fixes and improvements General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596 --- .../main/java/org/onap/so/adapters/sdnc/WebSecurityConfigImpl.java | 6 ++++-- .../onap/so/adapters/sdnc/sdncrest/MapTypedRequestTunablesData.java | 1 - 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'adapters/mso-sdnc-adapter/src/main') diff --git a/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/WebSecurityConfigImpl.java b/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/WebSecurityConfigImpl.java index e1eb9ecef9..232381385f 100644 --- a/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/WebSecurityConfigImpl.java +++ b/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/WebSecurityConfigImpl.java @@ -4,6 +4,8 @@ * ================================================================================ * Copyright (C) 2017 - 2018 AT&T Intellectual Property. All rights reserved. * ================================================================================ + * Modifications Copyright (c) 2019 Samsung + * ================================================================================ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at @@ -34,8 +36,8 @@ public class WebSecurityConfigImpl extends WebSecurityConfig { @Override protected void configure(HttpSecurity http) throws Exception { http.csrf().disable().authorizeRequests().antMatchers("/manage/health", "/manage/info", "/services").permitAll() - .antMatchers("/**").hasAnyRole(StringUtils.collectionToDelimitedString(getRoles(), ",").toString()) - .and().httpBasic(); + .antMatchers("/**").hasAnyRole(StringUtils.collectionToDelimitedString(getRoles(), ",")).and() + .httpBasic(); } @Override diff --git a/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/MapTypedRequestTunablesData.java b/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/MapTypedRequestTunablesData.java index ad99d0da36..979238fe2f 100644 --- a/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/MapTypedRequestTunablesData.java +++ b/adapters/mso-sdnc-adapter/src/main/java/org/onap/so/adapters/sdnc/sdncrest/MapTypedRequestTunablesData.java @@ -41,7 +41,6 @@ public class MapTypedRequestTunablesData { private static final String MISSING_CONFIGURATION_ERROR_MSG = "Missing configuration for: "; private static final String MISSING_CONFIG_PARAM_ERROR_MSG = "Missing config param"; - private static final String MSO_INTERNAL_ERROR = "MsoInternalError"; @Autowired private Environment env; -- cgit 1.2.3-korg