From c1cd5ef428017bc26513395a3bfc00caf7209f8a Mon Sep 17 00:00:00 2001
From: "k.kazak" <k.kazak@samsung.com>
Date: Mon, 27 May 2019 15:00:15 +0200
Subject: Fix sonar for MapEntry

MapEntry bug: make entry private and provide accessors
MapEntry codesmell: move comment 'Required by JAXB' into empty constructor
MapElements codesmell: move explanatory comment inside empty constructor
MapElements codesmell: log error stacktrace
MapAdapter codesmell: use entry set instead of key set for iteration
JAXBMarshallingTest: add test cases to cover 100% of MapElements & other cases

Change-Id: If51f1f86b5ad44b3462424e4fd73cb0eff352124
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
---
 .../VfRequest-marshalled-with-complex-object.xml         | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

(limited to 'adapters/mso-adapters-rest-interface/src/test/resources')

diff --git a/adapters/mso-adapters-rest-interface/src/test/resources/VfRequest-marshalled-with-complex-object.xml b/adapters/mso-adapters-rest-interface/src/test/resources/VfRequest-marshalled-with-complex-object.xml
index ce175127df..d4955f1b18 100644
--- a/adapters/mso-adapters-rest-interface/src/test/resources/VfRequest-marshalled-with-complex-object.xml
+++ b/adapters/mso-adapters-rest-interface/src/test/resources/VfRequest-marshalled-with-complex-object.xml
@@ -3,13 +3,29 @@
     <failIfExists>false</failIfExists>
     <backout>true</backout>
     <vfModuleParams>
+        <entry>
+            <key>vcpe_image_name</key>
+            <value xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xs="http://www.w3.org/2001/XMLSchema" xsi:type="xs:string">ubuntu-16-04-cloud-amd64</value>
+        </entry>
         <entry>
             <key>test array</key>
             <value xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xs="http://www.w3.org/2001/XMLSchema" xsi:type="xs:string">["a","b","c"]</value>
         </entry>
+        <entry>
+            <key>test map</key>
+            <value xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xs="http://www.w3.org/2001/XMLSchema" xsi:type="xs:string">{"d":"e"}</value>
+        </entry>
         <entry>
             <key>test-null</key>
         </entry>
+        <entry>
+            <key>marshalling error</key>
+            <value xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xs="http://www.w3.org/2001/XMLSchema" xsi:type="xs:string">[]</value>
+        </entry>
+        <entry>
+            <key>test-empty</key>
+            <value xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xs="http://www.w3.org/2001/XMLSchema" xsi:type="xs:string"></value>
+        </entry>
     </vfModuleParams>
     <msoRequest/>
 </createVfModuleRequest>
-- 
cgit 1.2.3-korg