From d638edfdbc5c38b4abde3cbe09bc8600c8dca05a Mon Sep 17 00:00:00 2001 From: shashikanth Date: Tue, 26 Sep 2017 17:15:00 +0530 Subject: Fixed string literal comparision Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143 Move the "true" string literal on the left side of this string comparison Issue-Id: APPC-186 Change-Id: I1223f769c06673b9b4817f2cd3965b6bf429f0ef Signed-off-by: shashikanth.vh --- .../src/main/java/org/openecomp/mso/asdc/client/ASDCController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java b/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java index 3ca8527b05..22c4b04ff4 100644 --- a/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java +++ b/asdc-controller/src/main/java/org/openecomp/mso/asdc/client/ASDCController.java @@ -442,7 +442,7 @@ public class ASDCController { try { String resourceType = resourceStructure.getResourceInstance().getResourceType(); String category = resourceStructure.getResourceInstance().getCategory(); - if(resourceType.equals("VF") && !category.equalsIgnoreCase("Allotted Resource")){ + if("VF".equals(resourceType) && !"Allotted Resource".equalsIgnoreCase(category)){ resourceStructure.createVfModuleStructures(); } //resourceInstaller.installTheResource (resourceStructure); -- cgit 1.2.3-korg