aboutsummaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-infra/src/main/java/org/onap
AgeCommit message (Collapse)AuthorFilesLines
2019-04-08Merge "Workflow Recipe Lookup"Steve Smokowski1-5/+44
2019-04-08Do not overwrite requestIdBenjamin, Max (mb388a)1-0/+2
Added filter to reject requests that reuse request ids for requests db Change-Id: Iced020a9e1bc98c93911966f62ac0049e43e314b Issue-ID: SO-1762 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-08Workflow Recipe LookupElena Kuleshov1-5/+44
Workflow Recipe Lookup and related Catalog Beans Change-Id: Ib1c3493106658d139861d2620dfb9cb382115744 Issue-ID: SO-1728 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-05Merge "Fixed Sonar blocker issues"Steve Smokowski1-32/+20
2019-04-05Fixed Sonar blocker issuesr.bogacki1-32/+20
Fixed blockers according to Sonar analysis. Added tests for fixed issues. Change-Id: I8e259147082d722961048454fae9484cc0d8b0a8 Issue-ID: SO-1734 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-04-04Return 200 instead of 202 on WorkflowSpecs GETElena Kuleshov1-1/+1
Return 200 instead of 202 on WorkflowSpecs GET Change-Id: I861801f86416b98beea98913b3788da8180dbdf9 Issue-ID: SO-1745 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-02fix catalogdb cvfnc customizationBenjamin, Max (mb388a)1-1/+6
Hibernate entities were all wrong and needed a complete rewrite. The scope kept growing and ended up touching a lot more of the code than originally planned. These changes make the db interactions much easier and more straightforward from java. The flyway script order had to change to make this migration possible. Change-Id: I6ce363a385661300eddb11923ac6a80538edaddc Issue-ID: SO-1710 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-29Implement custom workflow APIElena Kuleshov6-593/+971
Implement custom workflow execution API Change-Id: I226b83873f44629c203cb9d4a7a2c3fb75e46f87 Issue-ID: SO-1544 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-03-29fix jenkins buildLukasz Muszkieta1-2/+2
Change-Id: If3343b343993476731ab4cd1eb6c5e41d1033c4d Issue-ID: SO-1714 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-03-28Merge "Add WorkflowSpecification Beans for APIH"Steve Smokowski9-0/+896
2019-03-26Add WorkflowSpecification Beans for APIHElena Kuleshov9-0/+896
Add WorkflorSpecification beans and handling mechanism Change-Id: Iaabd5696f9ddc4cca87c6fb77da42042b758932d Issue-ID: SO-1543 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-03-20Updated to use vnfOperationalEnvironmentIdBenjamin, Max (mb388a)1-2/+3
Updated to use vnfOperationalEnvironmentId to call AAI for PATCH status to ACTIVE. Change-Id: Ic2057b39a737b9636d0a053e097d762430fe991b Issue-ID: SO-1685 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-19Merge "Update Tasks API with additional fields"Steve Smokowski3-3/+56
2019-03-18Removed MsoLogger classr.bogacki19-144/+144
Bye bye MsoLogger class. Extracted constants to separated classes. Fixed imports. Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-15Update Tasks API with additional fieldsElena Kuleshov3-3/+56
Update Tasks API with additional fields and new valid response Change-Id: I39d85ae599f9274373bbcf66dce4752ee75f16ed Issue-ID: SO-1594 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-03-14Saved vnfOperationalEnvironmentId to be used laterBenjamin, Max (mb388a)3-6/+39
Removed unnecessary lines in junit test class. Saved vnfOperationalEnvironmentId to the model table to be used for AAI status update call later. Change-Id: I812d21d483d716bb5135c408369a160e4600efc2 Issue-ID: SO-1662 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-14Merge "Pass the revised value of usePreload to JSON"Steve Smokowski1-3/+7
2019-03-13Added param requestId to query 1 rowBenjamin, Max (mb388a)2-13/+14
Added param requestId to uniquely query 1 row from model distribution status db. Change-Id: Ice8db174166e6a00d211f191dcf5537eef729127 Issue-ID: SO-1651 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-13Pass the revised value of usePreload to JSONBenjamin, Max (mb388a)1-3/+7
Pass the possibly revised value of usePreload to JSON going to BPMN. Change-Id: Idc46a8786bc7bbdbf860b59998785c1c885689e4 Issue-ID: SO-1652 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-13Merge "Set fromPreload to true for aLaCarte and to false"Steve Smokowski1-0/+17
2019-03-13Updated from 'timeStamp' to 'timestamp'Benjamin, Max (mb388a)1-1/+1
Updated from 'timeStamp' to 'timestamp' in RequestStatus Change-Id: I863c87126e4a58179d82e6fe5d524d72ef57b4f1 Issue-ID: SO-1643 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-13Set fromPreload to true for aLaCarte and to falseBenjamin, Max (mb388a)1-0/+17
Set fromPreload to true for aLaCarte and to false for Macro if no usePreload value is specified. Change-Id: I3ca148dc93c03040de32174566dee2bf90851ced Issue-ID: SO-1641 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-12add instance group support to SOBenjamin, Max (mb388a)2-14/+27
add create support add delete support added naming service support Change-Id: Iaf4f2bdae8ea55aca71d6e9b818a76e90db0b012 Issue-ID: SO-1616 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-11Cleaned up MsoLogger classr.bogacki3-6/+0
Removed setServiceName method from MsoLogger. Cleaned up unused methods from MsoLogger. Change-Id: I1fe033ed25dda32c07693a5087bf65de3ecc229c Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-08Merge "Cleaned up MsoLogger from 'mso-api-handlers'"Steve Smokowski1-308/+142
2019-03-07Merge "Revert Tenant Isolation /modelDistributions API"Steve Smokowski3-3/+8
2019-03-07Cleaned up MsoLogger from 'mso-api-handlers'r.bogacki1-308/+142
Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: Ie94df7dbe4ce05ab7de77318401473390f822d1e Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-07Revert Tenant Isolation /modelDistributions APIBenjamin, Max (mb388a)3-3/+8
Tenant Isolation support PATCH again per AID. Added ModelDistributionRequest class to Jersey Configuration. PATCH JUnit generating 404 - Resource Not Present. Revert Tenant Isolation /modelDistributions API to support PATCH again per AID. Change-Id: I08b4c2b0e080bb4615ebae435ecf18e5c438035d Issue-ID: SO-1603 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-07Cleaned up MsoLogger from 'mso-api-handler-infra'r.bogacki1-1/+0
Removed unnecessary MsoLogger. Change-Id: I95f839c924fe7a2b1977f4e50632f230888790ce Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-06improvements to audit inventory featureBenjamin, Max (mb388a)1-0/+1
Adjust test data to add tenant mapping Remove unused unit test already renamed Update logic, to pass hostname not pservername remove unused file that has been refactored Add project to ignore, remove class Address issues in comments on pull request Remove logging that is not needed, used UPdate BPMN to use Boolean Value, change timings Adjust BPMN to not hit deadlock scenario put error message in execution before checking rollback - removed extra code for vnf resource processing found in onap environment. Fix improper use of inclusive gateway causing deadlock Fix flakey unit tests from ONAP Remove qualifier on bean, as it breaks callbacks Adjust pom version of external camunda client Fix polling timers to be more reasonable Updated Junit test for delete vf module in onap. Changed auditInventoryNeeded variable to a boolean to prevent bpmn from erroring out in the event this variable is not found on the execution. Update logic to support writing of self link Change-Id: I2f784a0a58a09f303775282c9be6019031668570 Issue-ID: SO-1597 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-04Removed MsoLogger from 'mso-api-handlers'r.bogacki22-145/+214
Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: Id0f1e0dda34038d8dbf6894e5d4e6923dc3a8440 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-28CorrelationId cleanupJoanna Jeremicz1-7/+7
Remove old correlationId field and references from ServiceInstancesRequest and rename correlationId to pnfCorrelationId Change-Id: I5d8861aebe14c68574b6c54bc8d4eadf2967478b Issue-ID: SO-1274 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2019-02-26check that a la carte is not nullBenjamin, Max (mb388a)1-3/+1
Handle the case of absent aLaCarte and usePreload settings Change-Id: Ic3413515218013870ddce97ec225edaa6b6e99c3 Issue-ID: SO-1571 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-20assignvfmodulebb must send use-preloadBenjamin, Max (mb388a)1-3/+13
Corrections to JUnit data to account for usePreload usage. Resurrect usage of usePreload value and pass fromPreload to SDNC. Change-Id: I6fb52f6abf09ec501e90335a01e37db1c10ae2b3 Issue-ID: SO-1539 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-19Added the conversion of decrypted valueBenjamin, Max (mb388a)1-3/+4
Added jUnit test for the conversion of decrypted value to Basic Base64Binary. Added the conversion of decrypted value as Basic Base64Binary. Change-Id: I361cbe3dac61df2728c9f58c314a21b3cc764a9f Issue-ID: SO-1531 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-15Use APIH credentials in 'mso.db.auth'Benjamin, Max (mb388a)1-3/+12
Updated to use methods: env.getRequiredProperty() and msoLogger.error(). Added the msoKey and the CryptoUtils.decrypt() code, and used "mso.camundaAuth". Used APIH credentials in 'mso.db.auth' as source instead of 'mso.camundaAuth' (need decrypt code by CryptoUtils). Change-Id: I66c9d96db8137c1d9a5b56aa33d14587cbaa7b9e Issue-ID: SO-1517 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Merge "use encrypted auth for dmaap"Steve Smokowski2-6/+6
2019-02-05Removed duplicate classes from api handlerBenjamin, Max (mb388a)6-229/+0
removed duplicate classes Change-Id: I5158e1b8ce197cb8c204e484b87a5411161f3d93 Issue-ID: SO-1464 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-31use OE from AAI with sdcBenjamin, Max (mb388a)5-24/+46
Updated the SDC API call with the ECOMP OE from AAI relationship instead of VNF OE value. Change-Id: I576ed83364f11213f36781c033f7c2d56f98f1c6 Issue-ID: SO-1451 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-25Merge "update all inprogress checks in apih handler"Steve Smokowski1-7/+76
2019-01-24update all inprogress checks in apih handlerBenjamin, Max (mb388a)1-7/+76
Added second mapper for error responses Removed method level ObjectMapper instantiation Fixed formatting of resource file Added db update if responsne from history lookup is empty Fixed url and added it to yaml file Removed space added to the end of line Removed unused test resource file Changed wording of exception message name Added more JUnit tests and fixed auth lookup Added path for checking process-instance history Added ContactCamundaException for camundaHistoryCheck Began adding auth header to send on request to camunda Added unit tests for completed and terminated requests Began adding test for camundaHistoryCheck Added HistoricProcessInstance object for camunda response Test commit, added comment to camundaHistoryCheck Began adding method for checking camundaHistory Change-Id: Ia9d94613fa5e78f2b8690874c39f032d60599e5e Issue-ID: SO-1414 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24use encrypted auth for dmaapBenjamin, Max (mb388a)2-6/+6
remove deobfuscate as crypto is already used. update based on the feedback to use crypto utils to decrypt Re-Factor DMAAP Credentials to use encrypted auth credential Change-Id: I2ac5be84594d84f0f24ae554d99cef274dbb6c16 Issue-ID: SO-1425 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24bugfixes jan 24thBenjamin, Max (mb388a)1-0/+6
Fix null pointer exception when no requestParameters are specified Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger - use {} formatting Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - removed unused references in test class Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate Update PortGroup objects separately from the parent VCE object - restore setVariable calls back into vce object - they might be needed later. Update PortGroup objects separately from the parent VCE object - updated test class extra call to get PortGroups Update PortGroup objects separately from the parent VCE object - use PortGroup.getInterfaceRole() getter method instead of accessing field directly. Update PortGroup objects separately from the parent VCE object Added back required headers for tenant isolation. removed workflow exception from outmapping in execute Fix possible null ptr exception, fix to add braces. Default networkTechnology in Update as done in Create Fix failing junits, mapper force upper case nwtech update exception builder to properly throw exception error message supporting assign service instance a la carte as well adding in proper exception handling in network rest v1 add the unassign action to R macro data file Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7 Issue-ID: SO-1424 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-21Merge "Bug fixes from AT&T January 20th"Steve Smokowski1-4/+4
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)1-4/+4
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-20ensure data for si matches on macro requestsBenjamin, Max (mb388a)2-21/+54
Fixed failing ValidationExceptionTest Moved MacroRequest.json to test specific folder Moved resource files to test specific folder Cleaned up comments from UserParamsValidationTest Refactored modelInfoValidation method Removed unused constants from ValidationException Removed unused ValidationException ADded overrideExistingMessage boolean Added test for missing modelType in userParams service object Fixed failing JUnit tests in MsoRequestTest Started fixing failing JUnit tests Began adding validation and tests for userParams modelInfo Began adding validation for instanceName Change-Id: I442f6b660af4e716d75746f8d8155aac1e183e80 Issue-ID: SO-1405 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-15Either log or rethrow this exception.Shubhada Ramkrishna Vaze1-1/+1
Location:GlobalHealthcheckHandler.java Line No:180 Change-Id: I679e99774cee228dc239f0403a44be223fdd46cd Issue-ID: SO-1360 Signed-off-by: Shubhada Ramkrishna Vaze <SV00449682@TechMahindra.com>
2019-01-11updated logging to JaxRsFilterLoggingBenjamin, Max (mb388a)1-0/+4
Changed the MDC sourcing from LoggingInterceptor to JaxRsFilterLogging. Change-Id: Idd807f1bf6d3a5a680f547d09503a53a362cd5d1 Issue-ID: SO-1362 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)1-6/+9
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Merge "Added timeStamp to requestStatus returned"Steve Smokowski1-0/+4