Age | Commit message (Collapse) | Author | Files | Lines |
|
warning about unused variable"
|
|
* changes:
Added null check for function param pFqdns to prevent crash at for loop.
Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning
|
|
Remove duplicate name check in createAAITasks. This hould be done prior
to status check in WorkflowAction or BBInputSetup.
Issue-ID: SO-2119
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I0d6d34476b1ab2b351314c9a23926f2fff0e4f89
|
|
analyzer warning about workflowResponse never being set to anything but null."
|
|
|
|
|
|
|
|
|
|
Add requestContext to unassignVfModule tasks and tests
Issue-ID: SO-2115
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ifddfe32fab9406afb69ad9192351500cfbed3610
|
|
Need to check if audit is enabled first in the delete record task
Updates to audit delete redeisgn and data to table
Various updates to logging, audit object, added tag to query, updated
tag value.
Updated write method to make sure an entry for this heat stack doesnt
already exist to avoid duplicate entrys
Updated unit test to account for get query
Added so that id is not hidden from query results
Updated the was delete is done plus minor updates.
Updated delete method to use resttemplate instead of bowman client
Combined the write and get stack data task into the external tasks.
Removed the task to delete the stack data from db
Updates to junit request id so its not a random id for test
Updated service tasks in att BB to call external task
Update to be a real uuid format due to failing unit test
Updated fields to protected and updated unit test
Issue-ID: SO-2111
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
|
|
static analyzer warning about unused variable
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0d46bcc817d08a6fbad3501c56336dc532bb5907
|
|
static analyzer warning about workflowResponse never being
set to anything but null.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib150e3836fda9b7d9785a574f904b2c61bfa39f4
|
|
gBBInput.getCustomer().getServiceSubscription() -
to prevent static analyzer warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70
|
|
Fixes in WorkflowAction according to the Sonar analysis:
-Fixed String comparison.
-Removed unnecessary method parameters.
-Updated junit test.
Issue-ID: SO-2107
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I7522269e237f736521a627bcd1c8f77b0c776a70
|
|
Major Sonar fixes in different classes:
-Removed unused variables.
-Simplified diamond operators.
-Removed unnecessary imports.
-Removed unnecessary code.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
|
|
Sonar vulnerability fixes in ServicePluginFactory.
-Moved hardcoded IP addresses to the property file.
-Added junit test.
Issue-ID: SO-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
|
|
|
|
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED,
ROLLED_BACK_TO_CREATED, and ABORTED.
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED,
ROLLED_BACK_TO_CREATED, and ABORTED. Added default FAILED request
status in case rollback is not needed.
Variable rollbackTargetState needs to be returned to WorkflowAction flow
Variable rollbackTargetState needs to in to ExecuteBuildingBlock as
well. Add new RequestDb migration file to expand infra_active_requests
column request_status to 25 bytes to fit new request states.
Change-Id: I0da2f8013001a28dcc20f64eb9455e4cfd3dd197
Issue-ID: SO-2093
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added ext error source to workflow exception
Updated all lines that create this exception with source
Added unit tests and updated existing ones
Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb
Issue-ID: SO-2092
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Change-Id: Ib7c692b2a7fd8bc5f40d6a4acba504948cc7fc1b
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
update rollback error for rollback and not original msg
run code formatting on updated files
add unit test for false value of isRollback flag
Change-Id: I25d8fb9771766461b1192e3758237dfc199787f8
Issue-ID: SO-2081
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
init code for RESUME with junit passing
overwrite URI on resume op from original request
Change-Id: I1eee2bd66aa20804ba4a2834d269b5947565b9dc
Issue-ID: SO-2055
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
improved logging when no exception data is found
Change-Id: I4f6298652ad474119cd1ebc58a927d532ea3e6be
Issue-ID: SO-2068
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
- Handle multiple cvnfc configs with the same model uuid.
- Update CvnfcConfigurationCustomization to a List from a Set
Change-Id: I8c026510d813ebb6294a9cedd39d4d4b8f4b9dcf
Issue-ID: SO-2056
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix macro delete instance bug. vf-modules not being sorted correctly
because isbaseboolean field is not being set.
Change-Id: Id196e152977d922bee6c9bb797ad240bb70fbf47
Issue-ID: SO-2053
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
|
|
Change-Id: I2b91332563d9c7b0f469c9e45a35cc1376465c5e
Issue-ID: SO-2058
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ie759b98828f39fba00ccdb7edcd7fc28e83ea50e
|
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary code.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
|
|
Update commons-collections version to 3.2.2.
Updated distribution client version to 1.4.0.
Update commons-fileupload to version 1.4.
Update commons-codec to version 1.12.
Change-Id: I4ab794e3aef7300c30088e5197092fd30231c4af
Issue-ID: SO-2043
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
format AbstractRestHandler.java file
Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3
Issue-ID: SO-2044
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
|
|
|
|
|
|
pass mso-request-id to adapter call to match search
Change-Id: Ie9e4f8559fd9153d503ad5913838d7c5d175e7bd
Issue-ID: SO-2033
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Swap to using HTTP Enumerations rather than ints
Add Unit Tests to Service Instances endpoint
Add Vnf Tests remove Abstract class
Clean up usage of abstract classes
Fix volume and module bean wiring issues
Add logic to find create request if cloud not in AAI
Updated network to take in version pathparam
Additonal refactor of the endpoints
Add missing license headers to all files
Clean up public variable usage, move to protected
Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d
Issue-ID: SO-2032
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added code block to throw exception when we get a 'Name' wthout a
'Value' tag in the SDNC vf-module-topology. Right now we are seeing
oam0_net_id is missing a value tag. Added Unit test to test this code
change.
Change-Id: I765d5a4eb9d351b7613d4c3561a2a5dbe37e4781
Issue-ID: SO-2031
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Change-Id: I219989c25f05c94d01c7c697425da93997114216
Issue-ID: SO-2029
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
|
|
Fixed critical bugs according to the Sonar analysis.
-Fixed possible NPE.
-Fixed wrong comparison.
-Removed unused variables.
Issue-ID: SO-2025
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
|
|
These are changes related to ASDC controller for evicting database
connection pool when ip address changes
Included other appllications such as requestDB, CatalogDB, API Handler,
BPMN, OpenstackAdapter etc
Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe
Issue-ID: SO-2018
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Improvements in diamond operators.
-Removed unnecessary code.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9345b6ab0f4027b17e1bebf0b6657394c13dc298
|
|
Validate ServiceInstance name using createNodesUri.
Change-Id: I5194dd933dc98064888250bc9a38e6ee9716fc01
Issue-ID: SO-2024
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|