Age | Commit message (Collapse) | Author | Files | Lines |
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary variables.
-Protect utility static classes with private constructor.
-Removed unnecessary exceptions.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib0011d730f86e0e1a25d4cf1080a61b2fbb335ae
|
|
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00
Issue-ID: SO-1981
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
|
|
update the onap delete vf module BB bpmn as well
validate formatting of audit tasks code changes
added a property to determine if delete audit is needed
Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83
Issue-ID: SO-1964
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
enums are now single item per line
Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
unit test for the method that creates subnets
Remove project name from junit test data
Handle multiple host routes correctly for networks
Change-Id: I537b9bbb68c11901c06ed2366591cedeb3b29acd
Issue-ID: SO-1961
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added NPE check so that flow continues when no audit results present
Change-Id: I614dbaff7eaaca86a503da2734d7c5f7a197bb1b
Issue-ID: SO-1959
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Modified the subprocess 'DoDeleteE2EServiceInstance'
to support Group level instances.
Change-Id: I8dfd154bc6eb9c9f7c7dc932bdce215a3b9fd800
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
|
|
Fix request body for SDNC req.
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Ia8112b81fa29f886e282445b3c0dc068d487cadd
|
|
Issue-ID: SO-1921
Change-Id: Id20f8f7d77469e8123317447aa974a3e77103761
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
|
|
fix unit test now that method does not update status
Remove update of request status, should not be done
Change-Id: I17958ef76ccfa059893da0c2bcea1baa124d6922
Issue-ID: SO-1915
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Request body fix for sdnc requests.
Change-Id: Id3e454be18c62ab8c2e5ee572de55bf3ef7c18a3
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Fix instance resource list if group is not list type.
Change-Id: I99d37d5407c925dbb3355de73105de755b30bc04
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Fixed the issue when subprocess 'DoDeleteE2EServiceInstance'
calls 'AAI GenericGetService' sub-process
which is deleted from SO common-bpmn.
Change-Id: I8f5dce0135031c2d44fccd51676a709f014ef3c7
Issue-ID: SO-1809
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
Optimized VF/GROUP/VFC level parsing logic
as per doCompareModel call flow
Change-Id: If934ee1407a1bad6c9adec9e32533166b5fb4d93
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
|
|
Fix SDNC Resource Creation workflow
Issue-ID: SO-1393
Change-Id: Ia75150adf3695e623a2f3ec7ea5f720667142c1b
Signed-off-by: Isaac Manuel Raj <isaac.manuelraj@huawei.com>
|
|
|
|
|
|
|
|
Added extra VF/VFC level test cases,
also corrected first level index increment logic.
Change-Id: I18982b4b6821da4f7dc06743c3aeca0fa54176e3
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
|
|
Add model type to resource model.
Change-Id: Ic1937d859cebca1b515d9c069c51c9811d6874ab
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Renamed variable from contin to flowShouldContinue.
Updated bpmn junits and exceptionbuilder junits.
Updated bpmns to use non interrupting escalation event.
Altered bpmn and audit behavior on delete vf module
Change-Id: I4ade4c934a9193099cfd29d740c68e60633c03e5
Issue-ID: SO-1896
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix null check for groups.
Change-Id: I2432707e4a6dc6bfe49d23eddc9318562c2c43b3
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Removed/Cleaned-up unnecessary lines/codes.
Updated junit tests for END_TIME to any(Timestamp.class).
END_TIME is not populated by bpmn when rainy day retry or rollback is
executed.
Change-Id: I614d66ca767629bf43aac8eee981423e5393015e
Issue-ID: SO-1887
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Removed white spaces so that they are gone.
Change to set workflowexceptionerrormessage in all cases so that its
available to workflowactionbb.
Change-Id: I66130b80eab0c0a0f96c3a7a5509bb70dda26884
Issue-ID: SO-1886
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
mapped host routes into gbb l3 network object
Change-Id: Ie3ab4693f7584946b1e2020d43143412bec62631
Issue-ID: SO-1885
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Openstack request status now stored in request db
Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d
Issue-ID: SO-1867
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Issue-ID: SO-1877
Change-Id: I2b8f25311e92d35bffe1c70490041d32be217c5a
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
|
|
|
|
|
|
|
|
|
|
Clean up unused tests and code, update UT
Fix issue with junits and conflicts on id field
Update Rainy day handling to be more robust
Change-Id: I2ce9a1288457017613dece19357e44b8566867c5
Issue-ID: SO-1866
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Updated closing gateway to be inclusive instead.
Change-Id: If877bf71b406d00f7a0e277b88f9e3064e642be0
Issue-ID: SO-1868
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Created custom BadResponseException class
Change-Id: I9b7288c5c489e155a84f2b98956df8f3f8f53bb4
Issue-ID: SO-1864
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
OperationProgressor: restore interrupted state
PnfEventReadyDmaapClient: remove useless check for null that never happens
Test for this case already exists in
PnfEventReadyDmaapClientTest.pnfCorrelationIdIsNotFoundInHttpResponse
Change-Id: Ic7e4d0cb701721ee4d9a8bc46d65dc1d847d7704
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
Save format when resource is list type
e.g.
{key2:[vf_prop_list,INDEX,key]|default}
Issue-ID: SO-1393
Change-Id: Ibb5e7bb31114fa3bbd7a3e1af5f2152a98941a4b
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
|
|
Removed unnecessary null checks from ResourceRequestBuilder
according to comments from https://gerrit.onap.org/r/#/c/87001/
Change-Id: I21140d812982713229c322d772e6a10f7c7c044d
Issue-ID: SO-1498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Remove unused logger,replace type specification sdnc beans and mapper classes
Issue-ID: SO-1490
Change-Id: I9a671f0ade5b86dbfd4cce1fbc6c07c0fdcf38a8
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
|
|
Fixed possible NullPointerException in ResourceRequestBuilder
according to the Sonar analysis.
Change-Id: Ide97a1a6439342ef55fc490916c945d194d4e518
Issue-ID: SO-1498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|