From 231bc997e100c502080dfb903b3e507771aa7456 Mon Sep 17 00:00:00 2001
From: Bharat saraswal <bharat.saraswal@huawei.com>
Date: Fri, 22 Sep 2017 20:10:31 +0530
Subject: Resolved below sonar issues.

uncessary use of string builder removed.
removed redundant code.
rename variable to follow camelCase.
removed tab char and changed them with spaces.

Issue-ID:SO-98
Change-Id: Idbeed60ebc843c91a89fdd9357330e5e093172c6
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
---
 .../openstack/nova/api/QuotaSetsResource.java      | 97 +++++++++++-----------
 1 file changed, 50 insertions(+), 47 deletions(-)

(limited to 'nova-client/src/main/java/com/woorea/openstack/nova/api/QuotaSetsResource.java')

diff --git a/nova-client/src/main/java/com/woorea/openstack/nova/api/QuotaSetsResource.java b/nova-client/src/main/java/com/woorea/openstack/nova/api/QuotaSetsResource.java
index 166fb42..0670c4b 100644
--- a/nova-client/src/main/java/com/woorea/openstack/nova/api/QuotaSetsResource.java
+++ b/nova-client/src/main/java/com/woorea/openstack/nova/api/QuotaSetsResource.java
@@ -10,52 +10,55 @@ import com.woorea.openstack.nova.model.QuotaSet;
 import com.woorea.openstack.nova.model.SimpleTenantUsage;
 
 public class QuotaSetsResource {
-	
-	private final OpenStackClient CLIENT;
-	
-	public QuotaSetsResource(OpenStackClient client) {
-		CLIENT = client;
-	}
-	
-	public ShowQuota showQuota(String tenantId) {
-		return new ShowQuota(tenantId);
-	}
-
-	public UpdateQuota updateQuota(String tenantId, QuotaSet quotaSet) {
-		return new UpdateQuota(tenantId, quotaSet);
-	}
-
-	public ShowUsage showUsage(String tenantId) {
-		return new ShowUsage(tenantId);
-	}
-
-	public ShowUsedLimits showUsedLimits() {
-		return new ShowUsedLimits();
-	}
-
-	public class ShowQuota extends OpenStackRequest<QuotaSet> {
-	    public ShowQuota(String tenantId) {
-	    	super(CLIENT, HttpMethod.GET, new StringBuilder("/os-quota-sets/").append(tenantId), null, QuotaSet.class);
-	    }
-	    
-	}
-
-	public class UpdateQuota extends OpenStackRequest<QuotaSet> {
-		public UpdateQuota(String tenantId, QuotaSet quotaSet) {
-			super(CLIENT, HttpMethod.PUT, new StringBuilder("/os-quota-sets/").append(tenantId), Entity.json(quotaSet), QuotaSet.class);
-		}
-	}
-
-	public class ShowUsage extends OpenStackRequest<SimpleTenantUsage> {
-		public ShowUsage(String tenantId) {
-			super(CLIENT, HttpMethod.GET, new StringBuilder("/os-simple-tenant-usage/").append(tenantId), null, SimpleTenantUsage.class);
-		}
-	}
-
-	public class ShowUsedLimits extends OpenStackRequest<Limits> {
-		public ShowUsedLimits() {
-			super(CLIENT, HttpMethod.GET, new StringBuilder("/limits"), null, Limits.class);
-		}
-	}
+
+    private final OpenStackClient client;
+
+    public QuotaSetsResource(OpenStackClient client) {
+        this.client = client;
+    }
+
+    public ShowQuota showQuota(String tenantId) {
+        return new ShowQuota(tenantId);
+    }
+
+    public UpdateQuota updateQuota(String tenantId, QuotaSet quotaSet) {
+        return new UpdateQuota(tenantId, quotaSet);
+    }
+
+    public ShowUsage showUsage(String tenantId) {
+        return new ShowUsage(tenantId);
+    }
+
+    public ShowUsedLimits showUsedLimits() {
+        return new ShowUsedLimits();
+    }
+
+    public class ShowQuota extends OpenStackRequest<QuotaSet> {
+
+        public ShowQuota(String tenantId) {
+            super(client, HttpMethod.GET, "/os-quota-sets/" + tenantId, null, QuotaSet.class);
+        }
+    }
+
+    public class UpdateQuota extends OpenStackRequest<QuotaSet> {
+
+        public UpdateQuota(String tenantId, QuotaSet quotaSet) {
+            super(client, HttpMethod.PUT, "/os-quota-sets/" + tenantId, Entity.json(quotaSet), QuotaSet.class);
+        }
+    }
+
+    public class ShowUsage extends OpenStackRequest<SimpleTenantUsage> {
+
+        public ShowUsage(String tenantId) {
+            super(client, HttpMethod.GET, "/os-simple-tenant-usage/" + tenantId, null, SimpleTenantUsage.class);
+        }
+    }
+
+    public class ShowUsedLimits extends OpenStackRequest<Limits> {
+
+        public ShowUsedLimits() {
+            super(client, HttpMethod.GET, "/limits", null, Limits.class);
+        }
+    }
 }
 
-- 
cgit 1.2.3-korg