From 56d83f2aa390098fc8f3077194bdcba5c1c90090 Mon Sep 17 00:00:00 2001
From: Bharat saraswal <bharat.saraswal@huawei.com>
Date: Fri, 22 Sep 2017 19:47:16 +0530
Subject: Resolved below sonar issues.

removed redundant code.
added method for resuablity of string builder.
rename variable to follow camelCase.
removed tab char and changed them with spaces.

Issue-ID:SO-98
Change-Id: Ib081df5cbfdb4d2183ac51cb6779177ec2009bc6
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
---
 .../openstack/keystone/api/UsersResource.java      | 146 ++++++++++-----------
 1 file changed, 73 insertions(+), 73 deletions(-)

(limited to 'keystone-client/src/main/java/com/woorea/openstack/keystone/api/UsersResource.java')

diff --git a/keystone-client/src/main/java/com/woorea/openstack/keystone/api/UsersResource.java b/keystone-client/src/main/java/com/woorea/openstack/keystone/api/UsersResource.java
index dbb897c..94a5b68 100644
--- a/keystone-client/src/main/java/com/woorea/openstack/keystone/api/UsersResource.java
+++ b/keystone-client/src/main/java/com/woorea/openstack/keystone/api/UsersResource.java
@@ -9,77 +9,77 @@ import com.woorea.openstack.keystone.model.User;
 import com.woorea.openstack.keystone.model.Users;
 
 public class UsersResource {
-	
-	private OpenStackClient client;
-	
-	public UsersResource(OpenStackClient client) {
-		this.client = client;
-	}
-	
-	public List list() {
-		return new List();
-	}
-	
-	public Create create(User user) {
-		return new Create(user);
-	}
-	
-	public Show show(String id) {
-		return new Show(id);
-	}
-	
-	public Update update(String id, User user) {
-		return new Update(id, user);
-	}
-	
-	public Delete delete(String id) {
-		return new Delete(id);
-	}
-
-	public class List extends OpenStackRequest<Users> {
-		
-		public List() {
-			super(client, HttpMethod.GET, "/users", null, Users.class);
-		}
-
-	}
-	
-	public class Create extends OpenStackRequest<User> {
-
-		private User user;
-		
-		public Create(User user) {
-			super(client, HttpMethod.POST, "/users", Entity.json(user), User.class);
-			this.user = user;
-		}
-		
-	}
-	
-	public class Show extends OpenStackRequest<User> {
-		
-		public Show(String id) {
-			super(client, HttpMethod.GET, new StringBuilder("/users/").append(id).toString(), null, User.class);
-		}
-
-	}
-	
-	public class Update extends OpenStackRequest<User> {
-		
-		private User user;
-		
-		public Update(String id, User user) {
-			super(client, HttpMethod.PUT, new StringBuilder("/users/").append(id).toString(), Entity.json(user), User.class);
-			this.user = user;
-		}
-
-	}
-	
-	public class Delete extends OpenStackRequest<Void> {
-		
-		public Delete(String id) {
-			super(client, HttpMethod.DELETE, new StringBuilder("/users/").append(id).toString(), null, Void.class);
-		}
-		
-	}
-	
+
+    private static final String USERS = "/users/";
+    private OpenStackClient client;
+
+    public UsersResource(OpenStackClient client) {
+        this.client = client;
+    }
+
+    public List list() {
+        return new List();
+    }
+
+    public Create create(User user) {
+        return new Create(user);
+    }
+
+    public Show show(String id) {
+        return new Show(id);
+    }
+
+    public Update update(String id, User user) {
+        return new Update(id, user);
+    }
+
+    public Delete delete(String id) {
+        return new Delete(id);
+    }
+
+    public class List extends OpenStackRequest<Users> {
+
+        public List() {
+            super(client, HttpMethod.GET, "/users", null, Users.class);
+        }
+    }
+
+    public class Create extends OpenStackRequest<User> {
+
+        private User user;
+
+        public Create(User user) {
+            super(client, HttpMethod.POST, "/users", Entity.json(user), User.class);
+            this.user = user;
+        }
+    }
+
+    public class Show extends OpenStackRequest<User> {
+
+        public Show(String id) {
+            super(client, HttpMethod.GET, getUserString(id), null, User.class);
+        }
+    }
+
+    public class Update extends OpenStackRequest<User> {
+
+        private User user;
+
+        public Update(String id, User user) {
+            super(client, HttpMethod.PUT, getUserString(id), Entity.json(user),
+                User.class);
+            this.user = user;
+        }
+    }
+
+    public class Delete extends OpenStackRequest<Void> {
+
+        public Delete(String id) {
+            super(client, HttpMethod.DELETE, getUserString(id), null, Void.class);
+        }
+    }
+
+    private String getUserString(String id) {
+        return USERS + id;
+    }
 }
-- 
cgit 1.2.3-korg