From 25940a0b0ace9554d36899ed2fab6b0e1a49b059 Mon Sep 17 00:00:00 2001 From: Isaac Manuel Raj Date: Fri, 12 Apr 2019 16:01:05 +0530 Subject: Code Enhancement (Sonar Fixes) Sonar Issues Fixes Issue-ID: SO-1490 Change-Id: I0cb3dcd4b67e403bbebe1ae32dcb1606bf57a2fa Signed-off-by: Isaac Manuel Raj --- .../api/extensions/FloatingIpDnsExtension.java | 56 +++++++++++----------- .../api/extensions/FloatingIpPoolsExtension.java | 10 ++-- 2 files changed, 33 insertions(+), 33 deletions(-) diff --git a/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpDnsExtension.java b/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpDnsExtension.java index f2a6bd6..8442e3d 100644 --- a/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpDnsExtension.java +++ b/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpDnsExtension.java @@ -25,33 +25,33 @@ import com.woorea.openstack.nova.model.FloatingIpDomain; import com.woorea.openstack.nova.model.FloatingIpDomains; public class FloatingIpDnsExtension { - + private final OpenStackClient CLIENT; - + public FloatingIpDnsExtension(OpenStackClient client) { CLIENT = client; } - + public ListDomains listFloatingIpDomains() { return new ListDomains(); } - + public CreateDomain create(FloatingIpDomain floatingIpDomain) { return new CreateDomain(floatingIpDomain); } - + public ShowDomain show(String id) { return new ShowDomain(id); } - + public UpdateDomain update(FloatingIpDomain floatingIpDomain) { return new UpdateDomain(floatingIpDomain); } - + public DeleteDomain delete(String id) { return new DeleteDomain(id); } - + public class ListDomains extends OpenStackRequest { public ListDomains() { @@ -62,44 +62,44 @@ public class FloatingIpDnsExtension { public class CreateDomain extends OpenStackRequest { - private FloatingIpDomain floatingIpDomain; - + + public CreateDomain(FloatingIpDomain floatingIpDomain) { super(CLIENT, HttpMethod.POST, "/os-floating-ip-dns", Entity.json(floatingIpDomain), FloatingIpDomain.class); - this.floatingIpDomain = floatingIpDomain; + } - + } - + public class ShowDomain extends OpenStackRequest { - + public ShowDomain(String id) { super(CLIENT, HttpMethod.GET, new StringBuffer("/os-floating-ip-dns/").append(id).toString(), null, FloatingIpDomain.class); } - + } - + public static class UpdateDomain extends OpenStackRequest { - private FloatingIpDomain floatingIpDomain; - + + public UpdateDomain(FloatingIpDomain floatingIpDomain) { - //super(CLIENT, HttpMethod.PUT, new StringBuffer("/os-floating-ip-dns/").append(id).toString(), Entity.json(floatingIpDomain), FloatingIpDomain.class); - this.floatingIpDomain = floatingIpDomain; + + } - + } - + public class DeleteDomain extends OpenStackRequest { - + public DeleteDomain(String id) { super(CLIENT, HttpMethod.DELETE, new StringBuffer("/os-floating-ip-dns/").append(id).toString(), null, Void.class); } - + } - - - -} + + + +} \ No newline at end of file diff --git a/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpPoolsExtension.java b/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpPoolsExtension.java index d574ef6..c6325d4 100644 --- a/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpPoolsExtension.java +++ b/nova-client/src/main/java/com/woorea/openstack/nova/api/extensions/FloatingIpPoolsExtension.java @@ -23,13 +23,13 @@ import com.woorea.openstack.base.client.OpenStackRequest; import com.woorea.openstack.nova.model.FloatingIpPools; public class FloatingIpPoolsExtension { - + private final OpenStackClient CLIENT; - + public FloatingIpPoolsExtension(OpenStackClient client) { CLIENT = client; } - + public List list() { return new List(); } @@ -42,6 +42,6 @@ public class FloatingIpPoolsExtension { } - -} + +} \ No newline at end of file -- cgit 1.2.3-korg