fix sonar bugs in ServicePluginFactory

Fixed potential NullPointerException in lines:
123, 286, 480 and 607 - uuiObject is nullable here

Change-Id: I01b30d090add7faccf3958f2fa37c7905d4bd5a3
Issue-ID: SO-1490
Signed-off-by: k.kazak <k.kazak@samsung.com>

1 files changed, 187 insertions, 0 deletions

diff --git a/bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/workflow/service/ServicePluginFactoryTest.java b/bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/workflow/service/ServicePluginFactoryTest.java
new file mode 100644
index 0000000000..6e22123996
--- /dev/null
+++ b/bpmn/so-bpmn-infrastructure-common/src/test/java/org/onap/so/bpmn/infrastructure/workflow/service/ServicePluginFactoryTest.java
@@ -0,0 +1,187 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * ONAP - SO
+ * ================================================================================
+ * Copyright (C) 2019 Samsung Intellectual Property. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.onap.so.bpmn.infrastructure.workflow.service;
+
+import static org.mockito.Mockito.doReturn;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.Spy;
+import org.mockito.junit.MockitoJUnitRunner;
+import org.onap.so.bpmn.core.domain.ServiceDecomposition;
+
+@RunWith(MockitoJUnitRunner.class)
+public class ServicePluginFactoryTest {
+
+    @Mock
+    ServiceDecomposition serviceDecomposition;
+
+    @Spy
+    ServicePluginFactory servicePluginFactory;
+
+    String uuiRequest = "{"
+        + "    \"service\":{"
+        + "        \"name\":\"ONAP_223531\","
+        + "        \"description\":\"ONAP_1546\","
+        + "        \"serviceInvariantUuid\":\"4a09419a-c9fd-4a53-b1bd-b49603169ca1\","
+        + "        \"serviceUuid\":\"1bd0eae6-2dcc-4461-9ae6-56d641f369d6\","
+        + "        \"globalSubscriberId\":\"test_custormer\","
+        + "        \"serviceType\":\"example-service-type\","
+        + "        \"parameters\":{"
+        + "            \"locationConstraints\":["
+        + "            ],"
+        + "            \"resources\":["
+        + "                {"
+        + "                    \"resourceName\":\"vEPC_ONAP01\","
+        + "                    \"resourceInvariantUuid\":\"36ebe421-283a-4ee8-92f1-d09e7c44b911\","
+        + "                    \"resourceUuid\":\"27a0e235-b67a-4ea4-a0cf-25761afed111\","
+        + "                    \"resourceCustomizationUuid\":\"47a0e235-b67a-4ea4-a0cf-25761afed231\","
+        + "                    \"parameters\":{"
+        + "                        \"locationConstraints\":["
+        + "                            {"
+        + "                                \"vnfProfileId\":\"b244d433-8c9c-49ad-9c70-8e34b8dc8328\","
+        + "                                \"locationConstraints\":{"
+        + "                                    \"vimId\":\"vmware_vio\""
+        + "                                }"
+        + "                            },"
+        + "                            {"
+        + "                                \"vnfProfileId\":\"8a9f7c48-21ce-41b7-95b8-a8ac61ccb1ff\","
+        + "                                \"locationConstraints\":{"
+        + "                                    \"vimId\":\"core-dc_RegionOne\""
+        + "                                }"
+        + "                            }"
+        + "                        ],"
+        + "                        \"resources\":["
+        + "                        ],"
+        + "                        \"requestInputs\":{"
+        + "                            \"sdncontroller\":\"\""
+        + "                        }"
+        + "                    }"
+        + "                },"
+        + "                {"
+        + "                    \"resourceName\":\"VL OVERLAYTUNNEL\","
+        + "                    \"resourceInvariantUuid\":\"184494cf-472f-436f-82e2-d83dddde21cb\","
+        + "                    \"resourceUuid\":\"95bc3e59-c9c5-458f-ad6e-78874ab4b3cc\","
+        + "                    \"resourceCustomizationUuid\":\"27a0e235-b67a-4ea4-a0cf-25761afed232\","
+        + "                    \"parameters\":{"
+        + "                        \"locationConstraints\":["
+        + "                        ],"
+        + "                        \"resources\":["
+        + "                        ],"
+        + "                        \"requestInputs\":{"
+        + "                        }"
+        + "                    }"
+        + "                }"
+        + "            ],"
+        + "            \"requestInputs\":{"
+        + "                \"vlunderlayvpn0_name\":\"l3connect\","
+        + "                \"vlunderlayvpn0_site1_id\":\"IP-WAN-Controller-1\","
+        + "                \"vlunderlayvpn0_site2_id\":\"SPTNController\","
+        + "                \"vlunderlayvpn0_site1_networkName\":\"network1,network2\","
+        + "                \"vlunderlayvpn0_site2_networkName\":\"network3,network4\","
+        + "                \"vlunderlayvpn0_site1_routerId\":\"a8098c1a-f86e-11da-bd1a-00112444be1a\","
+        + "                \"vlunderlayvpn0_site2_routerId\":\"a8098c1a-f86e-11da-bd1a-00112444be1e\","
+        + "                \"vlunderlayvpn0_site2_importRT1\":\"200:1,200:2\","
+        + "                \"vlunderlayvpn0_site1_exportRT1\":\"300:1,300:2\","
+        + "                \"vlunderlayvpn0_site2_exportRT1\":\"400:1,400:2\","
+        + "                \"vlunderlayvpn0_site1_vni\":\"2000\","
+        + "                \"vlunderlayvpn0_site2_vni\":\"3000\","
+        + "                \"vlunderlayvpn0_tunnelType\":\"L3-DCI\","
+        + "                \"CallSource\":\"NOT-ExternalAPI\","
+        + "                \"sotnconnectivity\":\"\""
+        + "            }"
+        + "        }"
+        + "    }"
+        + "}";
+
+
+    @Test
+    public void doProcessSiteLocation_isNeedProcessSite() {
+        String result = servicePluginFactory.doProcessSiteLocation(serviceDecomposition, uuiRequest);
+        Assert.assertEquals(result, uuiRequest);
+    }
+
+    @Test
+    public void doProcessSiteLocation_uuiObjectNull() {
+        String faultyJsonInput = "site_address,sotncondition_clientsignal";
+        String result = servicePluginFactory.doProcessSiteLocation(
+            serviceDecomposition, faultyJsonInput);
+        Assert.assertEquals(result, faultyJsonInput);
+    }
+
+    @Test
+    public void doProcessSiteLocation_isSiteLocationLocal() {
+        String jsonWithOnlyNeededValues = "{\"site_address\":\"\",\"sotncondition_clientsignal\":\"\"}";
+        String result = servicePluginFactory.doProcessSiteLocation(
+            serviceDecomposition, jsonWithOnlyNeededValues);
+        Assert.assertEquals(result, jsonWithOnlyNeededValues);
+    }
+
+
+    @Test
+    public void doTPResourcesAllocation_Success() {
+        doReturn(null).when(servicePluginFactory).getTPsfromAAI();
+        String result = servicePluginFactory.doTPResourcesAllocation(null, uuiRequest);
+        Assert.assertNotEquals(result, uuiRequest);
+    }
+
+    @Test
+    public void doTPResourcesAllocation_uuiObjectNull() {
+        String faultyJsonInput = "site_address,sotncondition_clientsignal";
+        String result = servicePluginFactory.doTPResourcesAllocation(null, faultyJsonInput);
+        Assert.assertEquals(result, faultyJsonInput);
+    }
+
+    @Test
+    public void doTPResourcesAllocation_isNeedAllocateCrossTPResources() {
+        //doReturn(null).when(servicePluginFactory).getTPsfromAAI();
+        String jsonWithOnlyNeededValues = "{\"site_address\":\"\",\"sotncondition_clientsignal\":\"\"}";
+        String result = servicePluginFactory.doTPResourcesAllocation(null, jsonWithOnlyNeededValues);
+        Assert.assertEquals(result, jsonWithOnlyNeededValues);
+    }
+
+    @Test
+    public void preProcessService_isSOTN() {
+        String invalidJsonWithOnlyNeededValues = "\"clientSignal\":\"\",\"vpnType\":\"\"}";
+        String result = servicePluginFactory.preProcessService(null, invalidJsonWithOnlyNeededValues);
+        Assert.assertEquals(result, invalidJsonWithOnlyNeededValues);
+    }
+
+    @Test
+    public void preProcessService() {
+        String result = servicePluginFactory.preProcessService(null, uuiRequest);
+        Assert.assertEquals(result, uuiRequest);
+    }
+
+    @Test
+    public void doServiceHoming() {
+        String result = servicePluginFactory.doServiceHoming(null, uuiRequest);
+        Assert.assertEquals(result, uuiRequest);
+    }
+
+    @Test
+    public void doServiceHoming_isSOTN() {
+        String invalidJsonWithOnlyNeededValues = "\"clientSignal\":\"\",\"vpnType\":\"\"}";
+        String result = servicePluginFactory.doServiceHoming(null, invalidJsonWithOnlyNeededValues);
+        Assert.assertEquals(result, invalidJsonWithOnlyNeededValues);
+    }
+}