From 7894d15ee8d0094ae36c838f1e961fa60f42843b Mon Sep 17 00:00:00 2001 From: "prakash.e" Date: Wed, 7 Aug 2019 18:33:30 +0530 Subject: Added test case to increase SONAR coverage Added new case for delete flow in ServiceTopologyOperationRPCTest Change-Id: Ic793c6ae1d67420f84445704952e8034c1df715b Issue-ID: SDNC-840 Signed-off-by: Prakash.E --- .../ServiceTopologyOperationRPCTest.java | 79 ++++++++++++++++++++++ 1 file changed, 79 insertions(+) diff --git a/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/ServiceTopologyOperationRPCTest.java b/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/ServiceTopologyOperationRPCTest.java index faacd220..bbd0afdf 100644 --- a/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/ServiceTopologyOperationRPCTest.java +++ b/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/ServiceTopologyOperationRPCTest.java @@ -163,6 +163,49 @@ public class ServiceTopologyOperationRPCTest extends GenericResourceApiProviderT assertEquals("Y", output.getAckFinalIndicator()); } + @Test + public void delete_fail_when_client_execution_failed() throws Exception { + + //mock svcClient to perform a successful execution with the expected parameters + svcClient.mockHasGraph(true); + PropBuilder svcResultProp = svcClient.createExecuteOKResult(); + svcClient.mockExecute(svcResultProp); + + ServiceTopologyOperationInput input = deleteSTOI(); + + //execute the mdsal exec + ServiceTopologyOperationOutput output = exec( + genericResourceApiProvider::serviceTopologyOperation + , input + , RpcResult::getResult + ); + + assertEquals("200", output.getResponseCode()); + assertEquals("OK", output.getResponseMessage()); + assertEquals("Y", output.getAckFinalIndicator()); + } + + @Test + public void delete_service_fail_when_client_execution_failed() throws Exception { + + //mock svcClient to perform a successful execution with the expected parameters + svcClient.mockHasGraph(true); + PropBuilder svcResultProp = svcClient.createExecuteOKResult(); + svcClient.mockExecute(svcResultProp); + + ServiceTopologyOperationInput input = deleteServiceSTOI(); + + //execute the mdsal exec + ServiceTopologyOperationOutput output = exec( + genericResourceApiProvider::serviceTopologyOperation + , input + , RpcResult::getResult + ); + + assertEquals("500", output.getResponseCode()); + assertEquals("Y", output.getAckFinalIndicator()); + } + @Test public void should_fail_when_client_has_no_graph() throws Exception { svcClient.mockHasGraph(false); @@ -225,6 +268,42 @@ public class ServiceTopologyOperationRPCTest extends GenericResourceApiProviderT ); } + private ServiceTopologyOperationInput deleteSTOI() { + + return build( + serviceTopologyOperationInput() + .setSdncRequestHeader(build(sdncRequestHeader() + .setSvcRequestId("svc-request-id: xyz") + .setSvcAction(SvcAction.Unassign) + )) + .setRequestInformation(build(requestInformation() + .setRequestId("request-id: xyz") + .setRequestAction(RequestInformation.RequestAction.DeleteServiceInstance) + )) + .setServiceInformation(build(serviceInformationBuilder() + .setServiceInstanceId("service-instance-id: xyz") + )) + ); + } + + private ServiceTopologyOperationInput deleteServiceSTOI() { + + return build( + serviceTopologyOperationInput() + .setSdncRequestHeader(build(sdncRequestHeader() + .setSvcRequestId("svc-request-id: xyz") + .setSvcAction(SvcAction.Delete) + )) + .setRequestInformation(build(requestInformation() + .setRequestId("request-id: xyz") + .setRequestAction(RequestInformation.RequestAction.DeleteServiceInstance) + )) + .setServiceInformation(build(serviceInformationBuilder() + .setServiceInstanceId("service-instance-id: xyz") + )) + ); + } + private ServiceTopologyOperationOutput createExpectedSTOO(PropBuilder expectedSvcResultProp, ServiceTopologyOperationInput expectedServiceTopologyOperationInput) { -- cgit 1.2.3-korg