From e69f794b32db291ace90ac7934e7938bc79d815e Mon Sep 17 00:00:00 2001 From: Kevin Smokowski Date: Wed, 24 May 2017 14:27:29 +0000 Subject: remove a potential NPE in a logging line Change-Id: I75c94543087471d454eb5076eb03cad7dc9d376c Signed-off-by: Kevin Smokowski --- .../sdnc/sli/provider/CallNodeExecutor.java | 23 ++++++++++------------ 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/sli/provider/src/main/java/org/openecomp/sdnc/sli/provider/CallNodeExecutor.java b/sli/provider/src/main/java/org/openecomp/sdnc/sli/provider/CallNodeExecutor.java index da0bc56..b6fa374 100644 --- a/sli/provider/src/main/java/org/openecomp/sdnc/sli/provider/CallNodeExecutor.java +++ b/sli/provider/src/main/java/org/openecomp/sdnc/sli/provider/CallNodeExecutor.java @@ -120,21 +120,18 @@ public class CallNodeExecutor extends SvcLogicNodeExecutor { SvcLogicStore store = SvcLogicActivator.getStore(); if (store != null) { - SvcLogicGraph calledGraph = store.fetch(module, rpc, version, mode); - LOG.debug("Parent " + parentGraph + " is calling child " + calledGraph.toString()); - ctx.setAttribute("currentGraph", calledGraph.toString()); + SvcLogicGraph calledGraph = store.fetch(module, rpc, version, mode); if (calledGraph != null) { - svc.execute(calledGraph, ctx); - - outValue = ctx.getStatus(); + LOG.debug("Parent " + parentGraph + " is calling child " + calledGraph.toString()); + svc.execute(calledGraph, ctx); + ctx.setAttribute("currentGraph", calledGraph.toString()); + outValue = ctx.getStatus(); } else { - LOG.error("Could not find service logic for [" + module + "," + rpc + "," + version + "," + mode + "]"); - } - } - else - { - LOG.debug("Could not get SvcLogicStore reference"); - } + LOG.debug("Parent " + parentGraph + " failed to call child [" + module + "," + rpc + "," + version + "," + mode + "] because the graph could not be found"); + } + } else { + LOG.debug("Could not get SvcLogicStore reference"); + } SvcLogicNode nextNode = node.getOutcomeValue(outValue); if (nextNode != null) { -- cgit 1.2.3-korg