From 6f2998eda89b638ac1bf94c8c1b7f54da70639f2 Mon Sep 17 00:00:00 2001 From: Marcus G K Williams Date: Mon, 1 May 2017 16:28:50 -0700 Subject: AbstractResourceManagerFactory Clean Code Hygiene Change-Id: I0f10520e86b692ee244a80bbc0047fe220b044f9 Signed-off-by: Marcus G K Williams --- .../dblib/factory/AbstractResourceManagerFactory.java | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/dblib/provider/src/main/java/org/openecomp/sdnc/sli/resource/dblib/factory/AbstractResourceManagerFactory.java b/dblib/provider/src/main/java/org/openecomp/sdnc/sli/resource/dblib/factory/AbstractResourceManagerFactory.java index 29ec061..0f58a3f 100644 --- a/dblib/provider/src/main/java/org/openecomp/sdnc/sli/resource/dblib/factory/AbstractResourceManagerFactory.java +++ b/dblib/provider/src/main/java/org/openecomp/sdnc/sli/resource/dblib/factory/AbstractResourceManagerFactory.java @@ -69,9 +69,9 @@ public abstract class AbstractResourceManagerFactory { ds = CachedDataSourceFactory.createDataSource(config); return ds; } finally { - synchronized(activeTasks){ + synchronized(activeTasks) { activeTasks.remove(this); - if(activeTasks.isEmpty()){ + if (activeTasks.isEmpty()) { final Runnable closure = new Runnable() { public void run() { @@ -79,20 +79,23 @@ public abstract class AbstractResourceManagerFactory { Thread.sleep(300); } catch (Exception e) { } - synchronized(activeTasks){ + synchronized(activeTasks) { activeTasks.notifyAll(); } } }; - if(LOGGER.isDebugEnabled()) - LOGGER.debug("Completed CachedDataSource.Call and notifyAll from "+ds.getDbConnectionName()); + if (LOGGER.isDebugEnabled()) { + LOGGER.debug("Completed CachedDataSource.Call and notifyAll from " + ds.getDbConnectionName()); + } Thread worker = new Thread(closure); worker.setDaemon(true); worker.start(); } else { - if(LOGGER.isDebugEnabled()) - if(ds != null) - LOGGER.debug("Completed CachedDataSource.Call from "+ds.getDbConnectionName()); + if (LOGGER.isDebugEnabled()) { + if (ds != null) { + LOGGER.debug("Completed CachedDataSource.Call from " + ds.getDbConnectionName()); + } + } } } } -- cgit 1.2.3-korg