From cf070aeaadd055f38dd32a6121c42f6b10a6937b Mon Sep 17 00:00:00 2001 From: "m.kowalski3" Date: Wed, 26 Jun 2019 13:01:30 +0200 Subject: Add unit tests for: -DeploymentFlavorErrorBuilder -DuplicateComputeInComponentErrorBuilder -FileCreationErrorBuilder -ImageErrorBuilder Issue-ID: SDC-2327 Signed-off-by: Marcin Kowalski Change-Id: I0af9da852bb953e93f6e4383725c1c56944d8f33 --- .../errors/DeploymentFlavorErrorBuilderTest.java | 78 ++++++++++++++++++++++ ...uplicateComputeInComponentErrorBuilderTest.java | 42 ++++++++++++ .../errors/FileCreationErrorBuilderTest.java | 43 ++++++++++++ .../errors/ImageErrorBuilderTest.java | 54 +++++++++++++++ 4 files changed, 217 insertions(+) create mode 100644 openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DeploymentFlavorErrorBuilderTest.java create mode 100644 openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DuplicateComputeInComponentErrorBuilderTest.java create mode 100644 openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/FileCreationErrorBuilderTest.java create mode 100644 openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/ImageErrorBuilderTest.java (limited to 'openecomp-be') diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DeploymentFlavorErrorBuilderTest.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DeploymentFlavorErrorBuilderTest.java new file mode 100644 index 0000000000..4291c93245 --- /dev/null +++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DeploymentFlavorErrorBuilderTest.java @@ -0,0 +1,78 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Samsung. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.vendorsoftwareproduct.errors; + +import static org.junit.Assert.assertEquals; + +import org.junit.Test; +import org.openecomp.sdc.common.errors.ErrorCategory; +import org.openecomp.sdc.common.errors.ErrorCode; + +public class DeploymentFlavorErrorBuilderTest { + + @Test + public void testGetInvalidComponentIdErrorBuilder() { + //when + ErrorCode errorCode = DeploymentFlavorErrorBuilder.getInvalidComponentIdErrorBuilder(); + + //then + assertEquals(VendorSoftwareProductErrorCodes.INVALID_COMPONENT_ID, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals("Invalid request, Component provided does not exist for this VSP.", errorCode.message()); + } + + @Test + public void testGetInvalidComponentComputeAssociationErrorBuilder() { + //when + ErrorCode errorCode = DeploymentFlavorErrorBuilder.getInvalidComponentComputeAssociationErrorBuilder(""); + + //then + assertEquals(VendorSoftwareProductErrorCodes.INVALID_COMPONENT_COMPUTE_ASSOCIATION, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals( + "VSP cannot be submitted with an invalid Deployment Flavor. All Deployment Flavor should have atleast a VFC included with it's required Compute needs. " + + "Please fix the Deployment Flavor and re-submit the VSP.", errorCode.message()); + } + + @Test + public void testGetFeatureGroupMandatoryErrorBuilder() { + //when + ErrorCode errorCode = DeploymentFlavorErrorBuilder.getFeatureGroupMandatoryErrorBuilder(""); + + //then + assertEquals(VendorSoftwareProductErrorCodes.FEATUREGROUP_REQUIRED_IN_DEPLOYMENT_FLAVOR, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals("VSP cannot be submitted with an invalid Deployment Flavor. All Deployment Flavor should have " + + "FeatureGroup. Please fix the Deployment Flavor and re-submit the VSP.", + errorCode.message()); + } + + @Test + public void testGetDeploymentFlavorNameFormatErrorBuilder() { + //when + ErrorCode errorCode = DeploymentFlavorErrorBuilder.getDeploymentFlavorNameFormatErrorBuilder(""); + + //then + assertEquals(VendorSoftwareProductErrorCodes.DEPLOYMENT_FLAVOR_NAME_FORMAT_NOT_ALLOWED, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals("Field does not conform to predefined criteria: name : must match ", errorCode.message()); + } +} diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DuplicateComputeInComponentErrorBuilderTest.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DuplicateComputeInComponentErrorBuilderTest.java new file mode 100644 index 0000000000..2f833ef444 --- /dev/null +++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/DuplicateComputeInComponentErrorBuilderTest.java @@ -0,0 +1,42 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Samsung. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.vendorsoftwareproduct.errors; + +import static org.junit.Assert.assertEquals; + +import org.junit.Test; +import org.openecomp.sdc.common.errors.ErrorCategory; +import org.openecomp.sdc.common.errors.ErrorCode; + +public class DuplicateComputeInComponentErrorBuilderTest { + + @Test + public void testGetComputeHeatReadOnlyErrorBuilder() { + //when + ErrorCode errorCode = DuplicateComputeInComponentErrorBuilder.getComputeHeatReadOnlyErrorBuilder(""); + + //then + assertEquals(VendorSoftwareProductErrorCodes.UPDATE_COMPUTE_NOT_ALLOWED, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals("Update of attribute not allowed for VSP onboarded via HEAT.", errorCode.message()); + + } +} diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/FileCreationErrorBuilderTest.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/FileCreationErrorBuilderTest.java new file mode 100644 index 0000000000..21a33760f9 --- /dev/null +++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/FileCreationErrorBuilderTest.java @@ -0,0 +1,43 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Samsung. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.vendorsoftwareproduct.errors; + +import static org.junit.Assert.assertEquals; + +import org.junit.Test; +import org.openecomp.sdc.common.errors.ErrorCategory; +import org.openecomp.sdc.common.errors.ErrorCode; + +public class FileCreationErrorBuilderTest { + + @Test + public void testBuild() { + //when + ErrorCode errorCode = new FileCreationErrorBuilder("").build(); + + //then + assertEquals(VendorSoftwareProductErrorCodes.HEAT_PACKAGE_FILE_CREATION, errorCode.id()); + assertEquals(ErrorCategory.SYSTEM, errorCode.category()); + assertEquals("Error while trying to create heat file from the package of vendor software product with Id .", + errorCode.message()); + + } +} diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/ImageErrorBuilderTest.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/ImageErrorBuilderTest.java new file mode 100644 index 0000000000..eae81ed05e --- /dev/null +++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/test/java/org/openecomp/sdc/vendorsoftwareproduct/errors/ImageErrorBuilderTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Samsung. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.vendorsoftwareproduct.errors; + +import static org.junit.Assert.assertEquals; + +import org.junit.Test; +import org.openecomp.sdc.common.errors.ErrorCategory; +import org.openecomp.sdc.common.errors.ErrorCode; + +public class ImageErrorBuilderTest { + + @Test + public void testGetDuplicateImageNameErrorBuilder() { + //when + ErrorCode errorCode = ImageErrorBuilder.getDuplicateImageNameErrorBuilder("1", "1"); + + //then + assertEquals(VendorSoftwareProductErrorCodes.DUPLICATE_IMAGE_NAME_NOT_ALLOWED, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals("Invalid request, Image with name 1 already exists for component with ID 1.", errorCode.message()); + + } + + @Test + public void testGetImageNameFormatErrorBuilder() { + //when + ErrorCode errorCode = ImageErrorBuilder.getImageNameFormatErrorBuilder("1"); + + //then + assertEquals(VendorSoftwareProductErrorCodes.IMAGE_NAME_FORMAT_NOT_ALLOWED, errorCode.id()); + assertEquals(ErrorCategory.APPLICATION, errorCode.category()); + assertEquals("Field does not conform to predefined criteria: name : must match 1", errorCode.message()); + + } +} -- cgit 1.2.3-korg