From 57a8c14ed7b5ef6b39b7e63e76d14dfcac32fb69 Mon Sep 17 00:00:00 2001 From: aribeiro Date: Fri, 8 Nov 2019 10:53:56 +0000 Subject: Fix sonarQube issue. Issue-ID: SDC-2646 Change-Id: Ic426e1cccf50e3db40381896ee50b74e647129ee Signed-off-by: aribeiro --- .../converter/impl/pnfd/PnfdNodeTemplateTransformationEngine.java | 3 +++ .../core/converter/impl/pnfd/parser/TransformationYamlParser.java | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) (limited to 'openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org') diff --git a/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/PnfdNodeTemplateTransformationEngine.java b/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/PnfdNodeTemplateTransformationEngine.java index b2038a00dd..3c996462fe 100644 --- a/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/PnfdNodeTemplateTransformationEngine.java +++ b/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/PnfdNodeTemplateTransformationEngine.java @@ -81,6 +81,9 @@ public class PnfdNodeTemplateTransformationEngine extends AbstractPnfdTransforma */ @Override protected void executeTransformations() { + if (transformationDescription == null) { + return; + } final Set transformationSet = transformationDescription.getTransformationSet(); if (CollectionUtils.isEmpty(transformationSet)) { return; diff --git a/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/parser/TransformationYamlParser.java b/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/parser/TransformationYamlParser.java index 6ad04b0f7a..92e1d8f392 100644 --- a/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/parser/TransformationYamlParser.java +++ b/openecomp-be/lib/openecomp-tosca-converter-lib/openecomp-tosca-converter-core/src/main/java/org/openecomp/core/converter/impl/pnfd/parser/TransformationYamlParser.java @@ -181,8 +181,9 @@ public class TransformationYamlParser { private static Optional parseStringAttribute(final String attribute, final Map transformationYaml) { try { return Optional.of((String) transformationYaml.get(attribute)); - } catch (final Exception ignore) { - LOGGER.warn("Could not parse the String '{}' in transformation '{}'", attribute, transformationYaml.toString()); + } catch (final Exception e) { + LOGGER.warn("Could not parse the String '{}' in transformation '{}'", + attribute, transformationYaml.toString(), e); return Optional.empty(); } } -- cgit 1.2.3-korg