From 5eb00848f99758f1cb05a7336824d4963c5468c3 Mon Sep 17 00:00:00 2001 From: mojahidi Date: Wed, 27 Dec 2017 15:58:32 +0530 Subject: Fixed sonar issues - OrchestrationUploadFactory Fixed all sonar issues except exception handling Change-Id: I694a37df40ef05a6217d2f6db41cd7b15ba1e10e Issue-ID: SDC-343 Signed-off-by: mojahidi --- .../orchestration/OrchestrationUploadFactory.java | 26 ++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) (limited to 'openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org') diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/impl/orchestration/OrchestrationUploadFactory.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/impl/orchestration/OrchestrationUploadFactory.java index 3c3ab81e10..52913c9f82 100644 --- a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/impl/orchestration/OrchestrationUploadFactory.java +++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/impl/orchestration/OrchestrationUploadFactory.java @@ -1,3 +1,19 @@ +/* + * Copyright © 2016-2017 European Support Limited + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package org.openecomp.sdc.vendorsoftwareproduct.impl.orchestration; import org.openecomp.config.api.Configuration; @@ -15,18 +31,20 @@ import static org.openecomp.sdc.vendorsoftwareproduct.impl.orchestration.Orchest import static org.openecomp.sdc.vendorsoftwareproduct.impl.orchestration.OrchestrationUtil.ORCHESTRATION_IMPL_KEY; public class OrchestrationUploadFactory { - private static Map fileHanlders; + private static final Map FILE_HANLDERS; + private OrchestrationUploadFactory() { + } static { Configuration config = ConfigurationManager.lookup(); - fileHanlders = new ConcurrentHashMap<>(config.populateMap(ORCHESTRATION_CONFIG_NAMESPACE, + FILE_HANLDERS = new ConcurrentHashMap<>(config.populateMap(ORCHESTRATION_CONFIG_NAMESPACE, ORCHESTRATION_IMPL_KEY, ImplementationConfiguration.class)); } - public static final OrchestrationTemplateFileHandler createOrchestrationTemplateFileHandler(String fileSuffix) { + public static OrchestrationTemplateFileHandler createOrchestrationTemplateFileHandler(String fileSuffix) { String fileExtension = fileSuffix.toLowerCase(); - ImplementationConfiguration orchestrationTemplateFileHandler = fileHanlders.get(fileExtension); + ImplementationConfiguration orchestrationTemplateFileHandler = FILE_HANLDERS.get(fileExtension); if(Objects.isNull(orchestrationTemplateFileHandler)){ throw new CoreException(new OrchestrationTemplateFileExtensionErrorBuilder -- cgit 1.2.3-korg