From 79ba4fbed10cabac5c32ba91e57fa55253005c37 Mon Sep 17 00:00:00 2001 From: ojasdubey Date: Wed, 12 Sep 2018 17:09:23 +0530 Subject: Bugfix - Action mandatory param validation Fix for actions getting created without passing mandatory parameters Change-Id: I3e332d92d0ad99b85d945ab25d7406e916642314 Issue-ID: SDC-1755 Signed-off-by: ojasdubey --- .../org/openecomp/sdcrests/action/rest/services/ActionsImpl.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'openecomp-be/api') diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java b/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java index 23f11843b8..2927a7fdd3 100644 --- a/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java +++ b/openecomp-be/api/openecomp-sdc-rest-webapp/action-library-rest/action-library-rest-services/src/main/java/org/openecomp/sdcrests/action/rest/services/ActionsImpl.java @@ -97,7 +97,6 @@ import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; import java.util.ArrayList; -import java.util.HashMap; import java.util.LinkedHashMap; import java.util.List; import java.util.Map; @@ -1040,10 +1039,8 @@ public class ActionsImpl implements Actions { if (StringUtils.isEmpty(requestJSON) || requestJSON.equals(REQUEST_EMPTY_BODY)) { requestBodyErrorMap.put(ACTION_INVALID_REQUEST_BODY_CODE, ACTION_REQUEST_BODY_EMPTY); } else { - if(requestType == ActionConstants.REQUEST_TYPE_CREATE_ACTION){ - //placeholder for future implementation - } - if(requestType == ActionConstants.REQUEST_TYPE_UPDATE_ACTION){ + if(requestType == ActionConstants.REQUEST_TYPE_CREATE_ACTION + || requestType == ActionConstants.REQUEST_TYPE_UPDATE_ACTION){ //Semantic request specific validations Action action = JsonUtil.json2Object(requestJSON, Action.class); if(StringUtils.isEmpty(action.getName())){ -- cgit 1.2.3-korg