From 7962fe55692954548da260f31528dfc434f17755 Mon Sep 17 00:00:00 2001 From: Bartosz Gardziejewski Date: Tue, 20 Aug 2019 15:53:19 +0200 Subject: increasing test coverage in openecomp-be api Issue-ID: SDC-2326 Signed-off-by: Bartosz Gardziejewski Change-Id: I93cc5183190fcbada2349b18f14fbec9c28f1ae5 --- .../application-config-rest-services/pom.xml | 5 + .../services/ApplicationConfigurationImplTest.java | 123 +++++++++++++++++++++ 2 files changed, 128 insertions(+) create mode 100644 openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/src/test/java/org/openecomp/sdcrests/applicationconfig/rest/services/ApplicationConfigurationImplTest.java (limited to 'openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services') diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/pom.xml b/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/pom.xml index 034f87e513..b1adca25f6 100644 --- a/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/pom.xml +++ b/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/pom.xml @@ -60,6 +60,11 @@ junit test + + org.springframework + spring-web + test + diff --git a/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/src/test/java/org/openecomp/sdcrests/applicationconfig/rest/services/ApplicationConfigurationImplTest.java b/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/src/test/java/org/openecomp/sdcrests/applicationconfig/rest/services/ApplicationConfigurationImplTest.java new file mode 100644 index 0000000000..43ebeab9e5 --- /dev/null +++ b/openecomp-be/api/openecomp-sdc-rest-webapp/application-config-rest/application-config-rest-services/src/test/java/org/openecomp/sdcrests/applicationconfig/rest/services/ApplicationConfigurationImplTest.java @@ -0,0 +1,123 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdcrests.applicationconfig.rest.services; + +import org.junit.Before; +import org.junit.Test; +import org.mockito.Mock; +import org.openecomp.core.utilities.applicationconfig.dao.type.ApplicationConfigEntity; +import org.openecomp.core.utilities.applicationconfig.type.ConfigurationData; +import org.openecomp.sdc.applicationconfig.ApplicationConfigManager; +import org.openecomp.sdcrests.applicationconfiguration.types.ApplicationConfigDto; +import org.openecomp.sdcrests.applicationconfiguration.types.ConfigurationDataDto; +import org.openecomp.sdcrests.wrappers.GenericCollectionWrapper; +import org.springframework.http.HttpStatus; + +import javax.ws.rs.core.Response; +import java.io.ByteArrayInputStream; +import java.io.InputStream; +import java.util.ArrayList; + +import static org.junit.Assert.assertEquals; +import static org.mockito.ArgumentMatchers.eq; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; +import static org.mockito.MockitoAnnotations.initMocks; + +public class ApplicationConfigurationImplTest { + + + private ApplicationConfigurationImpl applicationConfiguration; + + @Mock + ApplicationConfigManager applicationConfigManager; + + @Before + public void setUp() { + initMocks(this); + applicationConfiguration = new ApplicationConfigurationImpl(applicationConfigManager); + } + + @Test + public void validateInsertInToTableCallsManagerFunctionWithValidParameters() { + + final String testNamespace = "namespace"; + final String testKey = "key"; + final String testValue = "testingValue"; + final InputStream testInput = new ByteArrayInputStream(testValue.getBytes()); + + Response response = applicationConfiguration.insertToTable(testNamespace, testKey, testInput); + + assertEquals(response.getStatus(), HttpStatus.OK.value()); + verify(applicationConfigManager).insertIntoTable(eq(testNamespace),eq(testKey),eq(testValue)); + } + + @Test + public void validateGetFromTableReturnsValidObject() { + + final String testNamespace = "namespace"; + final String testKey = "key"; + final ConfigurationData testValue = new ConfigurationData("testValue", 111); + + when(applicationConfigManager.getFromTable(eq(testNamespace),eq(testKey))).thenReturn(testValue); + + Response response = applicationConfiguration.getFromTable(testNamespace, testKey); + + assertEquals(response.getEntity().getClass(), ConfigurationDataDto.class); + assertEquals(((ConfigurationDataDto)response.getEntity()).getValue(),testValue.getValue()); + } + + + @Test + public void validateGetListOfConfigurationByNamespaceFromTableReturnsValidList() { + + final String testNamespace = "namespace"; + final ArrayList testApplicationConfigEntities = new ArrayList<>(); + final ApplicationConfigEntity testConfigEntity01 = new ApplicationConfigEntity(); + final String testValue01 = "testValue01"; + final ApplicationConfigEntity testConfigEntity02 = new ApplicationConfigEntity(); + final String testValue02 = "testValue02"; + testConfigEntity01.setValue(testValue01); + testConfigEntity02.setValue(testValue02); + testApplicationConfigEntities.add(testConfigEntity01); + testApplicationConfigEntities.add(testConfigEntity02); + + when(applicationConfigManager.getListOfConfigurationByNamespace(eq(testNamespace))) + .thenReturn(testApplicationConfigEntities); + + Response response = applicationConfiguration.getListOfConfigurationByNamespaceFromTable(testNamespace); + + assertEquals(response.getEntity().getClass(), GenericCollectionWrapper.class); + assertEquals( + ((GenericCollectionWrapper)response.getEntity()).getResults().size(), + testApplicationConfigEntities.size() + ); + assertEquals( + ((ApplicationConfigDto)response.readEntity(GenericCollectionWrapper.class).getResults().get(0)).getValue(), + testApplicationConfigEntities.get(0).getValue() + ); + assertEquals( + ((ApplicationConfigDto)response.readEntity(GenericCollectionWrapper.class).getResults().get(1)).getValue(), + testApplicationConfigEntities.get(1).getValue() + ); + } + +} -- cgit 1.2.3-korg