From baf7f0a965d0ffebd5308d44758bfa9ba96c0c76 Mon Sep 17 00:00:00 2001 From: koblosz Date: Mon, 9 Jul 2018 13:42:31 +0200 Subject: Fixes of sonar violations sdc and refactor Issue-ID: SDC-1484 Change-Id: I3cf17454c533d3419c97af63cc6b5412976726fb Signed-off-by: Sandra Koblosz --- .../onap/config/type/NonConfigResourceTest.java | 82 ++++++++++++++++++++++ 1 file changed, 82 insertions(+) create mode 100644 common/onap-common-configuration-management/onap-configuration-management-core/src/test/java/org/onap/config/type/NonConfigResourceTest.java (limited to 'common/onap-common-configuration-management/onap-configuration-management-core/src/test/java') diff --git a/common/onap-common-configuration-management/onap-configuration-management-core/src/test/java/org/onap/config/type/NonConfigResourceTest.java b/common/onap-common-configuration-management/onap-configuration-management-core/src/test/java/org/onap/config/type/NonConfigResourceTest.java new file mode 100644 index 0000000000..0671996fb5 --- /dev/null +++ b/common/onap-common-configuration-management/onap-configuration-management-core/src/test/java/org/onap/config/type/NonConfigResourceTest.java @@ -0,0 +1,82 @@ +package org.onap.config.type; + +import com.google.common.collect.ImmutableMap; +import org.junit.Test; +import org.onap.config.NonConfigResource; + +import java.io.File; +import java.net.MalformedURLException; +import java.net.URISyntaxException; +import java.net.URL; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.util.Map; + +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + +public class NonConfigResourceTest { + + private final URL sampleUrlResource = NonConfigResourceTest.class.getResource("NonConfigResourceTest.class"); + private final String sampleResourcePath = sampleUrlResource.getPath(); + private final File sampleResourceFile = new File(sampleResourcePath); + + @Test + public void testShouldLocateResourceWhenAbsPathProvided2() { + Map properties = ImmutableMap.of(); + Path actualResourcePath = NonConfigResource.create(properties::get).locate(sampleResourceFile.toString()); + + assertTrue(actualResourcePath.compareTo(sampleResourceFile.toPath()) == 0); + } + + @Test + public void testShouldLocateResourceWhenPresentInFiles2() { + Map properties = ImmutableMap.of(); + NonConfigResource testedObject = NonConfigResource.create(properties::get); + testedObject.add(sampleResourceFile); + + Path thisFilePath = testedObject.locate("NonConfigResourceTest.class"); + + assertTrue(thisFilePath.compareTo(sampleResourceFile.toPath()) == 0); + } + + @Test + public void testShouldLocateResourceWhenNodeConfigPropertyIsSet2() throws URISyntaxException, MalformedURLException { + Map properties = ImmutableMap.of("node.config.location", new File(sampleResourcePath).getParentFile().getPath()); + NonConfigResource testedNonConfigResource = NonConfigResource.create(properties::get); + System.getProperties().setProperty("node.config.location", new File(sampleResourcePath).getParentFile().getPath()); + Path thisFilePath = testedNonConfigResource.locate("NonConfigResourceTest.class"); + + assertTrue(thisFilePath.compareTo(new File(sampleResourcePath).toPath()) == 0); + } + + @Test + public void testShouldLocateResourceWhenConfigPropertyIsSet2() { + Map properties = ImmutableMap.of("config.location", new File(sampleResourcePath).getParentFile().getPath()); + NonConfigResource testedNonConfigResource = NonConfigResource.create(properties::get); + Path thisFilePath = testedNonConfigResource.locate("NonConfigResourceTest.class"); + + assertTrue(thisFilePath.compareTo(new File(sampleResourcePath).toPath()) == 0); + } + + @Test + public void testShouldLocatePathWhenResourcePresentInUrls2() throws URISyntaxException { + Map properties = ImmutableMap.of(); + NonConfigResource testedObject = NonConfigResource.create(properties::get); + testedObject.add(sampleUrlResource); + + Path thisFilePath = testedObject.locate("NonConfigResourceTest.class"); + + assertTrue(thisFilePath.compareTo(Paths.get(sampleUrlResource.toURI())) == 0); + } + + @Test + public void testShouldNotLocateResource2() throws URISyntaxException { + Map properties = ImmutableMap.of(); + NonConfigResource testedObject = NonConfigResource.create(properties::get); + + Path thisFilePath = testedObject.locate("nonexistingresource"); + + assertNull(thisFilePath); + } +} -- cgit 1.2.3-korg