From f845ac23cdd262b7624785283531952e38557deb Mon Sep 17 00:00:00 2001 From: vasraz Date: Wed, 14 Jun 2023 20:56:59 +0100 Subject: Improve test coverage Signed-off-by: Vasyl Razinkov Change-Id: Ib5c265567973369a9061ce611ab018857016bff1 Issue-ID: SDC-4536 --- .../openecomp/sdc/common/api/HealthCheckInfo.java | 74 +++------------ .../sdc/common/api/HealthCheckInfoTest.java | 101 +++------------------ 2 files changed, 25 insertions(+), 150 deletions(-) (limited to 'common-app-api/src') diff --git a/common-app-api/src/main/java/org/openecomp/sdc/common/api/HealthCheckInfo.java b/common-app-api/src/main/java/org/openecomp/sdc/common/api/HealthCheckInfo.java index 361701a9d7..009e532174 100644 --- a/common-app-api/src/main/java/org/openecomp/sdc/common/api/HealthCheckInfo.java +++ b/common-app-api/src/main/java/org/openecomp/sdc/common/api/HealthCheckInfo.java @@ -20,7 +20,17 @@ package org.openecomp.sdc.common.api; import java.util.List; - +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.NoArgsConstructor; +import lombok.Setter; +import lombok.ToString; + +@AllArgsConstructor +@NoArgsConstructor +@Getter +@Setter +@ToString public class HealthCheckInfo { private String healthCheckComponent; @@ -37,65 +47,5 @@ public class HealthCheckInfo { this.description = description; } - public HealthCheckInfo(String healthCheckComponent, HealthCheckStatus healthCheckStatus, String version, String description, - List componentsInfo) { - super(); - this.healthCheckComponent = healthCheckComponent; - this.healthCheckStatus = healthCheckStatus; - this.version = version; - this.description = description; - this.componentsInfo = componentsInfo; - } - - public HealthCheckInfo() { - super(); - } - - public String getHealthCheckComponent() { - return healthCheckComponent; - } - - public void setHealthCheckComponent(String healthCheckComponent) { - this.healthCheckComponent = healthCheckComponent; - } - - public HealthCheckStatus getHealthCheckStatus() { - return healthCheckStatus; - } - - public void setHealthCheckStatus(HealthCheckStatus healthCheckStatus) { - this.healthCheckStatus = healthCheckStatus; - } - - public List getComponentsInfo() { - return componentsInfo; - } - - public void setComponentsInfo(List componentsInfo) { - this.componentsInfo = componentsInfo; - } - - public String getVersion() { - return version; - } - - public void setVersion(String version) { - this.version = version; - } - - public String getDescription() { - return description; - } - - public void setDescription(String description) { - this.description = description; - } - - @Override - public String toString() { - return "HealthCheckInfo [healthCheckComponent=" + healthCheckComponent + ", healthCheckStatus=" + healthCheckStatus + ", version=" + version - + ", description=" + description + ", componentsInfo=" + componentsInfo + "]"; - } - - public enum HealthCheckStatus {UP, DOWN, UNKNOWN;} + public enum HealthCheckStatus {UP, DOWN, UNKNOWN} } diff --git a/common-app-api/src/test/java/org/openecomp/sdc/common/api/HealthCheckInfoTest.java b/common-app-api/src/test/java/org/openecomp/sdc/common/api/HealthCheckInfoTest.java index 9e0757d4de..2c8e3cb80d 100644 --- a/common-app-api/src/test/java/org/openecomp/sdc/common/api/HealthCheckInfoTest.java +++ b/common-app-api/src/test/java/org/openecomp/sdc/common/api/HealthCheckInfoTest.java @@ -7,9 +7,9 @@ * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at - * + * * http://www.apache.org/licenses/LICENSE-2.0 - * + * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. @@ -20,95 +20,20 @@ package org.openecomp.sdc.common.api; -import org.junit.Test; -import org.openecomp.sdc.common.api.HealthCheckInfo.HealthCheckStatus; - -import java.util.List; - -public class HealthCheckInfoTest { - - private HealthCheckInfo createTestSubject() { - return new HealthCheckInfo("", HealthCheckStatus.UP, "", ""); - } - - @Test - public void testGetHealthCheckComponent() throws Exception { - HealthCheckInfo testSubject; - String result; - - // default test - testSubject = createTestSubject(); - result = testSubject.getHealthCheckComponent(); - } - - @Test - public void testGetHealthCheckStatus() throws Exception { - HealthCheckInfo testSubject; - HealthCheckStatus result; - - // default test - testSubject = createTestSubject(); - result = testSubject.getHealthCheckStatus(); - } - - @Test - public void testGetComponentsInfo() throws Exception { - HealthCheckInfo testSubject; - List result; +import static org.junit.jupiter.api.Assertions.assertNotNull; - // default test - testSubject = createTestSubject(); - result = testSubject.getComponentsInfo(); - } - - @Test - public void testSetComponentsInfo() throws Exception { - HealthCheckInfo testSubject; - List componentsInfo = null; - - // default test - testSubject = createTestSubject(); - testSubject.setComponentsInfo(componentsInfo); - } - - @Test - public void testGetVersion() throws Exception { - HealthCheckInfo testSubject; - String result; - - // default test - testSubject = createTestSubject(); - result = testSubject.getVersion(); - } - - @Test - public void testSetVersion() throws Exception { - HealthCheckInfo testSubject; - String version = ""; - - // default test - testSubject = createTestSubject(); - testSubject.setVersion(version); - } - - @Test - public void testGetDescription() throws Exception { - HealthCheckInfo testSubject; - String result; +import org.junit.jupiter.api.Test; +import org.openecomp.sdc.common.api.HealthCheckInfo.HealthCheckStatus; - // default test - testSubject = createTestSubject(); - result = testSubject.getDescription(); - } +class HealthCheckInfoTest { - @Test - public void testToString() throws Exception { - HealthCheckInfo testSubject; - String result; + private HealthCheckInfo createTestSubject() { + return new HealthCheckInfo("", HealthCheckStatus.UP, "", ""); + } - // default test - testSubject = createTestSubject(); - result = testSubject.toString(); - } + @Test + void testCTOR() { + assertNotNull(createTestSubject()); + } } -- cgit 1.2.3-korg