From 986de50ace41e45664c69a615f4880102197b31a Mon Sep 17 00:00:00 2001 From: Bartosz Gardziejewski Date: Fri, 23 Aug 2019 11:12:50 +0200 Subject: increasing test coverage in common-app-api exception catalog Issue-ID: SDC-2326 Signed-off-by: Bartosz Gardziejewski Change-Id: I0dd6bc60c88acbcf1b3755627a7b10b874a549ba --- ...eteLastApplicationEnvironmentExceptionTest.java | 55 ++++++++++++++++++++++ .../DeleteReferencedObjectExceptionTest.java | 40 ++++++++++++++++ .../sdc/exception/FunctionalExceptionTest.java | 54 +++++++++++++++++++++ .../exception/IndexingServiceExceptionTest.java | 54 +++++++++++++++++++++ .../exception/InvalidArgumentExceptionTest.java | 54 +++++++++++++++++++++ .../sdc/exception/NotFoundExceptionTest.java | 54 +++++++++++++++++++++ .../sdc/exception/OkResponseInfoTest.java | 43 +++++++++++++++++ .../sdc/exception/PolicyExceptionTest.java | 54 +++++++++++++++++++++ .../sdc/exception/ServiceExceptionTest.java | 54 +++++++++++++++++++++ .../exception/VersionConflictExceptionTest.java | 45 ++++++++++++++++++ 10 files changed, 507 insertions(+) create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteLastApplicationEnvironmentExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteReferencedObjectExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/FunctionalExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/IndexingServiceExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/InvalidArgumentExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/NotFoundExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/OkResponseInfoTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/PolicyExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/ServiceExceptionTest.java create mode 100644 common-app-api/src/test/java/org/openecomp/sdc/exception/VersionConflictExceptionTest.java (limited to 'common-app-api/src') diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteLastApplicationEnvironmentExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteLastApplicationEnvironmentExceptionTest.java new file mode 100644 index 0000000000..3f1eaab17c --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteLastApplicationEnvironmentExceptionTest.java @@ -0,0 +1,55 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.hamcrest.core.Is.is; + +public class DeleteLastApplicationEnvironmentExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateOneArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + expectedException.expect(DeleteLastApplicationEnvironmentException.class); + expectedException.expectMessage(testMessage); + + throw new DeleteLastApplicationEnvironmentException(testMessage); + } + + @Test + public void validateTwoArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + final String testThrowableMessage = "test throwable"; + final Throwable testThrowable = new Throwable(testThrowableMessage); + expectedException.expect(DeleteLastApplicationEnvironmentException.class); + expectedException.expectMessage(testMessage); + expectedException.expectCause(is(testThrowable)); + + throw new DeleteLastApplicationEnvironmentException(testMessage, testThrowable); + } + +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteReferencedObjectExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteReferencedObjectExceptionTest.java new file mode 100644 index 0000000000..4952207824 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/DeleteReferencedObjectExceptionTest.java @@ -0,0 +1,40 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +public class DeleteReferencedObjectExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateOneArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + expectedException.expect(DeleteReferencedObjectException.class); + expectedException.expectMessage(testMessage); + + throw new DeleteReferencedObjectException(testMessage); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/FunctionalExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/FunctionalExceptionTest.java new file mode 100644 index 0000000000..3fa9d19f21 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/FunctionalExceptionTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.hamcrest.core.Is.is; + +public class FunctionalExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateOneArgConstructorsThrowsCorrectException() throws Exception { + final String testMessage = "test error message"; + expectedException.expect(FunctionalException.class); + expectedException.expectMessage(testMessage); + + throw new FunctionalException(testMessage); + } + + @Test + public void validateTwoArgConstructorsThrowsCorrectException() throws Exception { + final String testMessage = "test error message"; + final String testThrowableMessage = "test throwable"; + final Throwable testThrowable = new Throwable(testThrowableMessage); + expectedException.expect(FunctionalException.class); + expectedException.expectMessage(testMessage); + expectedException.expectCause(is(testThrowable)); + + throw new FunctionalException(testMessage, testThrowable); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/IndexingServiceExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/IndexingServiceExceptionTest.java new file mode 100644 index 0000000000..bbca082d44 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/IndexingServiceExceptionTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.hamcrest.core.Is.is; + +public class IndexingServiceExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateOneArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + expectedException.expect(IndexingServiceException.class); + expectedException.expectMessage(testMessage); + + throw new IndexingServiceException(testMessage); + } + + @Test + public void validateTwoArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + final String testThrowableMessage = "test throwable"; + final Throwable testThrowable = new Throwable(testThrowableMessage); + expectedException.expect(IndexingServiceException.class); + expectedException.expectMessage(testMessage); + expectedException.expectCause(is(testThrowable)); + + throw new IndexingServiceException(testMessage, testThrowable); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/InvalidArgumentExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/InvalidArgumentExceptionTest.java new file mode 100644 index 0000000000..c1770a3450 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/InvalidArgumentExceptionTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.hamcrest.core.Is.is; + +public class InvalidArgumentExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateOneArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + expectedException.expect(InvalidArgumentException.class); + expectedException.expectMessage(testMessage); + + throw new InvalidArgumentException(testMessage); + } + + @Test + public void validateTwoArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + final String testThrowableMessage = "test throwable"; + final Throwable testThrowable = new Throwable(testThrowableMessage); + expectedException.expect(InvalidArgumentException.class); + expectedException.expectMessage(testMessage); + expectedException.expectCause(is(testThrowable)); + + throw new InvalidArgumentException(testMessage, testThrowable); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/NotFoundExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/NotFoundExceptionTest.java new file mode 100644 index 0000000000..5086613d12 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/NotFoundExceptionTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.hamcrest.core.Is.is; + +public class NotFoundExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateOneArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + expectedException.expect(NotFoundException.class); + expectedException.expectMessage(testMessage); + + throw new NotFoundException(testMessage); + } + + @Test + public void validateTwoArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + final String testThrowableMessage = "test throwable"; + final Throwable testThrowable = new Throwable(testThrowableMessage); + expectedException.expect(NotFoundException.class); + expectedException.expectMessage(testMessage); + expectedException.expectCause(is(testThrowable)); + + throw new NotFoundException(testMessage, testThrowable); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/OkResponseInfoTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/OkResponseInfoTest.java new file mode 100644 index 0000000000..274dcbf183 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/OkResponseInfoTest.java @@ -0,0 +1,43 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Test; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; + + +public class OkResponseInfoTest { + + @Test + public void validateArgConstructorsThrowsCorrectException() { + final String testMessageId = "test message id"; + final String testMessage = "test error message: %0, %1"; + final String[] testVariables = {"testVariable01", "testVariable02"}; + final String expectedMessage = "test error message: testVariable01, testVariable02"; + + OkResponseInfo okResponseInfo = new OkResponseInfo(testMessageId, testMessage, testVariables); + assertEquals(okResponseInfo.getMessageId(),testMessageId); + assertEquals(okResponseInfo.getFormattedErrorMessage(),expectedMessage); + assertArrayEquals(okResponseInfo.getVariables(),testVariables); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/PolicyExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/PolicyExceptionTest.java new file mode 100644 index 0000000000..2de3335958 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/PolicyExceptionTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Test; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; + +public class PolicyExceptionTest { + + @Test + public void validateNoArgConstructorsThrowsCorrectException() { + + PolicyException okResponseInfo = new PolicyException(); + + assertNull(okResponseInfo.getMessageId()); + assertNull(okResponseInfo.getFormattedErrorMessage()); + assertNull(okResponseInfo.getVariables()); + + } + + @Test + public void validateArgConstructorsThrowsCorrectException() { + final String testMessageId = "test message id"; + final String testMessage = "test error message: %0, %1"; + final String[] testVariables = {"testVariable01", "testVariable02"}; + final String expectedMessage = "test error message: testVariable01, testVariable02"; + + PolicyException okResponseInfo = new PolicyException(testMessageId, testMessage, testVariables); + assertEquals(okResponseInfo.getMessageId(),testMessageId); + assertEquals(okResponseInfo.getFormattedErrorMessage(),expectedMessage); + assertArrayEquals(okResponseInfo.getVariables(),testVariables); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/ServiceExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/ServiceExceptionTest.java new file mode 100644 index 0000000000..a3c9933473 --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/ServiceExceptionTest.java @@ -0,0 +1,54 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Test; + +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; + +public class ServiceExceptionTest { + + @Test + public void validateNoArgConstructorsThrowsCorrectException() { + + ServiceException okResponseInfo = new ServiceException(); + + assertNull(okResponseInfo.getMessageId()); + assertNull(okResponseInfo.getFormattedErrorMessage()); + assertNull(okResponseInfo.getVariables()); + + } + + @Test + public void validateArgConstructorsThrowsCorrectException() { + final String testMessageId = "test message id"; + final String testMessage = "test error message: %0, %1"; + final String[] testVariables = {"testVariable01", "testVariable02"}; + final String expectedMessage = "test error message: testVariable01, testVariable02"; + + ServiceException okResponseInfo = new ServiceException(testMessageId, testMessage, testVariables); + assertEquals(okResponseInfo.getMessageId(),testMessageId); + assertEquals(okResponseInfo.getFormattedErrorMessage(),expectedMessage); + assertArrayEquals(okResponseInfo.getVariables(),testVariables); + } +} diff --git a/common-app-api/src/test/java/org/openecomp/sdc/exception/VersionConflictExceptionTest.java b/common-app-api/src/test/java/org/openecomp/sdc/exception/VersionConflictExceptionTest.java new file mode 100644 index 0000000000..92096e59bd --- /dev/null +++ b/common-app-api/src/test/java/org/openecomp/sdc/exception/VersionConflictExceptionTest.java @@ -0,0 +1,45 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.sdc.exception; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.ExpectedException; + +import static org.hamcrest.core.Is.is; + +public class VersionConflictExceptionTest { + + @Rule + public ExpectedException expectedException = ExpectedException.none(); + + @Test + public void validateTwoArgConstructorsThrowsCorrectException() { + final String testMessage = "test error message"; + final String testThrowableMessage = "test throwable"; + final Throwable testThrowable = new Throwable(testThrowableMessage); + expectedException.expect(VersionConflictException.class); + expectedException.expectMessage(testMessage); + expectedException.expectCause(is(testThrowable)); + + throw new VersionConflictException(testMessage, testThrowable); + } +} -- cgit 1.2.3-korg