From 4f251edb14a4f525475df18f4f651696152b3b42 Mon Sep 17 00:00:00 2001 From: aribeiro Date: Fri, 4 Sep 2020 10:29:18 +0100 Subject: Make directives options configurable Issue-ID: SDC-3275 Signed-off-by: aribeiro Change-Id: Ia91655f02c45d033ebae45bd6d9f252c2f6d6f47 --- .../logic/service-dependencies/directive-option.ts | 15 --------------- .../service-dependencies.component.html | 2 +- .../service-dependencies.component.less | 5 +++++ .../service-dependencies.component.ts | 18 ++++++++++-------- .../component-services/topology-template.service.ts | 7 +++++++ 5 files changed, 23 insertions(+), 24 deletions(-) delete mode 100644 catalog-ui/src/app/ng2/components/logic/service-dependencies/directive-option.ts (limited to 'catalog-ui/src/app/ng2') diff --git a/catalog-ui/src/app/ng2/components/logic/service-dependencies/directive-option.ts b/catalog-ui/src/app/ng2/components/logic/service-dependencies/directive-option.ts deleted file mode 100644 index f2c4b1f895..0000000000 --- a/catalog-ui/src/app/ng2/components/logic/service-dependencies/directive-option.ts +++ /dev/null @@ -1,15 +0,0 @@ -export enum DirectivesEnum { - SELECT = 'select', - SELECTABLE = 'selectable', - SUBSTITUTE = 'substitute', - SUBSTITUTABLE = 'substitutable', -} - -export namespace DirectiveValue { - - export function values() { - return Object.keys(DirectivesEnum).filter( - (type) => isNaN(type) && type !== 'values' - ); - } -} diff --git a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.html b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.html index c3d4817a39..ef5e29b049 100644 --- a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.html +++ b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.html @@ -4,7 +4,7 @@ diff --git a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less index 00be76c8ca..9b1535864e 100644 --- a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less +++ b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.less @@ -113,3 +113,8 @@ } } } + + +.directives-options { + text-transform: uppercase; +} diff --git a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.ts b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.ts index 90f82f8983..ff5207bb2c 100644 --- a/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.ts +++ b/catalog-ui/src/app/ng2/components/logic/service-dependencies/service-dependencies.component.ts @@ -29,7 +29,6 @@ import { TranslateService } from 'app/ng2/shared/translator/translate.service'; import { ComponentMetadata } from '../../../../models/component-metadata'; import { ServiceInstanceObject } from '../../../../models/service-instance-properties-and-interfaces'; import { TopologyTemplateService } from '../../../services/component-services/topology-template.service'; -import {DirectivesEnum, DirectiveValue} from "./directive-option"; export class ConstraintObject { servicePropertyName: string; @@ -129,6 +128,7 @@ export class ServiceDependenciesComponent { capabilities: string = 'capabilities'; properties: string = 'properties'; private componentInstancesConstraints: ConstraintObject[] = []; + directiveOptions: string[]; @Input() readonly: boolean; @Input() compositeService: ComponentMetadata; @@ -136,7 +136,7 @@ export class ServiceDependenciesComponent { @Input() selectedInstanceSiblings: ServiceInstanceObject[]; @Input() selectedInstanceConstraints: ConstraintObject[] = []; @Input() selectedInstanceProperties: PropertyBEModel[] = []; - @Input() directiveValues: any = DirectiveValue; + @Output() updateRulesListEvent: EventEmitter = new EventEmitter(); @Output() updateNodeFilterProperties: EventEmitter = new EventEmitter(); @Output() updateNodeFilterCapabilities: EventEmitter = new EventEmitter(); @Output() loadRulesListEvent:EventEmitter = new EventEmitter(); @@ -146,6 +146,7 @@ export class ServiceDependenciesComponent { } ngOnInit() { + this.loadDirectives(); this.isLoading = false; this.operatorTypes = [ {label: '>', value: OPERATOR_TYPES.GREATER_THAN}, @@ -161,6 +162,12 @@ export class ServiceDependenciesComponent { }); } + loadDirectives() { + this.topologyTemplateService.getDirectiveList().subscribe((data: string[]) => { + this.directiveOptions = data; + }) + } + ngOnChanges(changes) { if (changes.currentServiceInstance) { this.currentServiceInstance = changes.currentServiceInstance.currentValue; @@ -239,12 +246,7 @@ export class ServiceDependenciesComponent { if (this.isDependent) { this.openUpdateDependencyModal().instance.open(); } - if (DirectivesEnum.SELECT == newDirectiveValue.toLowerCase() || - DirectivesEnum.SELECTABLE == newDirectiveValue.toLowerCase()) { - this.currentServiceInstance.markAsSelect(); - } else { - this.currentServiceInstance.markAsSubstitute(); - } + this.currentServiceInstance.setDirectiveValue(newDirectiveValue); } updateComponentInstance(isDependentOrigVal: boolean, rulesListOrig: ConstraintObject[]) { diff --git a/catalog-ui/src/app/ng2/services/component-services/topology-template.service.ts b/catalog-ui/src/app/ng2/services/component-services/topology-template.service.ts index a7c8022239..01b8ead595 100644 --- a/catalog-ui/src/app/ng2/services/component-services/topology-template.service.ts +++ b/catalog-ui/src/app/ng2/services/component-services/topology-template.service.ts @@ -63,6 +63,7 @@ import { ConstraintObject } from "../../components/logic/service-dependencies/se import { ComponentMetadata } from "../../../models/component-metadata"; import { PolicyInstance } from "../../../models/graph/zones/policy-instance"; import { PropertyBEModel } from "../../../models/properties-inputs/property-be-model"; +import {map} from "rxjs/operators"; /* we need to use this service from now, we will remove component.service when we finish remove the angular1. The service is duplicated since we can not use downgrades service with NGXS*/ @@ -529,4 +530,10 @@ export class TopologyTemplateService { deleteRequirement(component: Component, reqId: string): Observable { return this.http.delete(this.baseUrl + component.getTypeUrl() + component.uniqueId + '/requirements/' + reqId); } + + getDirectiveList(): Observable { + return this.http.get(this.baseUrl + "directives") + .pipe(map(response => response.directives)); + } + } -- cgit 1.2.3-korg