From dfc9cdee69426b48d683e119dda9fae9154e6fde Mon Sep 17 00:00:00 2001 From: vasraz Date: Mon, 1 Mar 2021 20:58:10 +0000 Subject: Improve test coverage - remove unused code - use lombok Change-Id: I8c52584249347c7ca2102022457225401f95b9a5 Signed-off-by: Vasyl Razinkov Issue-ID: SDC-3490 --- .../openecomp/sdc/TestExternalConfiguration.java | 62 ---------------------- .../impl/ActivationRequestInformationTest.java | 5 -- .../impl/ArtifactsBusinessLogicTest.java | 13 ----- .../sdc/be/impl/ForwardingPathUtilsTest.java | 11 ---- 4 files changed, 91 deletions(-) delete mode 100644 catalog-be/src/test/java/org/openecomp/sdc/TestExternalConfiguration.java (limited to 'catalog-be/src/test') diff --git a/catalog-be/src/test/java/org/openecomp/sdc/TestExternalConfiguration.java b/catalog-be/src/test/java/org/openecomp/sdc/TestExternalConfiguration.java deleted file mode 100644 index 4698c0eea9..0000000000 --- a/catalog-be/src/test/java/org/openecomp/sdc/TestExternalConfiguration.java +++ /dev/null @@ -1,62 +0,0 @@ -/*- - * ============LICENSE_START======================================================= - * SDC - * ================================================================================ - * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved. - * ================================================================================ - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * ============LICENSE_END========================================================= - */ - -package org.openecomp.sdc; - -import org.openecomp.sdc.be.config.Configuration; -import org.openecomp.sdc.common.api.BasicConfiguration; -import org.openecomp.sdc.common.api.ConfigurationListener; -import org.openecomp.sdc.common.api.ConfigurationSource; -import org.openecomp.sdc.common.api.FileChangeCallback; -import org.openecomp.sdc.common.impl.ConfigFileChangeListener; -import org.openecomp.sdc.common.impl.ExternalConfiguration; -import org.openecomp.sdc.common.impl.FSConfigurationSource; - -import java.io.IOException; - -public class TestExternalConfiguration { - - public static void main(String[] args) throws IOException { - - ExternalConfiguration.setAppName("catalog-server"); - ExternalConfiguration.setConfigDir("C:\\Users\\esofer\\workspaceLuna\\catalog-server\\src\\test\\resources\\config"); - ExternalConfiguration.listenForChanges(); - - ConfigurationListener configurationListener = new ConfigurationListener(Configuration.class, new FileChangeCallback() { - - @Override - public void reconfigure(BasicConfiguration obj) { - // TODO Auto-generated method stub - - } - }); - - ConfigurationSource configurationSource1 = new FSConfigurationSource(new ConfigFileChangeListener(), ExternalConfiguration.getConfigDir()); - configurationSource1.getAndWatchConfiguration(Configuration.class, configurationListener); - - try { - Thread.currentThread().sleep(100 * 1000); - } catch (InterruptedException e) { - e.printStackTrace(); - } - - } - -} diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ActivationRequestInformationTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ActivationRequestInformationTest.java index 68c1036575..d3706d3e53 100644 --- a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ActivationRequestInformationTest.java +++ b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ActivationRequestInformationTest.java @@ -31,11 +31,6 @@ public class ActivationRequestInformationTest { private static final String TENANT = "tenant"; private static final String WORKLOAD_CONTEXT = "workloadContext"; - @Test - public void shouldHaveValidGettersAndSetters() { - assertThat(ActivationRequestInformation.class, hasValidGettersAndSetters()); - } - @Test public void testFullArgConstructor() { Service serviceToActivate = new Service(); diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ArtifactsBusinessLogicTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ArtifactsBusinessLogicTest.java index d6995d1750..834964b5a2 100644 --- a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ArtifactsBusinessLogicTest.java +++ b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ArtifactsBusinessLogicTest.java @@ -1253,19 +1253,6 @@ public class ArtifactsBusinessLogicTest extends BaseBusinessLogicMock { testSubject.fillArtifactPayload(payloadWrapper, artifactDefinition); } - - - @Test - public void testIsValidXml() throws Exception { - ArtifactsBusinessLogic testSubject; - byte[] xmlToParse = new byte[]{' '}; - boolean result; - - // default test - testSubject = createTestSubject(); - result = Deencapsulation.invoke(testSubject, "isValidXml", new Object[]{xmlToParse}); - } - @Test(expected = ByActionStatusComponentException.class) public void testHeatTimeoutValue() { final ArtifactsBusinessLogic artifactsBusinessLogic = createTestSubject(); diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/impl/ForwardingPathUtilsTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/impl/ForwardingPathUtilsTest.java index ee374878e9..19b5949664 100644 --- a/catalog-be/src/test/java/org/openecomp/sdc/be/impl/ForwardingPathUtilsTest.java +++ b/catalog-be/src/test/java/org/openecomp/sdc/be/impl/ForwardingPathUtilsTest.java @@ -84,17 +84,6 @@ public class ForwardingPathUtilsTest { assertThat(result.getId()).isEqualTo(cpOption.getId()); } - @Test - public void testGetResponseFormatManager() { - ForwardingPathUtils testSubject; - ResponseFormatManager result; - - // default test - testSubject = createTestSubject(); - result = Deencapsulation.invoke(testSubject, "getResponseFormatManager"); - assertThat(result).isInstanceOf(ResponseFormatManager.class); - } - @Test public void testFindForwardingPathNamesToDeleteOnComponentInstanceDeletion() throws Exception { ForwardingPathUtils testSubject; -- cgit 1.2.3-korg