From 5700275b3e147e0053ae7872271a9f2fbfa13e06 Mon Sep 17 00:00:00 2001
From: Adam Wudzinski <adam.wudzinski@nokia.com>
Date: Wed, 2 Dec 2020 18:07:22 +0100
Subject: [SDC] Validate PMDictionary content in Deployment artifacts tab

Validate PMDictionary file content when adding or updating PMDictionary in Deployment artifacts tab. Fix dependencies conflict.

Issue-ID: SDC-3390
Signed-off-by: Adam Wudzinski <adam.wudzinski@nokia.com>
Change-Id: I6f6bb196ef061419a309a8ded5fdbe116982a037
---
 .../impl/validation/PMDictionaryValidatorTest.java | 87 ++++++++++++++++++++++
 1 file changed, 87 insertions(+)
 create mode 100644 catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/validation/PMDictionaryValidatorTest.java

(limited to 'catalog-be/src/test/java')

diff --git a/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/validation/PMDictionaryValidatorTest.java b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/validation/PMDictionaryValidatorTest.java
new file mode 100644
index 0000000000..7e62e6dace
--- /dev/null
+++ b/catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/validation/PMDictionaryValidatorTest.java
@@ -0,0 +1,87 @@
+/*-
+ * ============LICENSE_START=======================================================
+ * SDC
+ * ================================================================================
+ * Copyright (C) 2020 Nokia. All rights reserved.
+ * ================================================================================
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ * ============LICENSE_END=========================================================
+ */
+package org.openecomp.sdc.be.components.impl.validation;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.core.Is.is;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verifyNoInteractions;
+import static org.mockito.Mockito.when;
+
+import java.util.List;
+import java.util.Optional;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.onap.validation.yaml.YamlContentValidator;
+import org.onap.validation.yaml.error.YamlDocumentValidationError;
+import org.onap.validation.yaml.exception.YamlProcessingException;
+import org.openecomp.sdc.common.api.ArtifactTypeEnum;
+
+class PMDictionaryValidatorTest {
+
+    private YamlContentValidator yamlContentValidator;
+
+    @BeforeEach
+    void setUp() {
+        yamlContentValidator = mock(YamlContentValidator.class);
+    }
+
+    @Test
+    void shouldNotReturnErrors_whenArtifactTypeDoNotMatch() {
+        // when
+        Optional<String> errors = new PMDictionaryValidator(yamlContentValidator)
+            .validateIfPmDictionary(ArtifactTypeEnum.DCAE_INVENTORY_BLUEPRINT.name(), "".getBytes());
+
+        // then
+        assertTrue(errors.isEmpty());
+        verifyNoInteractions(yamlContentValidator);
+    }
+
+    @Test
+    void shouldReturnErrors_whenArtifactTypeIsPmDictionaryAndFileIsInvalid() throws YamlProcessingException {
+        // given
+        byte[] fileContent = "".getBytes();
+        YamlDocumentValidationError validationError = new YamlDocumentValidationError(1, "/", "error");
+        when(yamlContentValidator.validate(fileContent)).thenReturn(List.of(validationError));
+
+        // when
+        Optional<String> errors = new PMDictionaryValidator(yamlContentValidator)
+            .validateIfPmDictionary(ArtifactTypeEnum.PM_DICTIONARY.name(), fileContent);
+
+        // then
+        assertTrue(errors.isPresent());
+        assertThat(errors.get(), is("Line number: 1, Path: /, Message: error"));
+    }
+
+    @Test
+    void shouldNotReturnErrors_whenArtifactTypeIsPmDictionaryAndFileIsValid() throws YamlProcessingException {
+        // given
+        byte[] fileContent = "".getBytes();
+        when(yamlContentValidator.validate(fileContent)).thenReturn(List.of());
+
+        // when
+        Optional<String> errors = new PMDictionaryValidator(yamlContentValidator)
+            .validateIfPmDictionary(ArtifactTypeEnum.PM_DICTIONARY.name(), fileContent);
+
+        // then
+        assertTrue(errors.isEmpty());
+    }
+}
-- 
cgit 1.2.3-korg