From 5b9d9a134778d4dc7bf45474ba13be6ba0c46282 Mon Sep 17 00:00:00 2001
From: priyanshu <pagarwal@amdocs.com>
Date: Mon, 14 Jan 2019 15:46:55 +0530
Subject: Interface operation feature enhancements

1. API restructuring to enhance model and provide more capabilities.
2. Allowed multiple interface creation under same resource/service.
3. Enhanced validations to align with updated model.
4. API restructuring to align UI model with Tosca model.
5. Enhanced Junit and code coverage.
6. Added BDD and CI-API tests.

Change-Id: I2d8ac8a6154fd9be8254836ba0da1540210031c0
Issue-ID: SDC-1999
Signed-off-by: priyanshu <pagarwal@amdocs.com>
---
 .../main/resources/config/error-configuration.yaml | 52 ++++++++++++++--------
 1 file changed, 33 insertions(+), 19 deletions(-)

(limited to 'catalog-be/src/main/resources')

diff --git a/catalog-be/src/main/resources/config/error-configuration.yaml b/catalog-be/src/main/resources/config/error-configuration.yaml
index 84213bbe8d..ff86aff820 100644
--- a/catalog-be/src/main/resources/config/error-configuration.yaml
+++ b/catalog-be/src/main/resources/config/error-configuration.yaml
@@ -2033,7 +2033,7 @@ errors:
 #---------SVC4695-----------------------------
 # %1 - Interface Operation Name
     INTERFACE_OPERATION_NAME_ALREADY_IN_USE: {
-      code: 400,
+      code: 409,
       message: "Error: Interface Operation name '%1' already in use, Your current changes will not be saved.",
       messageId: "SVC4695"
     }
@@ -2041,20 +2041,20 @@ errors:
 # %1 - Interface Operation Name
     INTERFACE_OPERATION_NAME_INVALID: {
       code: 400,
-      message: "Error: Interface Operation name '%1' is Invalid, Operation name should not contain special character, space, numbers and should not be greater than 200 characters.",
+      message: "Error: Interface Operation name '%1' is Invalid, Operation name should not contain special character, space and should not be greater than 200 characters.",
       messageId: "SVC4696"
     }
 #---------SVC4697-----------------------------
     INTERFACE_OPERATION_NAME_MANDATORY: {
-      code: 404,
+      code: 400,
       message: "Error: Interface Operation name is mandatory, Operation name can't be empty.",
       messageId: "SVC4697"
     }
 #---------SVC4698-----------------------------
-# %1 - Interface Operation description
-    INTERFACE_OPERATION_DESCRIPTION_MAX_LENGTH: {
+# %1 - Interface type
+    INTERFACE_OPERATION_INVALID_FOR_LOCAL_TYPE: {
       code: 400,
-      message: "Error: Interface Operation description '%1' is invalid, maximum 200 characters allowed.",
+      message: "Error: Invalid input, only one operation is allowed in local interface type '%1'.",
       messageId: "SVC4698"
     }
 #---------SVC4699-----------------------------
@@ -2066,20 +2066,20 @@ errors:
     }
 #---------SVC4700-----------------------------
     INTERFACE_OPERATION_INPUT_NAME_MANDATORY: {
-        code: 404,
+        code: 400,
         message: "Error: Interface operation input parameter name should not be empty.",
         messageId: "SVC4700"
     }
 #---------SVC4701-----------------------------
-# %1 - resource Id
+# %1 - component Id
     INTERFACE_OPERATION_NOT_FOUND: {
       code: 404,
-      message: "Error: Interface operation not found in the resource '%1'.",
+      message: "Error: Interface operation not found in the component '%1'.",
       messageId: "SVC4701"
     }
 #---------SVC4702-----------------------------
     INTERFACE_OPERATION_NOT_DELETED: {
-      code: 404,
+      code: 400,
       message: "Error: Failed to delete interface operation.",
       messageId: "SVC4702"
     }
@@ -2133,29 +2133,43 @@ errors:
       message: "Error: CSAR packaging failed for %1 %2.",
       messageId: "SVC4706"
     }
-#---------SVC4704-----------------------------
-# %1 - Interface Operation input property name
+#---------SVC4708-----------------------------
+# %1 - Interface Operation input property name, component type
     INTERFACE_OPERATION_INPUT_PROPERTY_NOT_FOUND_IN_COMPONENT: {
         code: 404,
-        message: "Error: Interface operation input parameter property '%1' not found in component input properties.",
-        messageId: "SVC4704"
+        message: "Error: Interface operation input parameter property '%1' not found in '%2' input properties.",
+        messageId: "SVC4708"
     }
-#---------SVC4705-----------------------------
+#---------SVC4709-----------------------------
 # %1 - Interface Operation output parameter name
     INTERFACE_OPERATION_OUTPUT_NAME_ALREADY_IN_USE: {
         code: 400,
         message: "Error: Interface Operation output parameter name '%1' already in use, Your current changes will not be saved.",
-        messageId: "SVC4705"
+        messageId: "SVC4708"
     }
-#---------SVC4706-----------------------------
+#---------SVC4710-----------------------------
     INTERFACE_OPERATION_OUTPUT_NAME_MANDATORY: {
-        code: 404,
+        code: 400,
         message: "Error: Interface operation output parameter name should not be empty.",
-        messageId: "SVC4706"
+        messageId: "SVC4710"
+    }
+#---------SVC4711-----------------------------
+# %1 - interface Id
+    INTERFACE_NOT_FOUND_IN_COMPONENT: {
+      code: 404,
+      message: "Error: Interface not found in the component '%1'.",
+      messageId: "SVC4711"
     }
 #---------SVC4712-----------------------------
     INTERFACE_LIFECYCLE_TYPES_NOT_FOUND: {
         code: 404,
         message: "Error: Interface Lifecycle types not found.",
         messageId: "SVC4712"
+    }
+#---------SVC4713-----------------------------
+# %1 - Interface Operation Name
+    INTERFACE_OPERATION_INVALID_FOR_GLOBAL_TYPE: {
+        code: 400,
+        message: "Error: Invalid input, only pre-defined operation names are allowed in global interface type '%1'",
+        messageId: "SVC4713"
     }
\ No newline at end of file
-- 
cgit 1.2.3-korg