From cf0a8b21e85ec41260da802a2b923fabe89c9aaa Mon Sep 17 00:00:00 2001 From: JvD_Ericsson Date: Fri, 2 Jun 2023 17:02:18 +0100 Subject: Fix unable to set tosca function on complex type on input operation Issue-ID: SDC-4527 Signed-off-by: JvD_Ericsson Change-Id: Icc7166978c13f3692dc25d9f33a7613d64f87f6a --- .../be/tosca/InterfacesOperationsConverter.java | 40 ---------------------- 1 file changed, 40 deletions(-) (limited to 'catalog-be/src/main/java') diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/InterfacesOperationsConverter.java b/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/InterfacesOperationsConverter.java index e56472a426..cce0ad19a3 100644 --- a/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/InterfacesOperationsConverter.java +++ b/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/InterfacesOperationsConverter.java @@ -21,35 +21,27 @@ import static org.openecomp.sdc.be.utils.TypeUtils.ToscaTagNamesEnum.INPUTS; import static org.openecomp.sdc.be.utils.TypeUtils.ToscaTagNamesEnum.OPERATIONS; import com.fasterxml.jackson.annotation.JsonInclude; -import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.module.SimpleModule; import com.google.gson.Gson; -import java.util.Arrays; import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Map.Entry; import java.util.Objects; -import java.util.Optional; import java.util.Set; import java.util.stream.Collectors; import org.apache.commons.collections.MapUtils; import org.apache.commons.collections4.CollectionUtils; import org.apache.commons.lang3.StringUtils; import org.apache.commons.lang3.math.NumberUtils; -import org.json.JSONObject; -import org.openecomp.sdc.be.components.impl.exceptions.ByActionStatusComponentException; -import org.openecomp.sdc.be.dao.api.ActionStatus; import org.openecomp.sdc.be.datatypes.elements.ArtifactDataDefinition; import org.openecomp.sdc.be.datatypes.elements.InputDataDefinition; import org.openecomp.sdc.be.datatypes.elements.OperationDataDefinition; import org.openecomp.sdc.be.datatypes.elements.OperationInputDefinition; import org.openecomp.sdc.be.datatypes.elements.PropertyDataDefinition; -import org.openecomp.sdc.be.datatypes.elements.ToscaFunction; -import org.openecomp.sdc.be.datatypes.elements.ToscaFunctionType; import org.openecomp.sdc.be.model.Component; import org.openecomp.sdc.be.model.ComponentInstance; import org.openecomp.sdc.be.model.DataTypeDefinition; @@ -140,42 +132,10 @@ public class InterfacesOperationsConverter { mappedOutputValue.remove(1); mappedOutputValue.add(1, interfaceName); inputValue = gson.toJson(consumptionValue); - } else { - String finalInputValue = inputValue; - if (inputValue != null && - Arrays.stream(ToscaFunctionType.values()).anyMatch(toscaType -> finalInputValue.contains(toscaType.getName().toUpperCase()))) { - inputValue = getInputValuesAsToscaFunction(inputValue); - } } return inputValue; } - private static String getInputValuesAsToscaFunction(String inputValue) { - Gson gson = new Gson(); - Map mapOfValues = gson.fromJson(inputValue, Map.class); - for (Entry entry : mapOfValues.entrySet()) { - Object value = entry.getValue(); - if (value instanceof Map) { - Map valueMap = (Map) value; - if (valueMap.containsKey("type")) { - String type = (String) valueMap.get("type"); - Optional toscaType = ToscaFunctionType.findType(type); - if (toscaType.isPresent()) { - ObjectMapper mapper = new ObjectMapper(); - try { - String json = gson.toJson(value); - ToscaFunction toscaFunction = mapper.readValue(json, ToscaFunction.class); - entry.setValue(toscaFunction.getJsonObjectValue()); - } catch (JsonProcessingException e) { - throw new ByActionStatusComponentException(ActionStatus.GENERAL_ERROR); - } - } - } - } - } - return String.valueOf(new JSONObject(mapOfValues)); - } - private static String getInterfaceType(Component component, String interfaceType) { if (LOCAL_INTERFACE_TYPE.equals(interfaceType)) { return DERIVED_FROM_BASE_DEFAULT + component.getComponentMetadataDefinition().getMetadataDataDefinition().getSystemName(); -- cgit 1.2.3-korg