From c78692e297c0127474d2af000f22316638991c1e Mon Sep 17 00:00:00 2001 From: Chris André Date: Tue, 21 Apr 2020 20:28:38 -0400 Subject: Add null test to test in `UpgradeBusinessLogic` Issue-ID: SDC-2915 Signed-off-by: Chris Andre Change-Id: I4e6f27b707b1bdbbecf9a97606c9a655d834fe56 --- .../org/openecomp/sdc/be/components/upgrade/UpgradeBusinessLogic.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/components/upgrade/UpgradeBusinessLogic.java b/catalog-be/src/main/java/org/openecomp/sdc/be/components/upgrade/UpgradeBusinessLogic.java index c388611824..dbe5141fe0 100644 --- a/catalog-be/src/main/java/org/openecomp/sdc/be/components/upgrade/UpgradeBusinessLogic.java +++ b/catalog-be/src/main/java/org/openecomp/sdc/be/components/upgrade/UpgradeBusinessLogic.java @@ -276,10 +276,10 @@ public class UpgradeBusinessLogic { } return result; } finally { - if ( result.isRight() ){ + if ( result != null && result.isRight() ){ // undo checkout resource in case of failure LOGGER.debug("Failed to update Allotted resource {} {}, Error {}. UNDOCHEKOUT our resource", resource.getName(), resource.getUniqueId(), result.right().value()); - + upgradeStatus.addServiceStatus(request.getServiceId(), ActionStatus.GENERAL_ERROR); } } -- cgit 1.2.3-korg