From c1835f3275dd047393e05f92085a42bd61a5bd39 Mon Sep 17 00:00:00 2001 From: AndyWalshe Date: Thu, 25 Apr 2019 11:20:38 +0000 Subject: Update Sanity tests to verify PNF package onboarding Change-Id: Ibf7af544bf5fb9c63cf8d9c1573dafe50a395560 Issue-ID: SDC-1970 Signed-off-by: AndyWalshe --- sdc-os-chef/scripts/docker_run.sh | 2 +- .../Files/PNFs/sample-pnf-1.0.1-SNAPSHOT.csar | Bin 0 -> 22793 bytes .../PNFs/sample-signed-pnf-1.0.1-SNAPSHOT.zip | Bin 0 -> 23132 bytes .../sdc-api-tests/files/default/cert/root.cert | 21 ++++++++++++++++ .../sanityApiTests_2_setup_configuration.rb | 9 +++++++ .../sdc/ci/tests/api/ComponentBaseTest.java | 3 ++- .../dataProviders/OnboardingDataProviders.java | 3 ++- .../dataProviders/OnbordingDataProviders.java | 24 ++++++++++++------ .../sdc/ci/tests/datatypes/enums/XnfTypeEnum.java | 17 +++++++++++++ .../org/openecomp/sdc/ci/tests/sanity/Onboard.java | 18 ++++++-------- .../sdc/ci/tests/utils/general/FileHandling.java | 5 ++++ .../ci/tests/utils/general/OnboardingUtils.java | 27 +++++++++------------ .../tests/dataProvider/OnbordingDataProviders.java | 3 ++- .../ci/tests/execute/sanity/OnboardingFlowsUI.java | 3 ++- .../sdc/ci/tests/utilities/FileHandling.java | 2 +- 15 files changed, 97 insertions(+), 40 deletions(-) create mode 100644 test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-pnf-1.0.1-SNAPSHOT.csar create mode 100644 test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-signed-pnf-1.0.1-SNAPSHOT.zip create mode 100644 test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/cert/root.cert create mode 100644 test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/enums/XnfTypeEnum.java diff --git a/sdc-os-chef/scripts/docker_run.sh b/sdc-os-chef/scripts/docker_run.sh index 6378726b11..2832f62fe9 100755 --- a/sdc-os-chef/scripts/docker_run.sh +++ b/sdc-os-chef/scripts/docker_run.sh @@ -525,7 +525,7 @@ function sdc-api-tests { docker pull ${PREFIX}/sdc-api-tests:${RELEASE} fi - docker run --detach --name sdc-api-tests --env HOST_IP=${IP} --env ENVNAME="${DEP_ENV}" --env JAVA_OPTIONS="${API_TESTS_JAVA_OPTIONS}" --env SUITE_NAME=${API_SUITE} --log-driver=json-file --log-opt max-size=100m --log-opt max-file=10 --ulimit memlock=-1:-1 --ulimit nofile=4096:100000 ${LOCAL_TIME_MOUNT_CMD} --volume ${WORKSPACE}/data/logs/sdc-api-tests/target:/var/lib/tests/target --volume ${WORKSPACE}/data/logs/sdc-api-tests/ExtentReport:/var/lib/tests/ExtentReport --volume ${WORKSPACE}/data/logs/sdc-api-tests/outputCsar:/var/lib/tests/outputCsar --volume ${WORKSPACE}/data/environments:/root/chef-solo/environments --publish 9560:9560 ${PREFIX}/sdc-api-tests:${RELEASE} echo "please wait while SDC-API-TESTS is starting....." + docker run --detach --name sdc-api-tests --env HOST_IP=${IP} --env ENVNAME="${DEP_ENV}" --env JAVA_OPTIONS="${API_TESTS_JAVA_OPTIONS}" --env SUITE_NAME=${API_SUITE} --log-driver=json-file --log-opt max-size=100m --log-opt max-file=10 --ulimit memlock=-1:-1 --ulimit nofile=4096:100000 ${LOCAL_TIME_MOUNT_CMD} --volume ${WORKSPACE}/data/logs/sdc-api-tests/target:/var/lib/tests/target --volume ${WORKSPACE}/data/logs/sdc-api-tests/ExtentReport:/var/lib/tests/ExtentReport --volume ${WORKSPACE}/data/logs/sdc-api-tests/outputCsar:/var/lib/tests/outputCsar --volume ${WORKSPACE}/data/environments:/root/chef-solo/environments --volume ${WORKSPACE}/data/${SDC_CERT_DIR}:/var/lib/tests/cert --publish 9560:9560 ${PREFIX}/sdc-api-tests:${RELEASE} echo "please wait while SDC-API-TESTS is starting....." monitor_docker sdc-api-tests fi fi diff --git a/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-pnf-1.0.1-SNAPSHOT.csar b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-pnf-1.0.1-SNAPSHOT.csar new file mode 100644 index 0000000000..6142b9bb95 Binary files /dev/null and b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-pnf-1.0.1-SNAPSHOT.csar differ diff --git a/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-signed-pnf-1.0.1-SNAPSHOT.zip b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-signed-pnf-1.0.1-SNAPSHOT.zip new file mode 100644 index 0000000000..d97e639711 Binary files /dev/null and b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/Files/PNFs/sample-signed-pnf-1.0.1-SNAPSHOT.zip differ diff --git a/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/cert/root.cert b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/cert/root.cert new file mode 100644 index 0000000000..8db7c191a6 --- /dev/null +++ b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/files/default/cert/root.cert @@ -0,0 +1,21 @@ +-----BEGIN CERTIFICATE----- +MIIDYDCCAkigAwIBAgIJAKqOa8IS4G5sMA0GCSqGSIb3DQEBCwUAMEUxCzAJBgNV +BAYTAkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBX +aWRnaXRzIFB0eSBMdGQwHhcNMTkwNDAxMTY1NDU0WhcNMTkwNTAxMTY1NDU0WjBF +MQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEhMB8GA1UECgwYSW50 +ZXJuZXQgV2lkZ2l0cyBQdHkgTHRkMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB +CgKCAQEA4MWjUSuRVMn6LtN32JqCwIC7Gqi+drYof+uDV20jA48wohFj2nX87Eqb +W6vlz3VoEZeGCRk583l3hxctHl8t1hWwLuuCUJPOYCytkZkN0vBkfEumhg3sAy0/ +81DKO/GmEwB0H/xs6fVYFRS+KoQblCMVEcO86jsvlLi4wEaFGDWnj5YeTsYbB5Nt +gzBUGYVx0yMGIvMMZy6j2Etu4LNuiyp9Ji9kNp2/3a/eO5Q1eTOq1aIPfg75S61k +PAyraf7wreOmlbN+tV+cho0GlFOdsIs9Nl/dlf1SuIGLw6+/YEv9mhRyZQ88Gq35 +Kqx3BYna+uktKSZ/UkRfT/KyiGPNsQIDAQABo1MwUTAdBgNVHQ4EFgQUSWuR/OMI +iYFthwlP9Zw4PPAjGcEwHwYDVR0jBBgwFoAUSWuR/OMIiYFthwlP9Zw4PPAjGcEw +DwYDVR0TAQH/BAUwAwEB/zANBgkqhkiG9w0BAQsFAAOCAQEAxKoUuvCQp52dqi0g +h818IS4lK7A/uiP4xvCitpaVitQD4qMdRhmwtkx2Y++AD1aiOG0JqcLFtas7JFCI +Fi8ZMLG2CgVE8G3p1pg2o1ORhqtM+gBr3s1kwNILi5UpcGtkgRUrjMWsYo4Igiwu +dDyvjkdwaDXjVnl12joofGJMqPkg0zKiQDLwGEaGUI8lrSyP1NI0zKJoUOiSK6ss +QwyQa4Kge0qLxvCbPHLIiSD8/hEMQnruvvL7j8MqhcU4x0f+2p87xRWrtEBYHYH9 +/jQhlGaqrBb7F40LsgqqTjMLQMnGjEEuyTxO356Bv8DwI497N+I2Hxm98UY5YzUM +bR057A== +-----END CERTIFICATE----- diff --git a/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/recipes/sanityApiTests_2_setup_configuration.rb b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/recipes/sanityApiTests_2_setup_configuration.rb index 7321155232..595b24a6d1 100644 --- a/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/recipes/sanityApiTests_2_setup_configuration.rb +++ b/test-apis-ci/sdc-api-tests/chef-repo/cookbooks/sdc-api-tests/recipes/sanityApiTests_2_setup_configuration.rb @@ -41,3 +41,12 @@ template "titan.properties" do :DC_NAME => node['cassandra']['datacenter_name']+node.chef_environment }) end + +bash "Make root cert file available" do +cwd "#{tests_base}" +code <<-EOH + cp /root/chef-solo/cookbooks/sdc-api-tests/files/default/cert/root.cert /var/lib/tests/cert/root.cert + echo "root.cert file made available for tests." +EOH +end + diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/api/ComponentBaseTest.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/api/ComponentBaseTest.java index c0f209fdd2..4f74345182 100644 --- a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/api/ComponentBaseTest.java +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/api/ComponentBaseTest.java @@ -107,7 +107,8 @@ public abstract class ComponentBaseTest { public void setupBeforeTest(java.lang.reflect.Method method, ITestContext context) throws Exception { System.out.println(" method.getName() " + method.getName()); - if (!method.getName().equals("onboardVNFShotFlow")) { + if (!"onboardVNFShotFlow".equals(method.getName()) && + !"onboardPNFFlow".equals(method.getName()) ) { logger.info("ExtentReport instance started from BeforeMethod..."); ExtentTestManager.startTest(method.getName()); ExtentTestManager.assignCategory(this.getClass()); diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnboardingDataProviders.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnboardingDataProviders.java index 29de86adb3..6b58baf981 100644 --- a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnboardingDataProviders.java +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnboardingDataProviders.java @@ -1,5 +1,6 @@ package org.openecomp.sdc.ci.tests.dataProviders; +import org.openecomp.sdc.ci.tests.datatypes.enums.XnfTypeEnum; import org.openecomp.sdc.ci.tests.utils.general.FileHandling; import org.openecomp.sdc.ci.tests.utils.general.OnboardingUtils; import org.testng.annotations.DataProvider; @@ -25,7 +26,7 @@ public class OnboardingDataProviders { @DataProvider(name = "VNF_List" , parallel = true) private static final Object[][] VnfList() throws Exception { - List fileNamesFromFolder = OnboardingUtils.getVnfNamesFileList(); + List fileNamesFromFolder = OnboardingUtils.getXnfNamesFileList(XnfTypeEnum.VNF); System.out.println(String.format("There are %s zip file(s) to test", fileNamesFromFolder.size())); return provideData(fileNamesFromFolder, filepath); diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnbordingDataProviders.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnbordingDataProviders.java index 9f9fd99bd9..e834d6e436 100644 --- a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnbordingDataProviders.java +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProviders/OnbordingDataProviders.java @@ -1,5 +1,6 @@ package org.openecomp.sdc.ci.tests.dataProviders; +import org.openecomp.sdc.ci.tests.datatypes.enums.XnfTypeEnum; import org.openecomp.sdc.ci.tests.utils.general.FileHandling; import org.openecomp.sdc.ci.tests.utils.general.OnboardingUtils; import org.testng.annotations.DataProvider; @@ -12,7 +13,7 @@ import static org.testng.Assert.assertFalse; public class OnbordingDataProviders { - protected static String filepath = FileHandling.getVnfRepositoryPath(); + protected static String vnfFilepath = FileHandling.getXnfRepositoryPath(XnfTypeEnum.VNF); // -----------------------dataProviders----------------------------------------- @DataProvider(name = "randomVNF_List", parallel = false) @@ -21,26 +22,33 @@ public class OnbordingDataProviders { List fileNamesFromFolder = OnboardingUtils.getVnfNamesFileListExcludeToscaParserFailure(); List newRandomFileNamesFromFolder = getRandomElements(randomElementNumber, fileNamesFromFolder); if(newRandomFileNamesFromFolder == null){ - assertFalse(true,"Requered number of VNF files not exists under " + filepath); + assertFalse(true,"Requered number of VNF files not exists under " + vnfFilepath); } System.out.println(String.format("There are %s zip file(s) to test", newRandomFileNamesFromFolder.size())); - return provideData(newRandomFileNamesFromFolder, filepath); + return provideData(newRandomFileNamesFromFolder, vnfFilepath); } @DataProvider(name = "VNF_List" , parallel = true) private static final Object[][] VnfList() throws Exception { - List fileNamesFromFolder = OnboardingUtils.getVnfNamesFileList(); - System.out.println(String.format("There are %s zip file(s) to test", fileNamesFromFolder.size())); - return provideData(fileNamesFromFolder, filepath); + List fileNamesFromFolder = OnboardingUtils.getXnfNamesFileList(XnfTypeEnum.VNF); + System.out.println(String.format("There are %s package file(s) to test", fileNamesFromFolder.size())); + return provideData(fileNamesFromFolder, vnfFilepath); + } + + @DataProvider(name = "PNF_List" , parallel = true) + private static final Object[][] nfList() throws Exception { + List fileNamesFromFolder = OnboardingUtils.getXnfNamesFileList(XnfTypeEnum.PNF); + System.out.println(String.format("There are %s package file(s) to test", fileNamesFromFolder.size())); + return provideData(fileNamesFromFolder, FileHandling.getXnfRepositoryPath(XnfTypeEnum.PNF)); } @DataProvider(name = "Single_VNF" , parallel = true) private static final Object[][] SingleVNF() throws Exception { - List fileNamesFromFolder = OnboardingUtils.getVnfNamesFileList(); + List fileNamesFromFolder = OnboardingUtils.getXnfNamesFileList(XnfTypeEnum.VNF); List newList = new ArrayList<>(); newList.add(fileNamesFromFolder.get(0)); System.out.println(String.format("There are %s zip file(s) to test", fileNamesFromFolder.size())); - return provideData(newList, filepath); + return provideData(newList, vnfFilepath); } // -----------------------factories----------------------------------------- diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/enums/XnfTypeEnum.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/enums/XnfTypeEnum.java new file mode 100644 index 0000000000..b2181227f2 --- /dev/null +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/datatypes/enums/XnfTypeEnum.java @@ -0,0 +1,17 @@ +package org.openecomp.sdc.ci.tests.datatypes.enums; + +public enum XnfTypeEnum { + + VNF ("VNF"), + PNF ("PNF"); + + private String value; + + private XnfTypeEnum(String value) { + this.value = value; + } + + public String getValue() { + return value; + } +} diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/sanity/Onboard.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/sanity/Onboard.java index 99bfad6bbd..1f8e8b5c06 100644 --- a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/sanity/Onboard.java +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/sanity/Onboard.java @@ -80,9 +80,14 @@ public class Onboard extends ComponentBaseTest { @Test(dataProviderClass = OnbordingDataProviders.class, dataProvider = "VNF_List") public void onboardVNFShotFlow(String filePath, String vnfFile) throws Exception, Throwable { setLog(vnfFile); - System.out.println("print - >" + makeDistributionValue); runOnboardToDistributionFlow(filePath, vnfFile); } + + @Test(dataProviderClass = OnbordingDataProviders.class, dataProvider = "PNF_List") + public void onboardPNFFlow(String filePath, String pnfFile) throws Exception, Throwable { + setLog(pnfFile); + runOnboardToDistributionFlow(filePath, pnfFile); + } @Test public void passTest() { @@ -99,10 +104,8 @@ public class Onboard extends ComponentBaseTest { User user = ElementFactory.getDefaultUser(UserRoleEnum.DESIGNER); ResourceReqDetails resourceReqDetails = ElementFactory.getDefaultResource(); VendorSoftwareProductObject vendorSoftwareProductObject = OnboardingUtillViaApis.createVspViaApis(resourceReqDetails, filePath, vnfFile, user); -// vendorSoftwareProductObject.setName(vendorSoftwareProductObject.getName()); // create VF base on VNF imported from previous step - have, resourceReqDetails object include part of resource metadata -// ResourceReqDetails resourceReqDetails = ElementFactory.getDefaultResource(); resourceReqDetails = OnboardingUtillViaApis.prepareOnboardedResourceDetailsBeforeCreate(resourceReqDetails, vendorSoftwareProductObject); ExtentTestActions.log(Status.INFO, String.format("Create VF %s From VSP", resourceReqDetails.getName())); Resource resource = OnboardingUtillViaApis.createResourceFromVSP(resourceReqDetails, UserRoleEnum.DESIGNER); @@ -126,18 +129,11 @@ public class Onboard extends ComponentBaseTest { if (makeToscaValidationValue.equals("true")) { - ExtentTestActions.log(Status.INFO, String.format("Start tosca validation")); + ExtentTestActions.log(Status.INFO, "Start tosca validation"); AtomicOperationUtils.toscaValidation(service ,vnfFile); - - } - - - ExtentTestActions.log(Status.INFO, String.format("The onboarding %s test is passed ! ", vnfFile)); } - - } diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/FileHandling.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/FileHandling.java index 72610331d9..4dbc8b2dee 100644 --- a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/FileHandling.java +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/FileHandling.java @@ -25,6 +25,7 @@ import org.apache.commons.io.FileUtils; import org.openecomp.sdc.be.model.DataTypeDefinition; import org.openecomp.sdc.ci.tests.api.ComponentBaseTest; import org.openecomp.sdc.ci.tests.config.Config; +import org.openecomp.sdc.ci.tests.datatypes.enums.XnfTypeEnum; import org.openecomp.sdc.common.util.GeneralUtility; import org.yaml.snakeyaml.Yaml; @@ -140,6 +141,10 @@ public class FileHandling { return getFilePath("VNFs"); } + public static String getXnfRepositoryPath(XnfTypeEnum xnfTypeEnum) { + return xnfTypeEnum.getValue().equals(XnfTypeEnum.PNF.name()) ? getFilePath("PNFs") : getFilePath("VNFs"); + } + public static String getPortMirroringRepositoryPath() { return getFilePath("PortMirroring"); } diff --git a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/OnboardingUtils.java b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/OnboardingUtils.java index 8b5f91b53d..1a15f46c08 100644 --- a/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/OnboardingUtils.java +++ b/test-apis-ci/src/main/java/org/openecomp/sdc/ci/tests/utils/general/OnboardingUtils.java @@ -23,6 +23,7 @@ package org.openecomp.sdc.ci.tests.utils.general; import org.openecomp.sdc.be.model.User; import org.openecomp.sdc.ci.tests.api.Urls; import org.openecomp.sdc.ci.tests.config.Config; +import org.openecomp.sdc.ci.tests.datatypes.enums.XnfTypeEnum; import org.openecomp.sdc.ci.tests.datatypes.http.HttpHeaderEnum; import org.openecomp.sdc.ci.tests.datatypes.http.HttpRequest; import org.openecomp.sdc.ci.tests.datatypes.http.RestResponse; @@ -34,9 +35,9 @@ import java.util.*; public class OnboardingUtils { /** - * excluded VNF file list + * excluded VNF or PNF file list */ - public static List exludeVnfList = + public static List excludeXnfList = // new ArrayList<>(); Arrays.asList( // DUPLICATE_RESOURCE_ID_IN_DIFFERENT_FILES: @@ -85,9 +86,9 @@ public class OnboardingUtils { ); /** - * additional files to exludeVnfList files for tosca parser tests + * additional files to excludeXnfList files for tosca parser tests */ - protected static List exludeVnfListForToscaParser = //new ArrayList(); + protected static List excludeXnfListForToscaParser = //new ArrayList(); Arrays.asList( "1-Vvig-062017-(MOBILITY)_v5.1.zip", "1-Mvm-sbc-1710-092017-(MOBILITY)_v7.0.zip", @@ -177,18 +178,14 @@ public class OnboardingUtils { return headersMap; } - /** * @return - * The method returns VNF names list from Files directory under sdc-vnfs repository + * The method returns XNF names list from Files directory under sdc repository */ - public static List getVnfNamesFileList() { - String filepath = FileHandling.getVnfRepositoryPath(); + public static List getXnfNamesFileList(XnfTypeEnum xnfTypeEnum) { + String filepath = FileHandling.getXnfRepositoryPath(xnfTypeEnum); List fileNamesFromFolder = FileHandling.getZipFileNamesFromFolder(filepath); - //Please remove the hardcoded configuration ONAP Tal G!!!!!! - fileNamesFromFolder.removeAll(exludeVnfList); - //List halfResourceListByDay = divideListByDayOfMonth(fileNamesFromFolder); - //System.out.println(halfResourceListByDay.toString()); + fileNamesFromFolder.removeAll(excludeXnfList); return fileNamesFromFolder; } @@ -213,8 +210,8 @@ public class OnboardingUtils { * The method returns VNF names list from Files directory under sdc-vnfs repository excluding zip files that known as failed in tosca parser */ public static List getVnfNamesFileListExcludeToscaParserFailure() { - List fileNamesFromFolder = getVnfNamesFileList(); - fileNamesFromFolder.removeAll(exludeVnfListForToscaParser); + List fileNamesFromFolder = getXnfNamesFileList(XnfTypeEnum.VNF); + fileNamesFromFolder.removeAll(excludeXnfListForToscaParser); return fileNamesFromFolder; } @@ -230,7 +227,7 @@ public class OnboardingUtils { String vnfSourceFile = (String) objectArr[i][0]; String vnfUpdateFile = (String) objectArr[i][1]; - if(!exludeVnfList.contains(vnfSourceFile) && !exludeVnfList.contains(vnfUpdateFile)) + if(!excludeXnfList.contains(vnfSourceFile) && !excludeXnfList.contains(vnfUpdateFile)) { filteredArObject[index] = new Object[]{vnfSourceFile , vnfUpdateFile }; index++; diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProvider/OnbordingDataProviders.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProvider/OnbordingDataProviders.java index aefee13cc2..5832e87186 100644 --- a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProvider/OnbordingDataProviders.java +++ b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/dataProvider/OnbordingDataProviders.java @@ -1,5 +1,6 @@ package org.openecomp.sdc.ci.tests.dataProvider; +import org.openecomp.sdc.ci.tests.datatypes.enums.XnfTypeEnum; import org.openecomp.sdc.ci.tests.utilities.FileHandling; import org.openecomp.sdc.ci.tests.utils.general.OnboardingUtils; import org.testng.annotations.DataProvider; @@ -25,7 +26,7 @@ public class OnbordingDataProviders { @DataProvider(name = "VNF_List" , parallel = true) private static final Object[][] VnfList() throws Exception { - List fileNamesFromFolder = OnboardingUtils.getVnfNamesFileList(); + List fileNamesFromFolder = OnboardingUtils.getXnfNamesFileList(XnfTypeEnum.VNF); System.out.println(String.format("There are %s zip file(s) to test", fileNamesFromFolder.size())); return provideData(fileNamesFromFolder, filepath); diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/OnboardingFlowsUI.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/OnboardingFlowsUI.java index 419ca6e7ae..6a02a917f8 100644 --- a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/OnboardingFlowsUI.java +++ b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/execute/sanity/OnboardingFlowsUI.java @@ -24,6 +24,7 @@ import com.aventstack.extentreports.Status; import org.openecomp.sdc.ci.tests.dataProvider.OnbordingDataProviders; import org.openecomp.sdc.ci.tests.datatypes.*; import org.openecomp.sdc.ci.tests.datatypes.enums.UserRoleEnum; +import org.openecomp.sdc.ci.tests.datatypes.enums.XnfTypeEnum; import org.openecomp.sdc.ci.tests.execute.setup.ArtifactsCorrelationManager; import org.openecomp.sdc.ci.tests.execute.setup.ExtentTestActions; import org.openecomp.sdc.ci.tests.execute.setup.SetupCDTest; @@ -91,7 +92,7 @@ public class OnboardingFlowsUI extends SetupCDTest { @Test public void onboardVNFTestSanity() throws Throwable { - List fileNamesFromFolder = OnboardingUtils.getVnfNamesFileList(); + List fileNamesFromFolder = OnboardingUtils.getXnfNamesFileList(XnfTypeEnum.VNF); String vnfFile = fileNamesFromFolder.get(0).toString(); ResourceReqDetails resourceReqDetails = ElementFactory.getDefaultResource();//getResourceReqDetails(ComponentConfigurationTypeEnum.DEFAULT); ServiceReqDetails serviceReqDetails = ElementFactory.getDefaultService();//getServiceReqDetails(ComponentConfigurationTypeEnum.DEFAULT); diff --git a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/FileHandling.java b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/FileHandling.java index 0394513de0..35460f6cb2 100644 --- a/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/FileHandling.java +++ b/ui-ci/src/main/java/org/openecomp/sdc/ci/tests/utilities/FileHandling.java @@ -202,7 +202,7 @@ public class FileHandling { filenames.add(file.getName()); } - filenames.removeAll(OnboardingUtils.exludeVnfList); + filenames.removeAll(OnboardingUtils.excludeXnfList); return filenames; } -- cgit 1.2.3-korg