From a6233bfac2e523b537b8a3530969bda4b231bf7a Mon Sep 17 00:00:00 2001 From: mojahidi Date: Wed, 27 Dec 2017 11:26:38 +0530 Subject: Fixed sonar issues -NicInternalNetworkErrorBuilder Fixed all sonar issues Change-Id: I206a6529b85c501f06747178ff0571b7547428ad Issue-ID: SDC-343 Signed-off-by: mojahidi --- .../errors/NicInternalNetworkErrorBuilder.java | 26 +++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/errors/NicInternalNetworkErrorBuilder.java b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/errors/NicInternalNetworkErrorBuilder.java index 2acfde48ff..5e7d8b98e3 100644 --- a/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/errors/NicInternalNetworkErrorBuilder.java +++ b/openecomp-be/backend/openecomp-sdc-vendor-software-product-manager/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/errors/NicInternalNetworkErrorBuilder.java @@ -1,3 +1,19 @@ +/* + * Copyright © 2016-2017 European Support Limited + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package org.openecomp.sdc.vendorsoftwareproduct.errors; import org.openecomp.sdc.common.errors.ErrorCategory; @@ -15,12 +31,16 @@ public class NicInternalNetworkErrorBuilder { private static final String NETWORK_TYPE_UPDATE_NOT_ALLOWED_MSG = "Invalid request, Network Type Update not allowed for a Nic"; + private NicInternalNetworkErrorBuilder() { + + } + public static ErrorCode getNicNullNetworkIdInternalNetworkIdErrorBuilder(){ ErrorCode.ErrorCodeBuilder builder = new ErrorCode.ErrorCodeBuilder(); builder.withId(VendorSoftwareProductErrorCodes.NULL_NETWORKID_NOT_ALLOWED); builder.withCategory(ErrorCategory.APPLICATION); - builder.withMessage(String.format(NULL_NETWORKID_NOT_ALLOWED_MSG)); + builder.withMessage(NULL_NETWORKID_NOT_ALLOWED_MSG); return builder.build(); } @@ -29,7 +49,7 @@ public class NicInternalNetworkErrorBuilder { ErrorCode.ErrorCodeBuilder builder = new ErrorCode.ErrorCodeBuilder(); builder.withId(NETWORK_DESCRIPTION_NOT_ALLOWED_FOR_INTERNAL_NETWORK); builder.withCategory(ErrorCategory.APPLICATION); - builder.withMessage(String.format(NETWORK_DESCRIPTION_NOT_ALLOWED_FOR_INTERNAL_NETWORK_MSG)); + builder.withMessage(NETWORK_DESCRIPTION_NOT_ALLOWED_FOR_INTERNAL_NETWORK_MSG); return builder.build(); } @@ -38,7 +58,7 @@ public class NicInternalNetworkErrorBuilder { ErrorCode.ErrorCodeBuilder builder = new ErrorCode.ErrorCodeBuilder(); builder.withId(NETWORK_TYPE_UPDATE_NOT_ALLOWED); builder.withCategory(ErrorCategory.APPLICATION); - builder.withMessage(String.format(NETWORK_TYPE_UPDATE_NOT_ALLOWED_MSG)); + builder.withMessage(NETWORK_TYPE_UPDATE_NOT_ALLOWED_MSG); return builder.build(); } -- cgit 1.2.3-korg