From 599f6c050b48932479fa91e189ee42ad2111d95a Mon Sep 17 00:00:00 2001 From: ojasdubey Date: Fri, 14 Sep 2018 16:55:00 +0530 Subject: Bugfix - interface_types missing from tosca 1.Fix for interface_types missing from the tosca model for a resource/service 2. Interface name should not contain spaces to make the behavior consistent with tosca node type component naming Change-Id: I8e135a87d659d3fb17d284247bcf222a8be7ccde Issue-ID: SDC-1760 Signed-off-by: ojasdubey --- .../src/main/java/org/openecomp/sdc/be/tosca/ToscaExportHandler.java | 2 +- .../openecomp/sdc/be/tosca/utils/InterfacesOperationsToscaUtil.java | 3 +++ .../org/openecomp/sdc/be/model/jsontitan/utils/InterfaceUtils.java | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/ToscaExportHandler.java b/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/ToscaExportHandler.java index d62c2c64eb..41b29e3517 100644 --- a/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/ToscaExportHandler.java +++ b/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/ToscaExportHandler.java @@ -550,7 +550,7 @@ public class ToscaExportHandler { Map nodeTypes) { log.debug("start convert node type for {}", component.getUniqueId()); ToscaNodeType toscaNodeType = createNodeType(component); - + toscaNode.setInterface_types(addInterfaceTypeElement(component)); Either, TitanOperationStatus> dataTypesEither = dataTypeCache.getAll(); if (dataTypesEither.isRight()) { log.debug("Failed to fetch all data types :", dataTypesEither.right().value()); diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/utils/InterfacesOperationsToscaUtil.java b/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/utils/InterfacesOperationsToscaUtil.java index 5370a7849e..70fd2575f0 100644 --- a/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/utils/InterfacesOperationsToscaUtil.java +++ b/catalog-be/src/main/java/org/openecomp/sdc/be/tosca/utils/InterfacesOperationsToscaUtil.java @@ -64,6 +64,9 @@ public class InterfacesOperationsToscaUtil { return null; } final Map interfaces = component.getInterfaces(); + if (MapUtils.isEmpty(interfaces)) { + return null; + } Map toscaInterfaceTypes = new HashMap<>(); for (InterfaceDefinition interfaceDefinition : interfaces.values()) { ToscaInterfaceNodeType toscaInterfaceType = new ToscaInterfaceNodeType(); diff --git a/catalog-model/src/main/java/org/openecomp/sdc/be/model/jsontitan/utils/InterfaceUtils.java b/catalog-model/src/main/java/org/openecomp/sdc/be/model/jsontitan/utils/InterfaceUtils.java index a3ec3f2c20..7a36d92c76 100644 --- a/catalog-model/src/main/java/org/openecomp/sdc/be/model/jsontitan/utils/InterfaceUtils.java +++ b/catalog-model/src/main/java/org/openecomp/sdc/be/model/jsontitan/utils/InterfaceUtils.java @@ -28,6 +28,7 @@ import org.openecomp.sdc.be.datatypes.elements.OperationOutputDefinition; import org.openecomp.sdc.be.model.InputDefinition; import org.openecomp.sdc.be.model.InterfaceDefinition; import org.openecomp.sdc.be.model.Operation; +import org.openecomp.sdc.common.util.ValidationUtils; public class InterfaceUtils { @@ -61,7 +62,7 @@ public class InterfaceUtils { public static String createInterfaceToscaResourceName(String resourceName) { StringBuilder sb = new StringBuilder(); try(Formatter formatter = new Formatter(sb)){ - return formatter.format(INTERFACE_TOSCA_RESOURCE_NAME, resourceName).toString(); + return formatter.format(INTERFACE_TOSCA_RESOURCE_NAME, ValidationUtils.convertToSystemName(resourceName)).toString(); } } -- cgit 1.2.3-korg