From 436e8c40188bc15236d378111c498f120b63878c Mon Sep 17 00:00:00 2001 From: Piotr Darosz Date: Tue, 3 Sep 2019 10:28:11 +0200 Subject: openecomp-utilities-lib code coverage increase Add tests for RequirementDefinitionDeserializer class Change-Id: I038f73fad4daa3eab931c566668359db9b5f6dc6 Issue-ID: SDC-2326 Signed-off-by: Piotr Darosz --- .../RequirementDefinitionDeserializer.java | 6 +-- .../RequirementDefinitionDeserializerTest.java | 63 ++++++++++++++++++++++ 2 files changed, 66 insertions(+), 3 deletions(-) create mode 100644 openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/test/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializerTest.java diff --git a/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/main/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializer.java b/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/main/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializer.java index 4a2fcaf9fa..1176a6ba8b 100644 --- a/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/main/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializer.java +++ b/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/main/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializer.java @@ -32,9 +32,9 @@ import com.google.gson.JsonPrimitive; public class RequirementDefinitionDeserializer implements JsonDeserializer { - private static final String CAPABILITY = "capability"; - private static final String NODE = "node"; - private static final String RELATIONSHIP = "relationship"; + static final String CAPABILITY = "capability"; + static final String NODE = "node"; + static final String RELATIONSHIP = "relationship"; private static final String OCCURRENCES = "occurrences"; @Override diff --git a/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/test/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializerTest.java b/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/test/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializerTest.java new file mode 100644 index 0000000000..7ac0bfcce2 --- /dev/null +++ b/openecomp-be/lib/openecomp-core-lib/openecomp-utilities-lib/src/test/java/org/openecomp/core/utilities/deserializers/RequirementDefinitionDeserializerTest.java @@ -0,0 +1,63 @@ +/*- + * ============LICENSE_START======================================================= + * SDC + * ================================================================================ + * Copyright (C) 2019 Nokia. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END========================================================= + */ + +package org.openecomp.core.utilities.deserializers; + +import com.google.gson.JsonElement; +import com.google.gson.JsonParser; +import org.junit.Test; +import org.onap.sdc.tosca.datatypes.model.RequirementDefinition; + +import static org.junit.Assert.assertEquals; +import static org.openecomp.core.utilities.deserializers.RequirementDefinitionDeserializer.CAPABILITY; +import static org.openecomp.core.utilities.deserializers.RequirementDefinitionDeserializer.NODE; +import static org.openecomp.core.utilities.deserializers.RequirementDefinitionDeserializer.RELATIONSHIP; + +public class RequirementDefinitionDeserializerTest { + + @Test + public void deserializeTest() { + RequirementDefinitionDeserializer deserializer = new RequirementDefinitionDeserializer(); + + String jsonString = new StringBuilder() + .append("{\n") + .append(" \"occurrences\": [\n") + .append(" 1,\n") + .append(" 2,\n") + .append(" \"3\"\n") + .append(" ],\n") + .append(" \"capability\": \"").append(CAPABILITY).append("\",\n") + .append(" \"relationship\": \"").append(RELATIONSHIP).append("\",\n") + .append(" \"node\": \"").append(NODE).append("\"\n") + .append("}") + .toString(); + JsonElement jsonElement = new JsonParser().parse(jsonString); + + RequirementDefinition requirement = + deserializer.deserialize(jsonElement, null, null); + + assertEquals(requirement.getOccurrences()[0], 1); + assertEquals(requirement.getOccurrences()[1], 2); + assertEquals(requirement.getOccurrences()[2], "3"); + assertEquals(requirement.getCapability(), CAPABILITY); + assertEquals(requirement.getRelationship(), RELATIONSHIP); + assertEquals(requirement.getNode(), NODE); + } +} -- cgit 1.2.3-korg