From 3477e62a0cb8ae94ba4f68ce79ba644584c222f3 Mon Sep 17 00:00:00 2001 From: shikha0203 Date: Mon, 27 Feb 2023 17:21:44 +0000 Subject: PortalRestApiCentralServiceImpl- Add null test before using nullable values Issue-ID: SDC-4415 Signed-off-by: shikha0203 Change-Id: I4fa7db7e6def7448fe3ae81923d83a6ec325bf3f --- .../sdc/be/ecomp/PortalRestApiCentralServiceImpl.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/catalog-be/src/main/java/org/openecomp/sdc/be/ecomp/PortalRestApiCentralServiceImpl.java b/catalog-be/src/main/java/org/openecomp/sdc/be/ecomp/PortalRestApiCentralServiceImpl.java index 55ce879bde..945bf7e0f2 100644 --- a/catalog-be/src/main/java/org/openecomp/sdc/be/ecomp/PortalRestApiCentralServiceImpl.java +++ b/catalog-be/src/main/java/org/openecomp/sdc/be/ecomp/PortalRestApiCentralServiceImpl.java @@ -65,8 +65,14 @@ public final class PortalRestApiCentralServiceImpl implements IPortalRestCentral public PortalRestApiCentralServiceImpl() throws PortalAPIException { try { ApplicationContext ctx = ContextLoader.getCurrentWebApplicationContext(); - userBusinessLogic = (UserBusinessLogic) ctx.getBean("userBusinessLogic"); - userBusinessLogicExt = (UserBusinessLogicExt) ctx.getBean("userBusinessLogicExt"); + if (ctx == null) { + log.debug("Failed to get CurrentWebApplicationContext."); + BeEcompErrorManager.getInstance().logInternalUnexpectedError("constructor", "Failed to get CurrentWebApplicationContext. Can't get UserBusinessLogic and userBusinessLogicExt", BeEcompErrorManager.ErrorSeverity.ERROR); + throw new PortalAPIException("CurrentWebApplicationContext is null. Failed to get Bean userBusinessLogic and userBusinessLogicExt"); + } else { + userBusinessLogic = (UserBusinessLogic) ctx.getBean("userBusinessLogic"); + userBusinessLogicExt = (UserBusinessLogicExt) ctx.getBean("userBusinessLogicExt"); + } } catch (Exception e) { log.debug("Failed to get user UserBusinessLogic", e); BeEcompErrorManager.getInstance() -- cgit 1.2.3-korg