summaryrefslogtreecommitdiffstats
path: root/openecomp-be
AgeCommit message (Collapse)AuthorFilesLines
2018-01-09Fix sonar issues - JsonUtilsiddharth09051-5/+8
Private constructor and Changed StringBuffer to StringBuilder Change-Id: I5fdd520654c0ba00f54c66f2d4a96e60ee2b496e Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2018-01-09Fix sonar issues - CassandraSessionFactorysiddharth09051-2/+1
Rearrange code Change-Id: I076403fd22790fd0e64fc51d3118e5a436941b61 Issue-ID: SDC-343 Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
2018-01-09Fixed sonar issues - ToscaAnalyzerServiceImplsheetalm3-136/+408
Resolve code review comments.Fixed cyclomatic complexity and nested try/if/else issues. Corrected Copyright. Added junit for changes done as part of sonar fix. Change-Id: If7ecc53acd82c49ab5ca73f0330a792fc1fc6d5c Issue-ID: SDC-343 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2018-01-08Refactored - VendorSoftwareProductsImplmojahidi1-105/+106
Refactored as per given comment Change-Id: I6f075390f2ffdb16c80844e0ab809c3ed59478fb Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-07Fix issue Null pointer exceptionamitjai2-4/+19
If feature group list is empty or null we should ignore check. Change-Id: I6fcf20501353f6f32ad166a6096074f4f393dd00 Issue-ID: SDC-876 Signed-off-by: amitjai <amitjai@amdocs.com>
2018-01-07Enable vsp manager unit teststalig1-1/+0
Change-Id: I2f57c0d8206b94d502132e0a8a6f811328a794c6 Issue-ID: SDC-860 Signed-off-by: talig <talig@amdocs.com>
2018-01-05Deleted - ComponentUploadsImplmojahidi1-141/+0
Deleted commented class Change-Id: I1279755a1e9eaf2a6f92901c7586cacbe68734fe Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Delete redundant test and mockstalig4-86/+0
Change-Id: I86fb039161a14f3d0dccc124fcc9b6f585912859 Issue-ID: SDC-860 Signed-off-by: talig <talig@amdocs.com>
2018-01-04Remove enter/exit debug #8vempo11-471/+0
Change-Id: Ib075b5b42498bfe8d7fc0368e078adeead340e34 Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #7vempo14-241/+0
Change-Id: Iae9f758442a7f656a8f5ed76404106cd14ef985e Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #3vempo12-400/+8
Change-Id: If2ea8d16a1fd1867b4b314290fdcfaeafef93c19 Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-9/+10
Refactored the code as per review comment in DefaultExceptionMapper.java file. Change-Id: I23c43e52e444cbd26b9c6bcf1c060f0f8b8f8204 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Remove enter/exit debug #10vempo7-95/+0
Change-Id: I5d3e97ba5fe050e5420e02c92cddca6742e55c5e Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #5vempo12-270/+0
Change-Id: I756f8fc8ae24fe7840e9189274ea749c5555dc78 Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #4vempo12-361/+0
Change-Id: I99cef676015533d9cfe66f5a5371da49856500dc Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #2vempo12-247/+0
Change-Id: Id1bbe1c57c08271991b10053f778d6473cd27a01 Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #9vempo12-221/+0
Change-Id: I8a6fb5be912834fc0c684c6ba5d076bec00fc92c Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #1vempo12-267/+1
Change-Id: I1271f6b0beb8c45881d90b08763d08892092e7d3 Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Remove enter/exit debug #6vempo12-549/+0
Change-Id: Ic9d9ebfabc52c6d1bd785e6b0f9d1ecc177f996e Issue-ID: SDC-875 Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-13/+6
Fixed minor issue and updated license header in MappingBase file. One major issue warning of converting MappingBase from abstract class to interface has not fixed because it involes changes in lot of other files whereever MappingBase is used or referred. Change-Id: I5c2fe8d0ec1a21ea0fd931b45f2f9804d81de498 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-9/+7
Fixed major issue in StringWrapperResponse file , updated license header. Change-Id: Iba74d0398caa60c12914f42d5c3f09fe95c3f109 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-9/+9
Fixed major issue and updated license header in RestConstants file. Change-Id: Ia842bd5728068c769e810475cf1b1dab8e3f12e4 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Fixed sonar issues - MapDeploymentFlavorEntityToDmojahidi1-5/+17
Removed commented code in MapDeploymentFlavorEntityToDeploymentFlavorDto Change-Id: Icc70d1c1bea3f92d3206f283e2aca149f35813ba Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Fix VspZusammenUtilAbhai Singh1-0/+2
Fixed reported sonar issue Change-Id: I898ebd3f30ce326d9f626611d049ee2a5e9f61bf Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-5/+21
Fixed major issues and updated license header in EchoMapMapping.java. Change-Id: I9d50522466c2e4ea9e723488deb3a9da4cc98b2c Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Fix VendorSoftwareProductInfoDaoImplAbhai Singh1-100/+0
Removed the file since it is not being referenced and is replaced by VendorSoftwareProductInfoDaoZusammenImpl Change-Id: Ida3fdb6a46df540c0ee38481609752a44b47b1cd Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix VendorSoftwareProductErrorCodesAbhai Singh1-9/+6
Fixed reported sonar issues Change-Id: I48dfd9333ec0ce5bb105c13e7fcd648290236bf2 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-28/+0
VersioningAction.java is not used anywhere hence deleting this file. Change-Id: I0a585734c9b4b9d7e6833450cdfc3f03ac9b49f3 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Fixed sonar issues - VendorSoftwareProductUtilsmojahidi4-67/+28
Removed unused methods and method parameters Change-Id: Ie221c5bfd939db74c15db7d12cff9b41059eb86c Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Fixing sonar qube issuesshrikantawachar1-8/+0
EchoMapping.java is not used anywhere hence deleting it. Change-Id: Ifb26e29bacdd62d1137184b50b0b83a6fb2896e5 Issue-ID: SDC-343 Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
2018-01-04Fix ProcessDaoZusammenImplAbhai Singh1-18/+1
Fixed reported sonar issues Change-Id: Id53e3ab1d70e17dd1a7a10cca3c9ee627fef4771 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix QuestionnaireDataServiceImplAbhai Singh1-10/+6
Fixed reported sonar issues Change-Id: I921dc63d9d6d5f85d0553c005cef27cc5aabe531 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix Sonar IssuesAravindhan1231-15/+15
Handles translator-core ToscaConverterImpl violations. Change-Id: I751ffdde851e23a977c6c05fc1fe5551f247a670 Issue-ID: SDC-343 Signed-off-by: Aravindhan123 <Aravindhan.r@amdocs.com>
2018-01-04Fix OrchestrationTemplateDaoZusammenImplAbhai Singh1-9/+19
Fixed reported sonar issues, sonar issue related to exception handling are skipped as they would be fixed later Change-Id: Ib83c69b7b2cfd7fc6e719b3678424c18c3e2cb8a Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix OrchestrationTemplateCandidateDaoZusammenImplAbhai Singh1-9/+19
Fixed reported sonar issues, sonar issue related to exception handling are skipped as they would be fixed later Change-Id: Ifc28fe4358eb542bcbf666a07bc37d5488df14c7 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix Sonar NetworkDaoCassandraImplAbhai Singh1-129/+0
Deleted the file since it is not used, also confirmed with Tali regarding it Change-Id: I54cd96688f9b8cb7320578d71d8ad13a90b2bef2 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix Sonar NicDaoCassandraImplAbhai Singh1-154/+0
Deleted the file since it is not used, also confirmed with Tali regarding it Change-Id: Iec438220fcdf041ac7e784abdc8af2bef4ccbd9d Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix issue in vendor-license.xmlsheetalm2-14/+167
If MRN is updated in feature group then update all linked EPs and Lkgs with new different versionUuId. This will generate new version in vendor-license.xml with updated MRN for EP and Lkgs Change-Id: Ib05d931397f24b8131471f423ca43af49b98df8b Issue-ID: SDC-870 Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
2018-01-04Fix Sonar issues- ComputeDaoZusammenImplAbhai Singh1-2/+3
Fixed reported sonar issue Change-Id: Ic7f24226dec3320124bf0acd3f70afdec3466163 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Heat reupload component dependency issue fixojasdubey3-79/+120
Resolved merge conflict Change-Id: Ib9561aa7d5814c3dd9c6015214d656a2800984a9 Issue-ID: SDC-872 Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
2018-01-04Fix Sonar ElementToVSPQuestionnaireConvertorAbhai Singh1-2/+22
Fixed reported sonar issue Change-Id: Ib1918e43a15f41535a3f5e1cd31340fe430eae61 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix Sonar NicDaoZusammenImplAbhai Singh1-4/+4
Fixed reported sonar issues Change-Id: Id0b925a8e01ac6aa40f48f4e9c1efa018b4155b1 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix Sonar NetworkDaoZusammenImplAbhai Singh1-3/+2
Fixed reported sonar issues Change-Id: I2c401fd6b18a74d74096494ff7b15bc4d53df10e Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fixed sonar issues - MapValidationResponseToDtomojahidi1-49/+8
Removed commented code Change-Id: I2dc73201a53947d68031000f80251a6b29798bfb Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Fixed sonar issues-MapImageRequestDtoToImageEntitymojahidi1-15/+16
Removed commented code Change-Id: I6b6b78653936800e76957d638df3574306605696 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Fix Sonar ManifestCreatorNamingConventionImplAbhai Singh1-13/+5
Fixed reported sonar issue Change-Id: I723be3b861df1106c3039a1368f4f20fe4acfcd0 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fix Sonar ImageDaoZusammenImplAbhai Singh1-5/+5
Fixed reported sonar issue Change-Id: I129fa4cbb5ba09c361663f7259807fca690eff0e Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
2018-01-04Fixed sonar issues - VspItemPropertymojahidi1-0/+20
Added private constructor Change-Id: Ic8ba23a009dab76518e9b7e266cc6d56820222b5 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Fixed sonar issues - ComponentDependenciesImplmojahidi1-6/+18
Fixed all sonar issues Change-Id: Iaed4ea9bc7df52bd100d5d118b7212813ae22b76 Issue-ID: SDC-343 Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
2018-01-04Fix Sonar VendorSoftwareProductInfoDaoZusammenImplAbhai Singh2-62/+45
Fixed reported sonar issue Change-Id: Ifc827f6e1ac4c10272969e643d10b86171a0d963 Issue-ID: SDC-343 Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>