diff options
author | k.kedron <k.kedron@partner.samsung.com> | 2019-06-14 09:09:39 +0200 |
---|---|---|
committer | k.kedron <k.kedron@partner.samsung.com> | 2019-06-18 09:09:35 +0200 |
commit | bbb56de1b8f5ab2322fea0a7537bfe1b9c23a366 (patch) | |
tree | 67c8ca4e57e22cd7f73ada294616db221b9c36bc /src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java | |
parent | ee1ecc7d1ccf16689e1caa7fe5c0f34d046df0d8 (diff) |
Improve the unit tests for StringTransformAction, UnaryFieldAction and TopoSearchAction
Add new unit test for StringTransformAction, UnaryFieldAction.
Improve the TopoSearchActionTest:
- use new ActionBuilder to creates the objects
- use Mocikto mock instead inner BaseAction class
Issue-ID: SDC-2327
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I049eede5bf9102bfc1f7b9527402a20b116bae30
Diffstat (limited to 'src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java')
-rw-r--r-- | src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java | 104 |
1 files changed, 81 insertions, 23 deletions
diff --git a/src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java b/src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java index 573e0a4..239ac2f 100644 --- a/src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java +++ b/src/test/java/org/onap/sdc/dcae/composition/restmodels/ruleeditor/StringTransformActionTest.java @@ -1,29 +1,87 @@ +/*- + * ============LICENSE_START=============================================== + * ONAP SDC + * ======================================================================== + * Modifications Copyright (c) 2019 Samsung + * ======================================================================== + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * ============LICENSE_END================================================= + */ + package org.onap.sdc.dcae.composition.restmodels.ruleeditor; -import org.junit.Test; +import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanConstructor; +import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanEquals; +import static com.google.code.beanmatchers.BeanMatchers.hasValidBeanHashCodeFor; +import static com.google.code.beanmatchers.BeanMatchers.hasValidGettersAndSetters; -import static com.google.code.beanmatchers.BeanMatchers.*; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThat; +import static org.junit.Assert.assertTrue; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.Mock; +import org.mockito.Mockito; +import org.mockito.junit.MockitoJUnitRunner; +@RunWith(MockitoJUnitRunner.class) public class StringTransformActionTest { - @Test - public void shouldHaveValidGettersAndSetters() { - assertThat(StringTransformAction.class, hasValidGettersAndSetters()); - } - - @Test - public void checkEquals() { - assertThat(StringTransformAction.class, hasValidBeanEquals()); - } - - @Test - public void testHasValidConstructor() { - assertThat(StringTransformAction.class, hasValidBeanConstructor()); - } - - @Test - public void checkHashCodeFor() { - assertThat(StringTransformAction.class, hasValidBeanHashCodeFor()); - } -}
\ No newline at end of file + private static final String FIRST_START_VALUE = "test1"; + private static final String START_VALUES = "${" + FIRST_START_VALUE + "}${test2}"; + private static final String TEST_TARGET = "testTarget"; + private static final String IS_TRIM = "true"; + + @Mock + private BaseAction baseAction; + + @Test + public void shouldHaveValidGettersAndSetters() { + assertThat(StringTransformAction.class, hasValidGettersAndSetters()); + } + + @Test + public void checkEquals() { + assertThat(StringTransformAction.class, hasValidBeanEquals()); + } + + @Test + public void testHasValidConstructor() { + assertThat(StringTransformAction.class, hasValidBeanConstructor()); + } + + @Test + public void checkHashCodeFor() { + assertThat(StringTransformAction.class, hasValidBeanHashCodeFor()); + } + + @Test + public void stringTransformActionBaseFieldTest() { + StringTransformAction stringTransformAction = buildBasestringTransformAction(); + + assertEquals(START_VALUES, stringTransformAction.startValue()); + assertEquals(TEST_TARGET, stringTransformAction.targetCase()); + assertTrue(stringTransformAction.trim()); + + Mockito.when(baseAction.strippedTarget()).thenReturn(FIRST_START_VALUE); + assertTrue(stringTransformAction.referencesTarget(baseAction)); + } + + private StringTransformAction buildBasestringTransformAction() { + String stringTransform = "{stringTransform: {startValue:\"" + START_VALUES + "\"," + + "targetCase:" + TEST_TARGET + "," + "isTrimString:" + IS_TRIM + "}}"; + + return ActionBuilder.buildAction(stringTransform, StringTransformAction.class); + } +} |