From bc7a90fb8a3db81bd121e234ecd7fa16afbf0624 Mon Sep 17 00:00:00 2001 From: burdziak Date: Tue, 19 Mar 2019 11:16:43 +0100 Subject: Fix sonar issues in CamundaCockpitController Change-Id: I0bc13626a91a55c8e324bfd69f02ce7841350cf3 Issue-ID: PORTAL-523 Signed-off-by: burdziak --- .../controller/sample/CamundaCockpitController.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'ecomp-sdk') diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java index c43b4acc..4c32b964 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/sample/CamundaCockpitController.java @@ -59,20 +59,22 @@ import org.springframework.web.bind.annotation.ResponseBody; @Controller @RequestMapping("/") -public class CamundaCockpitController extends RestrictedBaseController { +public class CamundaCockpitController extends RestrictedBaseController { + + private static final String CAMUNDA_COCKPIT_LINK = "camunda_cockpit_link"; @SuppressWarnings("rawtypes") @RequestMapping(value = {"/get_camunda_cockpit_link" }, method = RequestMethod.GET, produces = "application/json") @ResponseBody public Map getCamundaCockpitLink(HttpServletRequest request,HttpServletResponse response) { - Map map = new HashMap(); + Map map = new HashMap<>(); String camundaCockpitUrl = ""; String camundaCockpitlinkDefined = "false"; - if (SystemProperties.containsProperty("camunda_cockpit_link")){ - camundaCockpitUrl = SystemProperties.getProperty("camunda_cockpit_link"); + if (SystemProperties.containsProperty(CAMUNDA_COCKPIT_LINK)){ + camundaCockpitUrl = SystemProperties.getProperty(CAMUNDA_COCKPIT_LINK); camundaCockpitlinkDefined = "true"; }; map.put("link_defined", camundaCockpitlinkDefined); - map.put("camunda_cockpit_link", camundaCockpitUrl); + map.put(CAMUNDA_COCKPIT_LINK, camundaCockpitUrl); return map; }; } -- cgit 1.2.3-korg