From 8629492fa5d8d4643f8e88c0ae3a4240590aacf6 Mon Sep 17 00:00:00 2001 From: Indrijeet kumar Date: Thu, 21 May 2020 17:15:15 +0530 Subject: removed code smells in some components removed code smells in some components Issue-ID: PORTAL-813 Change-Id: Ib8e1deaddbbd58d41a839c505a3e9875b1046297 Signed-off-by: Indrijeet Kumar --- .../java/org/onap/portalsdk/core/service/UserApiServiceImpl.java | 2 +- .../onap/portalsdk/core/service/support/ServiceLocatorImpl.java | 8 -------- .../main/java/org/onap/portalsdk/core/web/support/UserUtils.java | 1 - 3 files changed, 1 insertion(+), 10 deletions(-) (limited to 'ecomp-sdk/epsdk-core/src') diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserApiServiceImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserApiServiceImpl.java index 9c8a8838..9ed0f38c 100644 --- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserApiServiceImpl.java +++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/UserApiServiceImpl.java @@ -7,7 +7,7 @@ * =================================================================== * * Unless otherwise specified, all software contained herein is licensed - * under the Apache License, Version 2.0 (the "License"); + * under the Apache License, Version 2.0. (the "License"); * you may not use this software except in compliance with the License. * You may obtain a copy of the License at * diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java index e348882d..3ed6188b 100644 --- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java +++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/support/ServiceLocatorImpl.java @@ -66,14 +66,6 @@ public class ServiceLocatorImpl implements ServiceLocator { public ServiceLocatorImpl() { } - /* - * public static ServiceLocator getLocator() { if (locator == null) locator = - * new ServiceLocator(); return locator; } - * - * public Object clone() throws CloneNotSupportedException { throw new - * CloneNotSupportedException(); } - */ - // Get an LDAP directory context public DirContext getDirContext(String initialContextFactory, String providerUrl, String securityPrincipal) { diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java index f31fc651..95388650 100644 --- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java +++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/web/support/UserUtils.java @@ -151,7 +151,6 @@ public class UserUtils { } public static Map getRoles(HttpServletRequest request) { - // HttpSession session = request.getSession(); HttpSession session = AppUtils.getSession(request); Map roles = (Map) session.getAttribute(SystemProperties.getProperty(SystemProperties.ROLES_ATTRIBUTE_NAME)); -- cgit 1.2.3-korg