From a231d482351c64dc35563821d9531981ba28d4f3 Mon Sep 17 00:00:00 2001 From: Parshad Patel Date: Tue, 10 Dec 2019 17:05:21 +0900 Subject: Fix NullPointerException & other sonar issues A "NullPointerException" could be thrown Use a logger to log this exception Cast one of the operands of this multiplication operation to a "long" Use isEmpty() to check whether the collection is empty or not Issue-ID: PORTAL-562 Change-Id: I1bc657a8893379329547b131b53e37da873d55db Signed-off-by: Parshad Patel --- .../org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core') diff --git a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java index 09fb374a..95ca3de7 100644 --- a/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java +++ b/ecomp-sdk/epsdk-core/src/main/java/org/onap/portalsdk/core/service/LoginServiceCentralizedImpl.java @@ -127,7 +127,9 @@ public class LoginServiceCentralizedImpl extends FusionService implements LoginS if (appuser == null && userHasRoleFunctions(user)) { createUserIfNecessary(user); } else { - appuser.setLastLoginDate(new Date()); + if(appuser != null) { + appuser.setLastLoginDate(new Date()); + } // update the last logged in date for the user dataAccessService.saveDomainObject(appuser, additionalParams); -- cgit 1.2.3-korg