From cfb69f44f841338e1f208225ec006388e986bd2c Mon Sep 17 00:00:00 2001 From: "Kotta, Shireesha (sk434m)" Date: Tue, 6 Mar 2018 09:44:53 -0500 Subject: Added Junits & AAF attributes Support Issue-ID: PORTAL-136 Includes JUNITS, AAF attributes support Change-Id: Id4cc9f64268017665d7245d0a10369c9b498ba2f Signed-off-by: Kotta, Shireesha (sk434m) --- .../service/OnBoardingApiServiceImpl.java | 54 +++++++++++----------- 1 file changed, 28 insertions(+), 26 deletions(-) (limited to 'ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service') diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java index bfd0fc89..f19a14b6 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/service/OnBoardingApiServiceImpl.java @@ -108,6 +108,7 @@ public class OnBoardingApiServiceImpl implements IPortalRestAPIService, IPortalR .getProperty(PortalApiConstants.ROLE_ACCESS_CENTRALIZED); private static final String isCentralized = "remote"; + private static String portalApiVersion = "/v1"; public OnBoardingApiServiceImpl() { // Defend against null-pointer exception during server startup @@ -229,11 +230,12 @@ public class OnBoardingApiServiceImpl implements IPortalRestAPIService, IPortalR try { if (logger.isDebugEnabled()) logger.debug(EELFLoggerDelegate.debugLogger, "## REST API ## loginId: {}", loginId); - + User user = null; - if(isCentralized.equals(isAccessCentralized)){ - String responseString = restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId); - user = userService.userMapper(responseString); + if (isCentralized.equals(isAccessCentralized)) { + String responseString = restApiRequestBuilder.getViaREST(portalApiVersion+"/user/" + loginId, true, + loginId); + user = userService.userMapper(responseString); } else{ user = userProfileService.getUserByLoginId(loginId); @@ -359,30 +361,30 @@ public class OnBoardingApiServiceImpl implements IPortalRestAPIService, IPortalR logger.debug(EELFLoggerDelegate.debugLogger, "## REST API ## loginId: {}", loginId); List ecompRoles = new ArrayList(); try { - - if(isCentralized.equals(isAccessCentralized)){ + + if (isCentralized.equals(isAccessCentralized)) { User user = null; - String responseString = restApiRequestBuilder.getViaREST("/user/" + loginId, true, loginId); - user = userService.userMapper(responseString); - SortedSet currentRoles = null; - if (user != null) { - currentRoles = user.getRoles(); - if (currentRoles != null) - for (Role role : currentRoles) - ecompRoles.add(UserUtils.convertToEcompRole(role)); - } - } - else{ - User user = userProfileService.getUserByLoginId(loginId); - SortedSet currentRoles = null; - if (user != null) { - currentRoles = user.getRoles(); - currentRoles.removeIf(role -> (role.getActive() == false)); - if (currentRoles != null) - for (Role role : currentRoles) - ecompRoles.add(UserUtils.convertToEcompRole(role)); + String responseString = restApiRequestBuilder.getViaREST(portalApiVersion+"/user/" + loginId, true, + loginId); + user = userService.userMapper(responseString); + SortedSet currentRoles = null; + if (user != null) { + currentRoles = user.getRoles(); + if (currentRoles != null) + for (Role role : currentRoles) + ecompRoles.add(UserUtils.convertToEcompRole(role)); + } + } else { + User user = userProfileService.getUserByLoginId(loginId); + SortedSet currentRoles = null; + if (user != null) { + currentRoles = user.getRoles(); + currentRoles.removeIf(role -> (role.getActive() == false)); + if (currentRoles != null) + for (Role role : currentRoles) + ecompRoles.add(UserUtils.convertToEcompRole(role)); + } } - } return ecompRoles; } catch (Exception e) { String response = "OnboardingApiService.getUserRoles failed"; -- cgit 1.2.3-korg