From 68eabf669e4c83bd669286900e8a6f77e4009f29 Mon Sep 17 00:00:00 2001 From: burdziak Date: Wed, 15 May 2019 15:31:20 +0200 Subject: Fix sonar issues Change-Id: Ia104ca24015784ad0f733f27f5f69dec9b8562e0 Issue-ID: PORTAL-523 Signed-off-by: burdziak --- .../portalapp/controller/core/ProfileSearchController.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core') diff --git a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java index 19bec306..f5d37e2b 100644 --- a/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java +++ b/ecomp-sdk/epsdk-app-common/src/main/java/org/onap/portalapp/controller/core/ProfileSearchController.java @@ -72,6 +72,8 @@ import com.fasterxml.jackson.databind.ObjectMapper; public class ProfileSearchController extends RestrictedBaseController { private static final EELFLoggerDelegate logger = EELFLoggerDelegate.getLogger(ProfileSearchController.class); + + private static final String APPLICATION_JSON = "application/json"; @Autowired private UserProfileService service; @@ -107,7 +109,7 @@ public class ProfileSearchController extends RestrictedBaseController { profileList = service.findAll(); JsonMessage msg = new JsonMessage(mapper.writeValueAsString(profileList)); JSONObject j = new JSONObject(msg); - response.setContentType("application/json"); + response.setContentType(APPLICATION_JSON); response.getWriter().write(j.toString()); } catch (Exception e) { logger.error(EELFLoggerDelegate.applicationLogger, "getUser failed", e); @@ -131,7 +133,7 @@ public class ProfileSearchController extends RestrictedBaseController { model.put("profileList", mapper.writeValueAsString(profileList)); JsonMessage msg = new JsonMessage(mapper.writeValueAsString(model)); JSONObject j = new JSONObject(msg); - response.setContentType("application/json"); + response.setContentType(APPLICATION_JSON); response.getWriter().write(j.toString()); } catch (Exception e) { logger.error(EELFLoggerDelegate.applicationLogger, "getUserPagination failed", e); @@ -139,7 +141,8 @@ public class ProfileSearchController extends RestrictedBaseController { } @SuppressWarnings("unchecked") - private Map setDashboardData(HttpServletRequest request) throws Exception { + private Map setDashboardData(HttpServletRequest request) + throws com.fasterxml.jackson.core.JsonProcessingException { ObjectMapper mapper = new ObjectMapper(); Map model = new HashMap<>(); List> childItemList = new ArrayList<>(); @@ -170,7 +173,7 @@ public class ProfileSearchController extends RestrictedBaseController { logger.info(EELFLoggerDelegate.auditLogger, "Change active status for user " + user.getId() + " to " + user.getActive()); ObjectMapper mapper = new ObjectMapper(); - response.setContentType("application/json"); + response.setContentType(APPLICATION_JSON); PrintWriter out = response.getWriter(); out.write(mapper.writeValueAsString(user.getActive())); } catch (Exception e) { -- cgit 1.2.3-korg