From 59a83dcff26d5e2f53025e84d72838d223c18afc Mon Sep 17 00:00:00 2001 From: Rupinder Date: Thu, 2 Apr 2020 16:38:21 +0530 Subject: removed code smells Removed code smells by improving code structure Issue-ID: PORTAL-865 Change-Id: I8bc5e08fca5d7b40f59a731b1ad00e306584da39 Signed-off-by: Rupinder --- .../java/org/onap/portalsdk/analytics/model/ReportHandler.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java') diff --git a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java index 38f6497c..dc3b1a88 100644 --- a/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java +++ b/ecomp-sdk/epsdk-analytics/src/main/java/org/onap/portalsdk/analytics/model/ReportHandler.java @@ -269,7 +269,8 @@ public class ReportHandler extends org.onap.portalsdk.analytics.RaptorObject { } else { for (Iterator iter = semList.getSemaphore().iterator(); iter.hasNext();) { SemaphoreType sem = (SemaphoreType) iter.next(); - if(!semColumnList.contains(sem.getSemaphoreId())) continue; + if(!semColumnList.contains(sem.getSemaphoreId())) + continue; //System.out.println("SemphoreId ----> " + sem.getSemaphoreId()); FormatList fList = sem.getFormatList(); List formatList = fList.getFormat(); @@ -472,7 +473,9 @@ public class ReportHandler extends org.onap.portalsdk.analytics.RaptorObject { if(name.startsWith("[")) name = name.substring(1); value = st.nextToken(); - if(nvl(value).endsWith("]"))value = nvl(value).substring(0, nvl(value).length()-1); + if(nvl(value).endsWith("]")){ + value = nvl(value).substring(0, nvl(value).length()-1); + } } /*else if(name != null && name.length() > 0) { value = st.nextToken(); if(value.endsWith("]]"))value = value.substring(0, value.length()-1); -- cgit 1.2.3-korg